status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update docs to clarify `RCT_REMAP_METHOD` usage. 

Summary:
The current docs (iOS) for promises make use of the `RCT_REMAP_METHOD` macro but it's not clear about the proper usage for the macro. Specifically, it points to a selector of `resolver:rejector:` and makes it seem like `findEvents` is assumed as both the alias and method name.

This has led to some confusion (#9070) on how to use `RCT_REMAP_METHOD`.

No tests needed since this is just a small docs update.
Closes https://github.com/facebook/react-native/pull/13302

Differential Revision: D4831755

Pulled By: javache

fbshipit-source-id: e842c16ade27088eafdac7509373cdf7780f9ece
This commit is contained in:
Robin Chou 2017-04-05 10:55:02 -07:00 committed by Facebook Github Bot
parent c7387fefc8
commit 269458c613
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/NativeModulesIOS.md
View File

@ -195,7 +195,7 @@ Refactoring the above code to use a promise instead of callbacks looks like this
```objective-c
RCT_REMAP_METHOD(findEvents,
resolver:(RCTPromiseResolveBlock)resolve
findEventsWithResolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject)
{
NSArray *events = ...