From 23e8fcc68c1b873024f326ad53b13ad3ca67ed9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Van=20der=20Auwermeulen=20Gr=C3=A9goire?= Date: Tue, 18 Apr 2017 16:40:11 -0700 Subject: [PATCH] ListItem JSX tag is not closed when used in SectionList Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. When copy pasting the SectionList, got an error with a non closing JSX tag What existing problem does the pull request solve? Closing the JSX tag in 2 files no test required A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Closes https://github.com/facebook/react-native/pull/13525 Differential Revision: D4908495 Pulled By: javache fbshipit-source-id: f2dc49c9238d1da8906f7daf144429a57ad725a3 --- Libraries/Lists/SectionList.js | 2 +- blog/2017-03-13-better-list-views.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/Lists/SectionList.js b/Libraries/Lists/SectionList.js index 757714678..24e400481 100644 --- a/Libraries/Lists/SectionList.js +++ b/Libraries/Lists/SectionList.js @@ -191,7 +191,7 @@ type DefaultProps = typeof defaultProps; * Simple Examples: * * } * renderSectionHeader={({section}) =>

} * sections={[ // homogenous rendering between sections * {data: [...], key: ...}, diff --git a/blog/2017-03-13-better-list-views.md b/blog/2017-03-13-better-list-views.md index 3d7b75745..0b4f3dba7 100644 --- a/blog/2017-03-13-better-list-views.md +++ b/blog/2017-03-13-better-list-views.md @@ -27,7 +27,7 @@ If you want to render a set of data broken into logical sections, maybe with sec ``` } renderSectionHeader={({section}) =>

} sections={[ // homogenous rendering between sections {data: [...], key: ...},