status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix Android startup exception 

Summary:
This is an attempt to fix the following startup exception that I get when running any of the example apps:

> Unrecognized type: interface com.facebook.react.bridge.Dynamic for method: com.facebook.react.uimanager.LayoutShadowNode#setFlexBasis

I really have no idea what I'm doing here, just trying to get UIExplorer to compile and run so I can test my upcoming PRs. ~~Unfortunately, this doesn't actually make the apps run, but at least it does get rid of the startup exception!~~ Edit: it works now.

**Test plan:** Run Movies and UIExplorer example app
Closes https://github.com/facebook/react-native/pull/11896

Differential Revision: D4418927

Pulled By: mkonicek

fbshipit-source-id: 34788b790b6bfc46ff39a0d9ca1698a5c20662e1
This commit is contained in:
Philipp von Weitershausen 2017-01-13 20:23:35 -08:00 committed by Facebook Github Bot
parent c7e3819cf4
commit 237ee2ddf6
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagersPropertyCache.java
View File

@ -12,6 +12,7 @@ import java.util.Map;
import android.view.View; import android.view.View;
import com.facebook.common.logging.FLog; import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.Dynamic;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.ReadableMap;
@ -114,6 +115,22 @@ import com.facebook.react.uimanager.annotations.ReactPropGroup;
protected abstract @Nullable Object extractProperty(ReactStylesDiffMap props); protected abstract @Nullable Object extractProperty(ReactStylesDiffMap props);
} }
private static class DynamicPropSetter extends PropSetter {
public DynamicPropSetter(ReactProp prop, Method setter) {
super(prop, "mixed", setter);
}
public DynamicPropSetter(ReactPropGroup prop, Method setter, int index) {
super(prop, "mixed", setter, index);
}
@Override
protected Object extractProperty(ReactStylesDiffMap props) {
return props.getDynamic(mPropName);
}
}
private static class IntPropSetter extends PropSetter { private static class IntPropSetter extends PropSetter {
private final int mDefaultValue; private final int mDefaultValue;
@ -331,7 +348,9 @@ import com.facebook.react.uimanager.annotations.ReactPropGroup;
ReactProp annotation, ReactProp annotation,
Method method, Method method,
Class<?> propTypeClass) { Class<?> propTypeClass) {
if (propTypeClass == boolean.class) { if (propTypeClass == Dynamic.class) {
return new DynamicPropSetter(annotation, method);
} else if (propTypeClass == boolean.class) {
return new BooleanPropSetter(annotation, method, annotation.defaultBoolean()); return new BooleanPropSetter(annotation, method, annotation.defaultBoolean());
} else if (propTypeClass == int.class) { } else if (propTypeClass == int.class) {
return new IntPropSetter(annotation, method, annotation.defaultInt()); return new IntPropSetter(annotation, method, annotation.defaultInt());
@ -361,7 +380,13 @@ import com.facebook.react.uimanager.annotations.ReactPropGroup;
Class<?> propTypeClass, Class<?> propTypeClass,
Map<String, PropSetter> props) { Map<String, PropSetter> props) {
String[] names = annotation.names(); String[] names = annotation.names();
if (propTypeClass == int.class) { if (propTypeClass == Dynamic.class) {
for (int i = 0; i < names.length; i++) {
props.put(
names[i],
new DynamicPropSetter(annotation, method, i));
}
} else if (propTypeClass == int.class) {
for (int i = 0; i < names.length; i++) { for (int i = 0; i < names.length; i++) {
props.put( props.put(
names[i], names[i],