Removing RCTUIManager.unsafeFlushUIChangesBeforeBatchEnds experiment
Reviewed By: javache Differential Revision: D6432476 fbshipit-source-id: fd02b686cf8bc70a4dfcc02d3bbfdf01c611f351
This commit is contained in:
parent
cd938d731c
commit
21714fe197
|
@ -149,17 +149,6 @@ RCT_EXTERN NSString *const RCTUIManagerWillUpdateViewsDueToContentSizeMultiplier
|
||||||
*/
|
*/
|
||||||
+ (UIView *)JSResponder;
|
+ (UIView *)JSResponder;
|
||||||
|
|
||||||
/**
|
|
||||||
* Normally, UI changes are not applied until the complete batch of method
|
|
||||||
* invocations from JavaScript to native has completed.
|
|
||||||
*
|
|
||||||
* Setting this to YES will flush UI changes sooner, which could potentially
|
|
||||||
* result in inconsistent UI updates.
|
|
||||||
*
|
|
||||||
* The default is NO (recommended).
|
|
||||||
*/
|
|
||||||
@property (atomic, assign) BOOL unsafeFlushUIChangesBeforeBatchEnds;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* In some cases we might want to trigger layout from native side.
|
* In some cases we might want to trigger layout from native side.
|
||||||
* React won't be aware of this, so we need to make sure it happens.
|
* React won't be aware of this, so we need to make sure it happens.
|
||||||
|
|
|
@ -1092,13 +1092,6 @@ RCT_EXPORT_METHOD(dispatchViewManagerCommand:(nonnull NSNumber *)reactTag
|
||||||
[method invokeWithBridge:_bridge module:componentData.manager arguments:args];
|
[method invokeWithBridge:_bridge module:componentData.manager arguments:args];
|
||||||
}
|
}
|
||||||
|
|
||||||
- (void)partialBatchDidFlush
|
|
||||||
{
|
|
||||||
if (self.unsafeFlushUIChangesBeforeBatchEnds) {
|
|
||||||
[self flushUIBlocks];
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
- (void)batchDidComplete
|
- (void)batchDidComplete
|
||||||
{
|
{
|
||||||
[self _layoutAndMount];
|
[self _layoutAndMount];
|
||||||
|
|
|
@ -40,8 +40,7 @@
|
||||||
- (void)uiManagerDidPerformLayout:(RCTUIManager *)manager;
|
- (void)uiManagerDidPerformLayout:(RCTUIManager *)manager;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Called before flushing UI blocks at the end of a batch. Note that this won't
|
* Called before flushing UI blocks at the end of a batch.
|
||||||
* get called for partial batches when using `unsafeFlushUIChangesBeforeBatchEnds`.
|
|
||||||
* This is called from the UIManager queue. Can be used to add UI operations in that batch.
|
* This is called from the UIManager queue. Can be used to add UI operations in that batch.
|
||||||
*/
|
*/
|
||||||
- (void)uiManagerWillFlushUIBlocks:(RCTUIManager *)manager;
|
- (void)uiManagerWillFlushUIBlocks:(RCTUIManager *)manager;
|
||||||
|
|
Loading…
Reference in New Issue