status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Deprecating `-[RCTSurface rootViewTag]` 

Summary:
This diff deprecates `-[RCTSurface rootViewTag]` in favour of `-[RCTSurface rootTag]` which returns
same value but represented as `ReactTag` (`long`) instead of `NSNumber *`.

Reviewed By: mdvacca

Differential Revision: D7857044

fbshipit-source-id: f5427c30d3de2d3563e830f2caac70b7dc9631f9
This commit is contained in:
Valentin Shergin 2018-05-08 22:56:24 -07:00 committed by Facebook Github Bot
parent 25664cc48c
commit 20e88e9ac4
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
React/Fabric/Surface/RCTFabricSurface.h
View File

@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#import <React/RCTPrimitives.h>
#import <React/RCTSurfaceStage.h> #import <React/RCTSurfaceStage.h>
NS_ASSUME_NONNULL_BEGIN NS_ASSUME_NONNULL_BEGIN
@ -37,7 +38,7 @@ NS_ASSUME_NONNULL_BEGIN
@property (atomic, readonly) RCTSurfaceStage stage; @property (atomic, readonly) RCTSurfaceStage stage;
@property (atomic, readonly) RCTBridge *bridge; @property (atomic, readonly) RCTBridge *bridge;
@property (atomic, readonly) NSString *moduleName; @property (atomic, readonly) NSString *moduleName;
@property (atomic, readonly) NSNumber *rootViewTag; @property (atomic, readonly) ReactTag rootTag;
@property (atomic, readwrite, weak, nullable) id<RCTSurfaceDelegate> delegate; @property (atomic, readwrite, weak, nullable) id<RCTSurfaceDelegate> delegate;
@ -124,4 +125,13 @@ NS_ASSUME_NONNULL_BEGIN
@end @end
@interface RCTFabricSurface (Deprecated)
/**
* Deprecated. Use `rootTag` instead.
*/
@property (atomic, readonly) NSNumber *rootViewTag;
@end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END

1
React/Fabric/Surface/RCTFabricSurface.mm
View File

@ -28,7 +28,6 @@
// Immutable // Immutable
RCTSurfacePresenter *_surfacePresenter; RCTSurfacePresenter *_surfacePresenter;
NSString *_moduleName; NSString *_moduleName;
ReactTag _rootTag;
// Protected by the `_mutex` // Protected by the `_mutex`
std::mutex _mutex; std::mutex _mutex;