status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Suppress lint errors in Dialog module. remove abortOnError=false (#19740) 

Summary:
Suppress lint errors in Dialog module. remove abortOnError=false.

This might hide future problems, so removing it
``` gradle
lintOptions {
  abortOnError false
}
```

Builds locally just fine. But CI is failing for unknown reasons. https://circleci.com/gh/dulmandakh/react-native/265

RNTester will built without errors
Closes https://github.com/facebook/react-native/pull/19740

Differential Revision: D8450600

Pulled By: hramos

fbshipit-source-id: faf508a0c546af18a05ee224628f88b02a38ab9f
This commit is contained in:
Dulmandakh 2018-06-15 14:26:20 -07:00 committed by Facebook Github Bot
parent 77a02c0d83
commit 18e9ea2112
4 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
RNTester/android/app/build.gradle
View File

@ -121,10 +121,6 @@ android {
} }
} }
lintOptions {
abortOnError false
}
// applicationVariants are e.g. debug, release // applicationVariants are e.g. debug, release
applicationVariants.all { variant -> applicationVariants.all { variant ->
variant.outputs.each { output -> variant.outputs.each { output ->

2
ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java
View File

@ -9,6 +9,7 @@ package com.facebook.react.modules.dialog;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import android.annotation.SuppressLint;
import android.app.AlertDialog; import android.app.AlertDialog;
import android.app.Dialog; import android.app.Dialog;
import android.app.DialogFragment; import android.app.DialogFragment;
@ -34,6 +35,7 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC
mListener = null; mListener = null;
} }
@SuppressLint("ValidFragment")
public AlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) { public AlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
mListener = listener; mListener = listener;
setArguments(arguments); setArguments(arguments);

2
ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java
View File

@ -9,6 +9,7 @@ package com.facebook.react.modules.dialog;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import android.annotation.SuppressLint;
import android.app.Dialog; import android.app.Dialog;
import android.content.DialogInterface; import android.content.DialogInterface;
import android.os.Bundle; import android.os.Bundle;
@ -27,6 +28,7 @@ public class SupportAlertFragment extends DialogFragment implements DialogInterf
mListener = null; mListener = null;
} }
@SuppressLint("ValidFragment")
public SupportAlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) { public SupportAlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
mListener = listener; mListener = listener;
setArguments(arguments); setArguments(arguments);

8
build.gradle
View File

@ -35,12 +35,4 @@ allprojects {
url "$androidSdk/extras/m2repository/" url "$androidSdk/extras/m2repository/"
} }
} }
project.configurations.all {
resolutionStrategy.eachDependency { details ->
if (details.requested.group == 'com.facebook.soloader') {
details.useVersion "0.3.0"
}
}
}
} }