From 18badf1c3e7411ec8cc0450027080e21d56255fe Mon Sep 17 00:00:00 2001 From: Marc Horowitz Date: Thu, 24 Mar 2016 19:41:27 -0700 Subject: [PATCH] Move CREATE_CATALYST_INSTANCE_END marker inside JSCExecutor Reviewed By: AaaChiuuu Differential Revision: D3096157 fb-gh-sync-id: 6bcca134e5e7a426719816047ffc98a5178e9596 shipit-source-id: 6bcca134e5e7a426719816047ffc98a5178e9596 --- .../main/java/com/facebook/react/ReactInstanceManagerImpl.java | 3 +-- ReactAndroid/src/main/jni/react/JSCExecutor.cpp | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerImpl.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerImpl.java index 0c480eb58..63c00c3cb 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerImpl.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerImpl.java @@ -77,7 +77,6 @@ import static com.facebook.react.bridge.ReactMarkerConstants.BUILD_NATIVE_MODULE import static com.facebook.react.bridge.ReactMarkerConstants.BUILD_NATIVE_MODULE_REGISTRY_START; import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_CATALYST_INSTANCE_END; import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_CATALYST_INSTANCE_START; -import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_REACT_CONTEXT_END; import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_REACT_CONTEXT_START; import static com.facebook.react.bridge.ReactMarkerConstants.PROCESS_PACKAGES_END; import static com.facebook.react.bridge.ReactMarkerConstants.PROCESS_PACKAGES_START; @@ -858,6 +857,7 @@ import static com.facebook.react.bridge.ReactMarkerConstants.RUN_JS_BUNDLE_START .setNativeModuleCallExceptionHandler(exceptionHandler); ReactMarker.logMarker(CREATE_CATALYST_INSTANCE_START); + // CREATE_CATALYST_INSTANCE_END is in JSCExecutor.cpp Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "createCatalystInstance"); CatalystInstance catalystInstance; try { @@ -882,7 +882,6 @@ import static com.facebook.react.bridge.ReactMarkerConstants.RUN_JS_BUNDLE_START ReactMarker.logMarker(RUN_JS_BUNDLE_END); } - ReactMarker.logMarker(CREATE_REACT_CONTEXT_END); return reactContext; } diff --git a/ReactAndroid/src/main/jni/react/JSCExecutor.cpp b/ReactAndroid/src/main/jni/react/JSCExecutor.cpp index a4067aaef..a30b7107f 100644 --- a/ReactAndroid/src/main/jni/react/JSCExecutor.cpp +++ b/ReactAndroid/src/main/jni/react/JSCExecutor.cpp @@ -243,6 +243,7 @@ void JSCExecutor::loadApplicationScript( evaluateScript(m_context, jsScript, jsSourceURL, m_deviceCacheDir.c_str()); } flush(); + ReactMarker::logMarker("CREATE_REACT_CONTEXT_END"); } void JSCExecutor::loadApplicationUnbundle(