status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-27 09:45:04 +00:00
Code Issues Projects Releases Wiki Activity

Fix RCTNativeTraceEndSection calls

Browse Source 
Summary: public

For "some" reason, exception is never `NULL`, it's `null` (the JavaScript value),
so the calls will never finish.

Reviewed By: javache

Differential Revision: D2625896

fb-gh-sync-id: fc8176a6ac485bfecc9903db05bf69b39ac2d9b4
This commit is contained in:
Tadeu Zagallo 2015-11-06 08:27:39 -08:00 committed by facebook-github-bot-6
parent de586bfa18
commit 16d9f045d1
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
React/Executors/RCTContextExecutor.m
View File

@ -202,9 +202,7 @@ static JSValueRef RCTNativeTraceEndSection(JSContextRef context, __unused JSObje
{
if (argumentCount > 0) {
double tag = JSValueToNumber(context, arguments[0], exception);
if (exception == NULL) {
RCTProfileEndEvent((uint64_t)tag, @"console", nil);
}
RCTProfileEndEvent((uint64_t)tag, @"console", nil);
}
return JSValueMakeUndefined(context);