status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix bug on GettingStarted.md page when clicking nav buttons in FF 

Summary:
Hi,
The [commit](156d3ed7a2?_pjax=%23js-repo-pjax-container) by JoelMarcey is much appreciated.  However, when you click on the nav buttons in Firefox (v46.0.1, I'm on El-Capitan), it will switch the content but also navigate you to the React-Native homepage.  This doesn't happen in Chrome, so that's how it probably slipped through.
I propose these changes to fix that.

**Test plan**
Tested locally on FF and Chrome on El-Capitan
Closes https://github.com/facebook/react-native/pull/7435

Differential Revision: D3276285

Pulled By: vjeux

fb-gh-sync-id: c9a14059e609297fe273d02fe6c0a5f98ec7060c
fbshipit-source-id: c9a14059e609297fe273d02fe6c0a5f98ec7060c
This commit is contained in:
Atif Mansoor 2016-05-09 09:41:51 -07:00 committed by Facebook Github Bot 2
parent b24d471fb2
commit 146df61775
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/GettingStarted.md
View File

@ -36,12 +36,12 @@ block { display: none; }
display: block;
}</style>
<span>Platform:</span>
<a href="" class="button-ios" onclick="display('platform', 'ios')">iOS</a>
<a href="" class="button-android" onclick="display('platform', 'android')">Android</a>
<a href="javascript:void(0);" class="button-ios" onclick="display('platform', 'ios')">iOS</a>
<a href="javascript:void(0);" class="button-android" onclick="display('platform', 'android')">Android</a>
<span>OS:</span>
<a href="" class="button-mac" onclick="display('os', 'mac')">Mac</a>
<a href="" class="button-linux" onclick="display('os', 'linux')">Linux</a>
<a href="" class="button-windows" onclick="display('os', 'windows')">Windows</a>
<a href="javascript:void(0);" class="button-mac" onclick="display('os', 'mac')">Mac</a>
<a href="javascript:void(0);" class="button-linux" onclick="display('os', 'linux')">Linux</a>
<a href="javascript:void(0);" class="button-windows" onclick="display('os', 'windows')">Windows</a>
</div>
<!-- ######### LINUX AND WINDOWS for iOS ##################### -->