status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-27 16:40:38 +00:00
Code Issues Projects Releases Wiki Activity

Skip unnecessary string allocs from frquently executed code paths.

Browse Source 
Differential Revision: D2540814

fb-gh-sync-id: 045d012b52a6bc89d409bcc028532da1760c5775
This commit is contained in:
Krzysztof Magiera 2015-10-14 09:21:52 -07:00 committed by facebook-github-bot-6
parent aae9f0255f
commit 10a9b94b9c
3 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/bridge/JavaScriptModuleRegistration.java
View File

@ -66,7 +66,9 @@ class JavaScriptModuleRegistration {
public int getMethodId(Method method) {
final Integer id = mMethodsToIds.get(method);
Assertions.assertNotNull(id, "Unknown method: " + method.getName());
if (id == null) {
Assertions.assertUnreachable("Unknown method: " + method.getName());
}
return id.intValue();
}

9
ReactAndroid/src/main/java/com/facebook/react/bridge/SoftAssertions.java
View File

@ -19,6 +19,15 @@ import javax.annotation.Nullable;
*/
public class SoftAssertions {
/**
* Throw {@link AssertionException} with a given message. Use this method surrounded with
* {@code if} block with assert condition in case you plan to do string concatenation to produce
* the message.
*/
public static void assertUnreachable(String message) {
throw new AssertionException(message);
}
/**
* Asserts the given condition, throwing an {@link AssertionException} if the condition doesn't
* hold.

16
ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java
View File

@ -27,13 +27,11 @@ import com.facebook.react.animation.AnimationListener;
import com.facebook.react.animation.AnimationRegistry;
import com.facebook.react.bridge.Callback;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.SoftAssertions;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.touch.JSResponderHandler;
import com.facebook.react.uimanager.events.EventDispatcher;
/**
* Delegate of {@link UIManagerModule} that owns the native view hierarchy and mapping between
@ -420,9 +418,10 @@ import com.facebook.react.uimanager.events.EventDispatcher;
public void removeRootView(int rootViewTag) {
UiThreadUtil.assertOnUiThread();
SoftAssertions.assertCondition(
mRootTags.get(rootViewTag),
"View with tag " + rootViewTag + " is not registered as a root view");
if (!mRootTags.get(rootViewTag)) {
SoftAssertions.assertUnreachable(
"View with tag " + rootViewTag + " is not registered as a root view");
}
View rootView = mTagsToViews.get(rootViewTag);
dropView(rootView);
mRootTags.delete(rootViewTag);
@ -455,9 +454,10 @@ import com.facebook.react.uimanager.events.EventDispatcher;
}
public void setJSResponder(int reactTag, boolean blockNativeResponder) {
SoftAssertions.assertCondition(
!mRootTags.get(reactTag),
"Cannot block native responder on " + reactTag + " that is a root view");
if (mRootTags.get(reactTag)) {
SoftAssertions.assertUnreachable(
"Cannot block native responder on " + reactTag + " that is a root view");
}
ViewParent viewParent = blockNativeResponder ? mTagsToViews.get(reactTag).getParent() : null;
mJSResponderHandler.setJSResponder(reactTag, viewParent);
}