status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-05 14:13:26 +00:00
Code Issues Projects Releases Wiki Activity

Do not expose BundleDownloader from DevServerHelper

Browse Source 
Summary:
Adds `downloadBundleFromURL` as a delegating method to `DevServerHelper` rather than exposing the underlying `BundleDownloader`.

The additional encapsulation will allow futher factoring of `BundleDownloader` to make logic for different delta bundler clients easier to implement and maintain.

Reviewed By: pakoito

Differential Revision: D6871225

fbshipit-source-id: 6adcab5e69869a234baf38f1f1e60abd34d6b555
This commit is contained in:
David Aurelio 2018-02-05 11:35:15 -08:00 committed by Facebook Github Bot
parent d4517ddb9f
commit 108f9664bf
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
View File

@ -19,6 +19,7 @@ import com.facebook.react.R;
import com.facebook.react.bridge.UiThreadUtil; import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.common.ReactConstants; import com.facebook.react.common.ReactConstants;
import com.facebook.react.common.network.OkHttpCallUtil; import com.facebook.react.common.network.OkHttpCallUtil;
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
import com.facebook.react.devsupport.interfaces.PackagerStatusCallback; import com.facebook.react.devsupport.interfaces.PackagerStatusCallback;
import com.facebook.react.devsupport.interfaces.StackFrame; import com.facebook.react.devsupport.interfaces.StackFrame;
import com.facebook.react.modules.systeminfo.AndroidInfoHelpers; import com.facebook.react.modules.systeminfo.AndroidInfoHelpers;
@ -391,8 +392,10 @@ public class DevServerHelper {
AndroidInfoHelpers.getFriendlyDeviceName()); AndroidInfoHelpers.getFriendlyDeviceName());
} }
public BundleDownloader getBundleDownloader() { public void downloadBundleFromURL(
return mBundleDownloader; DevBundleDownloadListener callback,
File outputFile, String bundleURL, BundleDownloader.BundleInfo bundleInfo) {
mBundleDownloader.downloadBundleFromURL(callback, outputFile, bundleURL, bundleInfo);
} }
/** /**

2
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
View File

@ -1039,7 +1039,7 @@ public class DevSupportManagerImpl implements
final BundleDownloader.BundleInfo bundleInfo = new BundleDownloader.BundleInfo(); final BundleDownloader.BundleInfo bundleInfo = new BundleDownloader.BundleInfo();
mDevServerHelper.getBundleDownloader().downloadBundleFromURL( mDevServerHelper.downloadBundleFromURL(
new DevBundleDownloadListener() { new DevBundleDownloadListener() {
@Override @Override
public void onSuccess() { public void onSuccess() {