status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-03 13:14:42 +00:00
Code Issues Projects Releases Wiki Activity

Fix format specifier used in RCTCxxMethod

Browse Source 
Summary:
[`CxxModule::Method::callbacks`](2161f92aaf/ReactCommon/cxxreact/CxxModule.h (L66)) is `size_t` which uses `%zu` as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.

Local builds with clang 5.
Closes https://github.com/facebook/react-native/pull/15402

Differential Revision: D5583710

Pulled By: javache

fbshipit-source-id: 1d1e740c275fddfea177cf9476cd1d03b7e27330
This commit is contained in:
Dave Lee 2017-08-08 11:35:34 -07:00 committed by Facebook Github Bot
parent d013ba3915
commit 0e3117c972
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
React/CxxModule/RCTCxxMethod.mm
View File

@ -66,7 +66,7 @@ using namespace facebook::react;
CxxModule::Callback second;
if (arguments.count < _method->callbacks) {
RCTLogError(@"Method %@.%s expects at least %lu arguments, but got %tu",
RCTLogError(@"Method %@.%s expects at least %zu arguments, but got %tu",
RCTBridgeModuleNameForClass([module class]), _method->name.c_str(),
_method->callbacks, arguments.count);
return nil;