status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-27 01:40:08 +00:00
Code Issues Projects Releases Wiki Activity

Revert D7343566: [RN] Fixed race condition in RCTUIManager's mounting process

Browse Source 
Differential Revision:
D7343566

Original commit changeset: e45a691add5e

fbshipit-source-id: 08ec04538c07dc3cd630240da8bb42a932a23b6f
This commit is contained in:
Valentin Shergin 2018-03-22 17:32:08 -07:00 committed by Facebook Github Bot
parent cf642c9b1d
commit 0376baf4b3
1 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
React/Modules/RCTUIManager.m
View File

@ -69,9 +69,6 @@ NSString *const RCTUIManagerWillUpdateViewsDueToContentSizeMultiplierChangeNotif
// Keyed by viewName
NSDictionary *_componentDataByName;
BOOL _isMountingInProgress;
BOOL _isRemountingNeeded;
}
@synthesize bridge = _bridge;
@ -1049,19 +1046,6 @@ RCT_EXPORT_METHOD(dispatchViewManagerCommand:(nonnull NSNumber *)reactTag
*/
- (void)_layoutAndMount
{
// Mounting is (usually, not always) an asynchronous process.
// So, we have to ensure that there is no any case of self-interleaving
// (when another mourning process is initiated before the previous
// one finishes) here.
if (_isMountingInProgress) {
// In a case when another mounting process hasn't completed yet,
// we have to run another pass right after it finishes.
_isRemountingNeeded = YES;
return;
}
_isMountingInProgress = YES;
[self _dispatchPropsDidChangeEvents];
[self _dispatchChildrenDidChangeEvents];
@ -1079,13 +1063,6 @@ RCT_EXPORT_METHOD(dispatchViewManagerCommand:(nonnull NSNumber *)reactTag
[self flushUIBlocksWithCompletion:^{
[self->_observerCoordinator uiManagerDidPerformMounting:self];
self->_isMountingInProgress = NO;
if (self->_isRemountingNeeded) {
self->_isRemountingNeeded = NO;
[self _layoutAndMount];
}
}];
}