status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/.github/PULL_REQUEST_TEMPLATE.md

47 lines
1.6 KiB
Markdown
Raw Normal View History

Update templates, CONTRIBUTING Summary: Continuation of #14730 which didn't land cleanly. Closes https://github.com/facebook/react-native/pull/14753 Differential Revision: D5329443 Pulled By: hramos fbshipit-source-id: 2abb94d2aeaeb8694bebdc2dc0319520635d43cd
2017-06-27 16:25:07 +00:00
<!--
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Update PR and issue templates and guidelines Summary:- Simplified the PR and Issue template to make them easier to read. - Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this) Closes https://github.com/facebook/react-native/pull/6295 Differential Revision: D3011905 fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 17:14:32 +00:00
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
Help us understand your motivation by explaining why you decided to make this change.
Update guidelines. Summary: Consolidate tips on CONTRIBUTING.md, and reduce the wall of text when opening a new issue. Hoping this will encourage more people to read through the text. Closes https://github.com/facebook/react-native/pull/14518 Differential Revision: D5250443 Pulled By: hramos fbshipit-source-id: 91213c4ceca12225d9f54d1e1e81e020c6e463b3
2017-06-14 22:08:46 +00:00
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
Pull requests should target master branch Summary: Make it more obvious that pull requests should generally target the `master` branch. Provide visible clarity in both the `CONTRIBUTING.md` and the actual pull request template. Closes https://github.com/facebook/react-native/pull/8748 Differential Revision: D3566827 fbshipit-source-id: 6326f18b93594e928b1c4e0d09a739a8ccedaa62
2016-07-15 02:00:29 +00:00
Update templates, CONTRIBUTING Summary: Continuation of #14730 which didn't land cleanly. Closes https://github.com/facebook/react-native/pull/14753 Differential Revision: D5329443 Pulled By: hramos fbshipit-source-id: 2abb94d2aeaeb8694bebdc2dc0319520635d43cd
2017-06-27 16:25:07 +00:00
Happy contributing!
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
Update templates, CONTRIBUTING Summary: Continuation of #14730 which didn't land cleanly. Closes https://github.com/facebook/react-native/pull/14753 Differential Revision: D5329443 Pulled By: hramos fbshipit-source-id: 2abb94d2aeaeb8694bebdc2dc0319520635d43cd
2017-06-27 16:25:07 +00:00
-->
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
add release notes/changelog requirement to PR Template Summary: grabbou has to write release notes for every release, and that's getting ridonc. Have you seen the changelog from 0.48? PR writers need to do their own, hopefully in a standardized format so it can be scripted. Just a PR template change, just proofreading needed. Please mention if have missed or added any extra Categories, Types, or Where columns. Here's a sample: [GENERAL] [ENHANCEMENT] [PULL_REQUEST_TEMPLATE.md] - added release notes/changelog requirement to PR Template Closes https://github.com/facebook/react-native/pull/15874 Differential Revision: D6054557 Pulled By: hramos fbshipit-source-id: 5741b98a0efdb1a6aaaeedaa292403b82ce713f6
2017-10-13 20:26:38 +00:00
## Motivation
Cleanup stray markdown files, update contributing guidelines Summary: Several changes here. The `Text.md` and `PixelRatio.md` files were appended to the autodocs during site generation. This seemed excessive for just two files, so I've just merged the content into the autodocs themselves. It should help us simplify the website generation process in the future. I've also merged IssueGuidelines.md and PullRequestGuidelines.md into the Contribution/Maintainers guidelines to improve their visibility. Finally, I renamed Help to Community in the nav bar. Ran the website locally, and verified every page rendered as expected: the Community page, Contributing page, Maintainers page. Closes https://github.com/facebook/react-native/pull/15374 Differential Revision: D5567400 Pulled By: hramos fbshipit-source-id: e06056edb12c9a17319fe1af46b2ef3a2e1b5854
2017-08-04 23:14:25 +00:00
(Write your motivation here.)
## Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
add release notes/changelog requirement to PR Template Summary: grabbou has to write release notes for every release, and that's getting ridonc. Have you seen the changelog from 0.48? PR writers need to do their own, hopefully in a standardized format so it can be scripted. Just a PR template change, just proofreading needed. Please mention if have missed or added any extra Categories, Types, or Where columns. Here's a sample: [GENERAL] [ENHANCEMENT] [PULL_REQUEST_TEMPLATE.md] - added release notes/changelog requirement to PR Template Closes https://github.com/facebook/react-native/pull/15874 Differential Revision: D6054557 Pulled By: hramos fbshipit-source-id: 5741b98a0efdb1a6aaaeedaa292403b82ce713f6
2017-10-13 20:26:38 +00:00
## Release Notes
<!--
Help reviewers and the release process by writing your own release notes
**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
CATEGORY
[----------] TYPE
[ CLI ] [-------------] LOCATION
[ DOCS ] [ BREAKING ] [-------------]
Fix typo in PULL_REQUEST_TEMPLATE.md Summary: Found a typo. N/A [INTERNAL] [MINOR] [GitHub] -Fix typo in PULL_REQUEST_TEMPLATE.md Closes https://github.com/facebook/react-native/pull/16723 Differential Revision: D6260883 Pulled By: hramos fbshipit-source-id: 7feb8ba60f5c63849ef89ef8385c7ddf52ed65e3
2017-11-07 18:31:23 +00:00
[ GENERAL ] [ BUGFIX ] [-{Component}-]
add release notes/changelog requirement to PR Template Summary: grabbou has to write release notes for every release, and that's getting ridonc. Have you seen the changelog from 0.48? PR writers need to do their own, hopefully in a standardized format so it can be scripted. Just a PR template change, just proofreading needed. Please mention if have missed or added any extra Categories, Types, or Where columns. Here's a sample: [GENERAL] [ENHANCEMENT] [PULL_REQUEST_TEMPLATE.md] - added release notes/changelog requirement to PR Template Closes https://github.com/facebook/react-native/pull/15874 Differential Revision: D6054557 Pulled By: hramos fbshipit-source-id: 5741b98a0efdb1a6aaaeedaa292403b82ce713f6
2017-10-13 20:26:38 +00:00
[ INTERNAL ] [ ENHANCEMENT ] [ {File} ]
[ IOS ] [ FEATURE ] [ {Directory} ] |-----------|
[ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} |
[----------] [-------------] [-------------] |-----------|
[CATEGORY] [TYPE] [LOCATION] - MESSAGE
EXAMPLES:
[IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
[ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
[CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
[DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
[GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
[INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->