2015-02-20 04:10:52 +00:00
|
|
|
/**
|
2015-03-23 18:48:02 +00:00
|
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
|
|
*
|
2018-02-17 02:24:55 +00:00
|
|
|
* This source code is licensed under the MIT license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree.
|
2018-05-11 19:43:49 +00:00
|
|
|
*
|
|
|
|
* @format
|
2015-02-20 04:10:52 +00:00
|
|
|
*/
|
2018-05-11 19:43:49 +00:00
|
|
|
|
2015-02-20 04:10:52 +00:00
|
|
|
'use strict';
|
|
|
|
|
2015-04-24 17:31:28 +00:00
|
|
|
var chalk = require('chalk');
|
2015-02-20 04:10:52 +00:00
|
|
|
var fs = require('fs');
|
2015-11-11 21:43:11 +00:00
|
|
|
var path = require('path');
|
|
|
|
var child_process = require('child_process');
|
2016-06-21 17:45:44 +00:00
|
|
|
const isAbsolutePath = require('absolute-path');
|
2016-11-04 19:56:39 +00:00
|
|
|
const shellQuote = require('shell-quote');
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
|
|
|
|
function isTerminalEditor(editor) {
|
|
|
|
switch (editor) {
|
|
|
|
case 'vim':
|
|
|
|
case 'emacs':
|
|
|
|
case 'nano':
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-11-11 21:43:11 +00:00
|
|
|
// Map from full process name to binary that starts the process
|
|
|
|
// We can't just re-use full process name, because it will spawn a new instance
|
|
|
|
// of the app every time
|
|
|
|
var COMMON_EDITORS = {
|
|
|
|
'/Applications/Atom.app/Contents/MacOS/Atom': 'atom',
|
2017-04-03 16:06:27 +00:00
|
|
|
'/Applications/Atom Beta.app/Contents/MacOS/Atom Beta':
|
|
|
|
'/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',
|
2017-09-26 21:54:24 +00:00
|
|
|
'/Applications/IntelliJ IDEA.app/Contents/MacOS/idea': 'idea',
|
2015-11-11 21:43:11 +00:00
|
|
|
'/Applications/Sublime Text.app/Contents/MacOS/Sublime Text':
|
|
|
|
'/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl',
|
|
|
|
'/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2':
|
|
|
|
'/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl',
|
2016-06-21 17:45:44 +00:00
|
|
|
'/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code',
|
2017-09-26 21:54:24 +00:00
|
|
|
'/Applications/WebStorm.app/Contents/MacOS/webstorm': 'webstorm',
|
2015-11-11 21:43:11 +00:00
|
|
|
};
|
|
|
|
|
2018-09-04 18:27:17 +00:00
|
|
|
// Transpiled version of: /^[\p{L}0-9/.\-_\\]+$/u
|
|
|
|
// Non-transpiled version requires support for Unicode property regex. Allows
|
|
|
|
// alphanumeric characters, periods, dashes, slashes, and underscores.
|
|
|
|
const WINDOWS_FILE_NAME_WHITELIST = /^(?:[\x2D-9A-Z\\_a-z\xAA\xB5\xBA\xC0-\xD6\xD8-\xF6\xF8-\u02C1\u02C6-\u02D1\u02E0-\u02E4\u02EC\u02EE\u0370-\u0374\u0376\u0377\u037A-\u037D\u037F\u0386\u0388-\u038A\u038C\u038E-\u03A1\u03A3-\u03F5\u03F7-\u0481\u048A-\u052F\u0531-\u0556\u0559\u0560-\u0588\u05D0-\u05EA\u05EF-\u05F2\u0620-\u064A\u066E\u066F\u0671-\u06D3\u06D5\u06E5\u06E6\u06EE\u06EF\u06FA-\u06FC\u06FF\u0710\u0712-\u072F\u074D-\u07A5\u07B1\u07CA-\u07EA\u07F4\u07F5\u07FA\u0800-\u0815\u081A\u0824\u0828\u0840-\u0858\u0860-\u086A\u08A0-\u08B4\u08B6-\u08BD\u0904-\u0939\u093D\u0950\u0958-\u0961\u0971-\u0980\u0985-\u098C\u098F\u0990\u0993-\u09A8\u09AA-\u09B0\u09B2\u09B6-\u09B9\u09BD\u09CE\u09DC\u09DD\u09DF-\u09E1\u09F0\u09F1\u09FC\u0A05-\u0A0A\u0A0F\u0A10\u0A13-\u0A28\u0A2A-\u0A30\u0A32\u0A33\u0A35\u0A36\u0A38\u0A39\u0A59-\u0A5C\u0A5E\u0A72-\u0A74\u0A85-\u0A8D\u0A8F-\u0A91\u0A93-\u0AA8\u0AAA-\u0AB0\u0AB2\u0AB3\u0AB5-\u0AB9\u0ABD\u0AD0\u0AE0\u0AE1\u0AF9\u0B05-\u0B0C\u0B0F\u0B10\u0B13-\u0B28\u0B2A-\u0B30\u0B32\u0B33\u0B35-\u0B39\u0B3D\u0B5C\u0B5D\u0B5F-\u0B61\u0B71\u0B83\u0B85-\u0B8A\u0B8E-\u0B90\u0B92-\u0B95\u0B99\u0B9A\u0B9C\u0B9E\u0B9F\u0BA3\u0BA4\u0BA8-\u0BAA\u0BAE-\u0BB9\u0BD0\u0C05-\u0C0C\u0C0E-\u0C10\u0C12-\u0C28\u0C2A-\u0C39\u0C3D\u0C58-\u0C5A\u0C60\u0C61\u0C80\u0C85-\u0C8C\u0C8E-\u0C90\u0C92-\u0CA8\u0CAA-\u0CB3\u0CB5-\u0CB9\u0CBD\u0CDE\u0CE0\u0CE1\u0CF1\u0CF2\u0D05-\u0D0C\u0D0E-\u0D10\u0D12-\u0D3A\u0D3D\u0D4E\u0D54-\u0D56\u0D5F-\u0D61\u0D7A-\u0D7F\u0D85-\u0D96\u0D9A-\u0DB1\u0DB3-\u0DBB\u0DBD\u0DC0-\u0DC6\u0E01-\u0E30\u0E32\u0E33\u0E40-\u0E46\u0E81\u0E82\u0E84\u0E87\u0E88\u0E8A\u0E8D\u0E94-\u0E97\u0E99-\u0E9F\u0EA1-\u0EA3\u0EA5\u0EA7\u0EAA\u0EAB\u0EAD-\u0EB0\u0EB2\u0EB3\u0EBD\u0EC0-\u0EC4\u0EC6\u0EDC-\u0EDF\u0F00\u0F40-\u0F47\u0F49-\u0F6C\u0F88-\u0F8C\u1000-\u102A\u103F\u1050-\u1055\u105A-\u105D\u1061\u1065\u1066\u106E-\u1070\u1075-\u1081\u108E\u10A0-\u10C5\u10C7\u10CD\u10D0-\u10FA\u10FC-\u1248\u124A-\u124D\u1250-\u1256\u1258\u125A-\u125D\u1260-\u1288\u128A-\u128D\u1290-\u12B0\u12B2-\u12B5\u12B8-\u12BE\u12C0\u12C2-\u12C5\u12C8-\u12D6\u12D8-\u1310\u1312-\u1315\u1318-\u135A\u1380-\u138F\u13A0-\u13F5\u13F8-\u13FD\u1401-\u166C\u166F-\u167F\u1681-\u169A\u16A0-\u16EA\u16F1-\u16F8\u1700-\u170C\u170E-\u1711\u1720-\u1731\u1740-\u1751\u1760-\u176C\u176E-\u1770\u1780-\u17B3\u17D7\u17DC\u1820-\u1878\u1880-\u1884\u1887-\u18A8\u18AA\u18B0-\u18F5\u1900-\u191E\u1950-\u196D\u1970-\u1974\u1980-\u19AB\u19B0-\u19C9\u1A00-\u1A16\u1A20-\u1A54\u1AA7\u1B05-\u1B33\u1B45-\u1B4B\u1B83-\u1BA0\u1BAE\u1BAF\u1BBA-\u1BE5\u1C00-\u1C23\u1C4D-\u1C4F\u1C5A-\u1C7D\u1C80-\u1C88\u1C90-\u1CBA\u1CBD-\u1CBF\u1CE9-\u1CEC\u1CEE-\u1CF1\u1CF5\u1CF6\u1D00-\u1DBF\u1E00-\u1F15\u1F18-\u1F1D\u1F20-\u1F45\u1F48-\u1F4D\u1F50-\u1F57\u1F59\u1F5B\u1F5D\u1F5F-\u1F7D\u1F80-\u1FB4\u1FB6-\u1FBC\u1FBE\u1FC2-\u1FC4\u1FC6-\u1FCC\u1FD0-\u1FD3\u1FD6-\u1FDB\u1FE0-\u1FEC\u1FF2-\u1FF4\u1FF6-\u1FFC\u2071\u207F\u2090-\u209C\u2102\u2107\u210A-\u2113\u2115\u2119-\u211D\u2124\u2126\u2128\u212A-\u212D\u212F-\u2139\u213C-\u213F\u2145-\u2149\u214E\u2183\u2184\u2C00-\u2C2E\u2C30-\u2C5E\u2C60-\u2CE4\u2CEB-\u2CEE\u2CF2\u2CF3\u2D00-\u2D25\u2D27\u2D2D\u2D30-\u2D67\u2D6F\u2D80-\u2D96\u2DA0-\u2DA6\u2DA8-\u2DAE\u2DB0-\u2DB6\u2DB8-\u2DBE\u2DC0-\u2DC6\u2DC8-\u2DCE\u2DD0-\u2DD6\u2DD8-\u2DDE\u2E2F\u3005\u3006\u3031-\u3035\u303B\u303C\u3041-\u3096\u309D-\u309F\u30A1-\u30FA\u30FC-\u30FF\u3105-\u312F\u3131-\u318E\u31A0-\u31BA\u31F0-\u31FF\u3400-\u4DB5\u4E00-\u9FEF\uA000-\uA48C\uA4D0-\uA4FD\uA500-\uA60C\uA610-\uA61F\uA62A\uA62B\uA640-\uA66E\uA67F-\uA69D\uA6A0-\uA6E5\uA717-\uA71F\uA722-\uA788\uA78B-\uA7B9\uA7F7-\uA801\uA803-\uA805\uA807-\uA80A\uA80C-\uA822\uA840-\uA873\uA882-\uA8B3\uA8F2-\uA8F7\uA8FB\uA8FD\uA8FE\uA90A-\uA925\uA930-\uA946\uA960-\uA97C\uA984-\uA9B2\uA9CF\uA9E0-\uA9E4\uA9E6-\uA9EF\uA9FA-\uA9FE\uAA00-\uAA28\uAA40-\uAA42\uAA44-\uAA4B\uAA60-\uAA76\uAA7A\uAA7E-\uAAAF\uAAB1\uAAB5\uAAB6\uAAB9-\uAABD\uAAC0\uAAC2\uAADB-\uAADD\uAAE0-\uAAEA\uAAF2-\uAAF4\uAB01-\uAB06\uAB09-\uAB0E\uAB11-\uAB16\uAB20-\uAB26\uAB28-\uAB2E\uAB30-\uAB5A\uAB5C-\uAB65\uAB70-\uABE2\uAC00-\uD7A3\uD7B0-\uD7C6\uD7CB-\uD7FB\uF900-\uFA6D\uFA7
|
|
|
|
|
2016-06-21 17:45:44 +00:00
|
|
|
function addWorkspaceToArgumentsIfExists(args, workspace) {
|
|
|
|
if (workspace) {
|
|
|
|
args.unshift(workspace);
|
|
|
|
}
|
|
|
|
return args;
|
|
|
|
}
|
|
|
|
|
|
|
|
function getArgumentsForLineNumber(editor, fileName, lineNumber, workspace) {
|
2015-11-11 21:43:11 +00:00
|
|
|
switch (path.basename(editor)) {
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
case 'vim':
|
|
|
|
case 'mvim':
|
|
|
|
return [fileName, '+' + lineNumber];
|
|
|
|
case 'atom':
|
2016-11-04 19:56:39 +00:00
|
|
|
case 'Atom':
|
|
|
|
case 'Atom Beta':
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
case 'subl':
|
|
|
|
case 'sublime':
|
2017-09-26 21:54:24 +00:00
|
|
|
case 'webstorm':
|
2016-07-27 11:40:41 +00:00
|
|
|
case 'wstorm':
|
|
|
|
case 'appcode':
|
2016-12-08 01:04:08 +00:00
|
|
|
case 'charm':
|
2017-04-03 16:06:27 +00:00
|
|
|
case 'idea':
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
return [fileName + ':' + lineNumber];
|
|
|
|
case 'joe':
|
|
|
|
case 'emacs':
|
2015-10-21 16:55:21 +00:00
|
|
|
case 'emacsclient':
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
return ['+' + lineNumber, fileName];
|
2015-09-23 23:59:44 +00:00
|
|
|
case 'rmate':
|
|
|
|
case 'mate':
|
2015-11-04 15:54:57 +00:00
|
|
|
case 'mine':
|
2015-09-23 23:59:44 +00:00
|
|
|
return ['--line', lineNumber, fileName];
|
2016-06-21 17:45:44 +00:00
|
|
|
case 'code':
|
2018-05-11 19:43:49 +00:00
|
|
|
return addWorkspaceToArgumentsIfExists(
|
|
|
|
['-g', fileName + ':' + lineNumber],
|
|
|
|
workspace,
|
|
|
|
);
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// For all others, drop the lineNumber until we have
|
|
|
|
// a mapping above, since providing the lineNumber incorrectly
|
|
|
|
// can result in errors or confusing behavior.
|
|
|
|
return [fileName];
|
|
|
|
}
|
2015-04-24 17:31:28 +00:00
|
|
|
|
2015-11-11 21:43:11 +00:00
|
|
|
function guessEditor() {
|
|
|
|
// Explicit config always wins
|
|
|
|
if (process.env.REACT_EDITOR) {
|
2016-11-04 19:56:39 +00:00
|
|
|
return shellQuote.parse(process.env.REACT_EDITOR);
|
2015-11-11 21:43:11 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Using `ps x` on OSX we can find out which editor is currently running.
|
|
|
|
// Potentially we could use similar technique for Windows and Linux
|
|
|
|
if (process.platform === 'darwin') {
|
|
|
|
try {
|
|
|
|
var output = child_process.execSync('ps x').toString();
|
|
|
|
var processNames = Object.keys(COMMON_EDITORS);
|
|
|
|
for (var i = 0; i < processNames.length; i++) {
|
|
|
|
var processName = processNames[i];
|
|
|
|
if (output.indexOf(processName) !== -1) {
|
2016-11-04 19:56:39 +00:00
|
|
|
return [COMMON_EDITORS[processName]];
|
2015-11-11 21:43:11 +00:00
|
|
|
}
|
|
|
|
}
|
2017-10-10 00:37:08 +00:00
|
|
|
} catch (error) {
|
2015-11-11 21:43:11 +00:00
|
|
|
// Ignore...
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Last resort, use old skool env vars
|
2016-11-04 19:56:39 +00:00
|
|
|
if (process.env.VISUAL) {
|
|
|
|
return [process.env.VISUAL];
|
|
|
|
} else if (process.env.EDITOR) {
|
|
|
|
return [process.env.EDITOR];
|
|
|
|
}
|
|
|
|
|
2017-04-28 13:06:16 +00:00
|
|
|
return [null];
|
2015-11-11 21:43:11 +00:00
|
|
|
}
|
|
|
|
|
2015-04-24 17:31:28 +00:00
|
|
|
function printInstructions(title) {
|
2018-05-11 19:43:49 +00:00
|
|
|
console.log(
|
|
|
|
[
|
|
|
|
'',
|
|
|
|
chalk.bgBlue.white.bold(' ' + title + ' '),
|
|
|
|
' When you see Red Box with stack trace, you can click any ',
|
|
|
|
' stack frame to jump to the source file. The packager will launch your ',
|
|
|
|
' editor of choice. It will first look at REACT_EDITOR environment ',
|
|
|
|
' variable, then at EDITOR. To set it up, you can add something like ',
|
|
|
|
' export REACT_EDITOR=atom to your ~/.bashrc or ~/.zshrc depending on ',
|
|
|
|
' which shell you use.',
|
|
|
|
'',
|
|
|
|
].join('\n'),
|
|
|
|
);
|
2015-02-20 04:10:52 +00:00
|
|
|
}
|
|
|
|
|
2016-06-21 17:45:44 +00:00
|
|
|
function transformToAbsolutePathIfNeeded(pathName) {
|
|
|
|
if (!isAbsolutePath(pathName)) {
|
|
|
|
pathName = path.resolve(process.cwd(), pathName);
|
|
|
|
}
|
|
|
|
return pathName;
|
|
|
|
}
|
|
|
|
|
|
|
|
function findRootForFile(projectRoots, fileName) {
|
|
|
|
fileName = transformToAbsolutePathIfNeeded(fileName);
|
2018-05-11 19:43:49 +00:00
|
|
|
return projectRoots.find(root => {
|
2016-06-21 17:45:44 +00:00
|
|
|
root = transformToAbsolutePathIfNeeded(root);
|
|
|
|
return fileName.startsWith(root + path.sep);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
var _childProcess = null;
|
2016-06-21 17:45:44 +00:00
|
|
|
function launchEditor(fileName, lineNumber, projectRoots) {
|
2015-02-20 04:10:52 +00:00
|
|
|
if (!fs.existsSync(fileName)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
Sanitize lineNumber in launchEditor
Summary:Shelling out on win32 does not properly escape the command due to https://github.com/nodejs/node/blob/c3bb4b1aa5e907d489619fb43d233c3336bfc03d/lib/child_
This patch ensures a proper lineNumber before continuing, similar to how we check that the fileName passed exists.
**Test plan**
On platform `win32` or given appropriate testing changes to `launchEditor.js`...
With the following `request-bad` file:
```
GET /open-stack-frame HTTP/1.1
Host: 127.0.0.1:8081
Proxy-Connection: keep-alive
Cache-Control: max-age=0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36
Accept-Encoding: gzip, deflate, sdch
Accept-Language: en-US,en;q=0.8
Content-Length: 64
{"file":"C:\\Windows\\system.ini","lineNumber":"123\" && calc"}
```
`$ nc localhost 8081 < request-bad`
Observe that before this patch `calc` would launch and afte
Closes https://github.com/facebook/react-native/pull/6299
Differential Revision: D3012074
Pulled By: davidaurelio
fb-gh-sync-id: cbc7b6e5c60529a289c0989a95593a322333ba5d
shipit-source-id: cbc7b6e5c60529a289c0989a95593a322333ba5d
2016-03-04 20:03:38 +00:00
|
|
|
// Sanitize lineNumber to prevent malicious use on win32
|
|
|
|
// via: https://github.com/nodejs/node/blob/c3bb4b1aa5e907d489619fb43d233c3336bfc03d/lib/child_process.js#L333
|
|
|
|
if (lineNumber && isNaN(lineNumber)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-12-16 18:16:51 +00:00
|
|
|
let [editor, ...args] = guessEditor();
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
if (!editor) {
|
|
|
|
printInstructions('PRO TIP');
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-06-21 17:45:44 +00:00
|
|
|
var workspace = findRootForFile(projectRoots, fileName);
|
2015-02-20 04:10:52 +00:00
|
|
|
if (lineNumber) {
|
2018-05-11 19:43:49 +00:00
|
|
|
args = args.concat(
|
|
|
|
getArgumentsForLineNumber(editor, fileName, lineNumber, workspace),
|
|
|
|
);
|
2016-11-04 19:56:39 +00:00
|
|
|
} else {
|
|
|
|
args.push(fileName);
|
2015-02-20 04:10:52 +00:00
|
|
|
}
|
2018-09-04 18:27:17 +00:00
|
|
|
|
|
|
|
// cmd.exe on Windows is vulnerable to RCE attacks given a file name of the
|
|
|
|
// form "C:\Users\myusername\Downloads\& curl 172.21.93.52". Use a whitelist
|
|
|
|
// to validate user-provided file names. This doesn't cover the entire range
|
|
|
|
// of valid file names but should cover almost all of them in practice.
|
|
|
|
if (
|
|
|
|
process.platform === 'win32' &&
|
|
|
|
!WINDOWS_FILE_NAME_WHITELIST.test(fileName.trim())
|
|
|
|
) {
|
|
|
|
console.log();
|
|
|
|
console.log(
|
|
|
|
chalk.red(
|
|
|
|
'Could not open ' + path.basename(fileName) + ' in the editor.',
|
|
|
|
),
|
|
|
|
);
|
|
|
|
console.log();
|
|
|
|
console.log(
|
|
|
|
'When running on Windows, file names are checked against a whitelist ' +
|
|
|
|
'to protect against remote code execution attacks. File names may ' +
|
|
|
|
'consist only of alphanumeric characters (all languages), periods, ' +
|
|
|
|
'dashes, slashes, and underscores.',
|
|
|
|
);
|
|
|
|
console.log();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-05-11 19:43:49 +00:00
|
|
|
console.log(
|
|
|
|
'Opening ' + chalk.underline(fileName) + ' with ' + chalk.bold(editor),
|
|
|
|
);
|
2015-02-20 04:10:52 +00:00
|
|
|
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
if (_childProcess && isTerminalEditor(editor)) {
|
|
|
|
// There's an existing editor process already and it's attached
|
|
|
|
// to the terminal, so go kill it. Otherwise two separate editor
|
|
|
|
// instances attach to the stdin/stdout which gets confusing.
|
|
|
|
_childProcess.kill('SIGKILL');
|
2015-04-24 17:31:28 +00:00
|
|
|
}
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
|
2016-01-11 21:27:00 +00:00
|
|
|
if (process.platform === 'win32') {
|
|
|
|
// On Windows, launch the editor in a shell because spawn can only
|
|
|
|
// launch .exe files.
|
2018-05-11 19:43:49 +00:00
|
|
|
_childProcess = child_process.spawn(
|
|
|
|
'cmd.exe',
|
|
|
|
['/C', editor].concat(args),
|
|
|
|
{stdio: 'inherit'},
|
|
|
|
);
|
2016-01-11 21:27:00 +00:00
|
|
|
} else {
|
|
|
|
_childProcess = child_process.spawn(editor, args, {stdio: 'inherit'});
|
|
|
|
}
|
Fix various issues with packager editor launcher
Summary: There are a few small bugs with the code that launches the editor from the packager:
* First of all, the filepath is not escaped which means tokens like `(` or spaces will mess up the process execution. Dropbox unfortunately decided to use spaces in its enterprise product, so I was getting this error:
![screen shot 2015-07-11 at 3 20 54 pm](https://cloud.githubusercontent.com/assets/1135007/8635748/186e7f2e-27ea-11e5-8058-1f4dabb79634.png)
* Next, the line number argument formatting was assumed to be in a specific format (`:%d`) which actually errors out vim and other editors.
* Lastly, the process was started synchronously but not attached to the stdin / stdout of the parent process. This means that only editors like mvim, sublime, and others would work since they spawn a new window. Editors like emacs, vi, nano, etc wouldn't work and instead just hang at the command line.
So I whipped up this diff to fix a number of these issues, demo here:
http://recordit.co/M6zwiUj7hp
The demo shows both
Closes https://github.com/facebook/react-native/pull/1957
Reviewed By: @vjeux, @pcottle
Differential Revision: D2420941
Pulled By: @frantic
2015-09-14 16:57:43 +00:00
|
|
|
_childProcess.on('exit', function(errorCode) {
|
|
|
|
_childProcess = null;
|
|
|
|
|
|
|
|
if (errorCode) {
|
|
|
|
console.log(chalk.red('Your editor exited with an error!'));
|
|
|
|
printInstructions('Keep these instructions in mind:');
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
_childProcess.on('error', function(error) {
|
|
|
|
console.log(chalk.red(error.message));
|
|
|
|
printInstructions('How to fix:');
|
2015-11-11 21:43:11 +00:00
|
|
|
});
|
2015-02-20 04:10:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
module.exports = launchEditor;
|