status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-24 07:08:27 +00:00
Code Issues Projects Releases Wiki Activity
react-native/.github/PULL_REQUEST_TEMPLATE.md

16 lines
728 B
Markdown
Raw Normal View History

Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->
Update guidelines. Summary: Consolidate tips on CONTRIBUTING.md, and reduce the wall of text when opening a new issue. Hoping this will encourage more people to read through the text. Closes https://github.com/facebook/react-native/pull/14518 Differential Revision: D5250443 Pulled By: hramos fbshipit-source-id: 91213c4ceca12225d9f54d1e1e81e020c6e463b3
2017-06-14 15:08:46 -07:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
## Summary
Update PULL_REQUEST_TEMPLATE.md Summary: Quick edit to ensure people are aware of the new docs location. Closes https://github.com/facebook/react-native/pull/17085 Differential Revision: D6492000 Pulled By: hramos fbshipit-source-id: 6ec2b5d2dadb30cefb1d23c740ca5449b3998468
2017-12-05 16:38:02 -08:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
## Changelog
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
<!-- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. -->
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
[CATEGORY] [TYPE] - Message
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Update Pull Request and Issue templates. (#23187) Summary: As a maintainer, I noticed that the description for a PR is often missing, which makes it hard to understand why a change is made. Because some of the text isn't using HTML comments, the same text explaining how to fill out the changelog and test plan pops up and isn't removed by people. This PR fixes both of these issues. I also made another small update to the main issue template to urge people to use one of the other templates, with an explanation that we will close poorly formatted issues. Changelog: ---------- [General] [Changed] - Updated GitHub templates Pull Request resolved: https://github.com/facebook/react-native/pull/23187 Differential Revision: D13877752 Pulled By: cpojer fbshipit-source-id: 8ed88cde9151a41931848cccc669208cabe1e9ef
2019-01-30 08:28:01 -08:00
## Test Plan
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Update issue templates (#23296) Summary: Go back to simpler issue template titles, with emoji. The goal is to make it easier, at a glance, to pick the right template. We also add a new "regression" template that will automatically label the issue as a regression. Other changes: - Added Christoph as a CODEOWNER for package.json and markdown file changes. Usually, any PR that touches package.json has to be imported manually by a Facebook employee. [General] [Changed] - Updated GitHub issue templates. Pull Request resolved: https://github.com/facebook/react-native/pull/23296 Differential Revision: D13974378 Pulled By: hramos fbshipit-source-id: d8962a84397c16e7556ac167a3505f7c7d725915
2019-02-06 11:13:15 -08:00
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->
Reference in New Issue Copy Permalink