status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/.github/PULL_REQUEST_TEMPLATE.md

20 lines
1.1 KiB
Markdown
Raw Normal View History

Update PR and issue templates and guidelines Summary:- Simplified the PR and Issue template to make them easier to read. - Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this) Closes https://github.com/facebook/react-native/pull/6295 Differential Revision: D3011905 fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 17:14:32 +00:00
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
Pull requests should target master branch Summary: Make it more obvious that pull requests should generally target the `master` branch. Provide visible clarity in both the `CONTRIBUTING.md` and the actual pull request template. Closes https://github.com/facebook/react-native/pull/8748 Differential Revision: D3566827 fbshipit-source-id: 6326f18b93594e928b1c4e0d09a739a8ccedaa62
2016-07-15 02:00:29 +00:00
> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**
Tweak PR and issue templates Reviewed By: mkonicek Differential Revision:D2949403 Ninja: oss-only fb-gh-sync-id: 8e8f68140c833ff8d7c600647dabb52b5ce4d527 shipit-source-id: 8e8f68140c833ff8d7c600647dabb52b5ce4d527
2016-02-18 18:53:41 +00:00
Explain the **motivation** for making this change. What existing problem does the pull request solve?
PR and Issue templates Reviewed By: mkonicek Differential Revision:D2946749 Ninja: GitHub-only fb-gh-sync-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d shipit-source-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d
2016-02-17 23:57:27 +00:00
Tweak commands and guidelines Reviewed By: mkonicek Differential Revision:D3074972 Ninja: oss only fb-gh-sync-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d shipit-source-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d
2016-03-20 20:13:18 +00:00
Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
PR and Issue templates Reviewed By: mkonicek Differential Revision:D2946749 Ninja: GitHub-only fb-gh-sync-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d shipit-source-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d
2016-02-17 23:57:27 +00:00
**Test plan (required)**
Update PR and issue templates and guidelines Summary:- Simplified the PR and Issue template to make them easier to read. - Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this) Closes https://github.com/facebook/react-native/pull/6295 Differential Revision: D3011905 fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 17:14:32 +00:00
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
PR and Issue templates Reviewed By: mkonicek Differential Revision:D2946749 Ninja: GitHub-only fb-gh-sync-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d shipit-source-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d
2016-02-17 23:57:27 +00:00
Update PR and issue templates and guidelines Summary:- Simplified the PR and Issue template to make them easier to read. - Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this) Closes https://github.com/facebook/react-native/pull/6295 Differential Revision: D3011905 fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 17:14:32 +00:00
Make sure tests pass on both Travis and Circle CI.
PR and Issue templates Reviewed By: mkonicek Differential Revision:D2946749 Ninja: GitHub-only fb-gh-sync-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d shipit-source-id: ac8a316ca4c2982a063040d57ddc1f279b81b59d
2016-02-17 23:57:27 +00:00
**Code formatting**
Update PR and issue guidelines Reviewed By: mkonicek Differential Revision:D3054017 Ninja: oss only fb-gh-sync-id: df545cb45ae8de3f56f671b06cab84b1f947a01c shipit-source-id: df545cb45ae8de3f56f671b06cab84b1f947a01c
2016-03-15 18:48:11 +00:00
Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).
Update the PR template Summary: Added a link to the contributing.md -- there's a bunch of stuff there that's not mentioned in this template. Closes https://github.com/facebook/react-native/pull/6899 Differential Revision: D3245105 fb-gh-sync-id: 4d462dded04cf83afdd9b6dddcbc45aa7ecd7cd9 fbshipit-source-id: 4d462dded04cf83afdd9b6dddcbc45aa7ecd7cd9
2016-04-30 04:14:59 +00:00
For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests).