status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-24 15:18:10 +00:00
Code Issues Projects Releases Wiki Activity
react-native/.github/PULL_REQUEST_TEMPLATE.md

17 lines
651 B
Markdown
Raw Normal View History

Add test case suggestion to PR template Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/21234 Differential Revision: D9982500 Pulled By: hramos fbshipit-source-id: 585d4a8292ac7f53f26adf53a36e766a49fdc5b6
2018-09-20 17:42:36 -07:00
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b
2018-12-17 15:40:41 -08:00
Help us understand your motivation by explaining why you decided to make this change:
Update guidelines. Summary: Consolidate tips on CONTRIBUTING.md, and reduce the wall of text when opening a new issue. Hoping this will encourage more people to read through the text. Closes https://github.com/facebook/react-native/pull/14518 Differential Revision: D5250443 Pulled By: hramos fbshipit-source-id: 91213c4ceca12225d9f54d1e1e81e020c6e463b3
2017-06-14 15:08:46 -07:00
Update PULL_REQUEST_TEMPLATE.md Summary: Quick edit to ensure people are aware of the new docs location. Closes https://github.com/facebook/react-native/pull/17085 Differential Revision: D6492000 Pulled By: hramos fbshipit-source-id: 6ec2b5d2dadb30cefb1d23c740ca5449b3998468
2017-12-05 16:38:02 -08:00
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Changelog:
----------
Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b
2018-12-17 15:40:41 -08:00
Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example.
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b
2018-12-17 15:40:41 -08:00
[CATEGORY] [TYPE] - Message
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b
2018-12-17 15:40:41 -08:00
Test Plan:
----------
Make PR template consistent with Changelog (#22117) Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/react-native-releases#47. Pull Request resolved: https://github.com/facebook/react-native/pull/22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
2018-11-04 11:27:53 -08:00
Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b
2018-12-17 15:40:41 -08:00
Write your test plan here (**REQUIRED**). If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! Increase test coverage whenever possible.
Reference in New Issue Copy Permalink