From c4fde1d3237b8a30dad1b1b5d9fa097f89c70a0f Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Tue, 11 Sep 2018 11:02:16 +0800 Subject: [PATCH 1/4] try reuse tooling config from React Native --- android/build.gradle | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index e7613cb..d731387 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -1,17 +1,22 @@ apply plugin: 'com.android.library' +def DEFAULT_COMPILE_SDK_VERSION = 26 +def DEFAULT_BUILD_TOOLS_VERSION = "26.0.3" +def DEFAULT_MIN_SDK_VERSION = 16 +def DEFAULT_TARGET_SDK_VERSION = 26 + android { - compileSdkVersion 26 - buildToolsVersion '26.0.3' + compileSdkVersion rootProject.findProperty('compileSdkVersion') ?: DEFAULT_COMPILE_SDK_VERSION + buildToolsVersion rootProject.findProperty('buildToolsVersion') ?: DEFAULT_BUILD_TOOLS_VERSION defaultConfig { - minSdkVersion 16 - targetSdkVersion 26 + minSdkVersion rootProject.findProperty('minSdkVersion') ?: DEFAULT_MIN_SDK_VERSION + targetSdkVersion rootProject.findProperty('targetSdkVersion') ?: DEFAULT_TARGET_SDK_VERSION versionCode 1 versionName "1.0" } } dependencies { - compile 'com.facebook.react:react-native:+' + implementation 'com.facebook.react:react-native:+' } From 1461ba26e21467cf0e29336f7034d64b50191986 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Tue, 11 Sep 2018 17:22:54 +0800 Subject: [PATCH 2/4] use compile instead of implementation to support gradle plugin 2.x used in RN 0.56 --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index d731387..4876490 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -18,5 +18,5 @@ android { } dependencies { - implementation 'com.facebook.react:react-native:+' + compile 'com.facebook.react:react-native:+' } From 0f7091ba149b0bc54657778d9e37b3194b94dca4 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Wed, 12 Sep 2018 03:31:44 +0800 Subject: [PATCH 3/4] Revert "use compile instead of implementation to support gradle plugin 2.x used in RN 0.56" --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index 4876490..d731387 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -18,5 +18,5 @@ android { } dependencies { - compile 'com.facebook.react:react-native:+' + implementation 'com.facebook.react:react-native:+' } From 2cd5a421c8d9395a88fd9c033f7476654fb74eaa Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Wed, 12 Sep 2018 03:34:09 +0800 Subject: [PATCH 4/4] use SDK 27, build tools 27.0.3 --- android/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index d731387..d814e4f 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -1,7 +1,7 @@ apply plugin: 'com.android.library' -def DEFAULT_COMPILE_SDK_VERSION = 26 -def DEFAULT_BUILD_TOOLS_VERSION = "26.0.3" +def DEFAULT_COMPILE_SDK_VERSION = 27 +def DEFAULT_BUILD_TOOLS_VERSION = "27.0.3" def DEFAULT_MIN_SDK_VERSION = 16 def DEFAULT_TARGET_SDK_VERSION = 26