From d4ab332891af2242e663ac2e25f4aa3317945399 Mon Sep 17 00:00:00 2001 From: RedPandaTronics Date: Mon, 13 Apr 2020 17:54:47 +0200 Subject: [PATCH] feat(iOS): Add Hardware Silence (#1218) * Fixes Issue #1140 Fixes https://github.com/react-native-community/react-native-webview/issues/1140 Based on a solution found at: https://stackoverflow.com/questions/56460362/how-to-force-wkwebview-to-ignore-hardware-silent-switch-on-ios I changed the code found in the linked source from Swift to Objective-C, as required by this project. WARNING: I haven't used Swift before and very limited experience with Objective-C. - For me this seems to work, but it is not the cleanest solution in my opinion. - It might also be possible to play generated sound (i.e. using oscillator) instead of hardcoding the silent base64 mp3 data. - Maybe ignoring silence switch should only be done if a parameter is supplied * fixes import path * adds documentation for ignoreSilentHardwareSwitch * adds ignoreSilentHardwareSwitch parameter * reverting back to old import path * Update Guide.md Co-authored-by: Dominik Beste --- docs/Guide.md | 7 +++++++ docs/Reference.md | 11 +++++++++++ ios/RNCWebView.m | 45 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+) diff --git a/docs/Guide.md b/docs/Guide.md index 72ce5fa..5205889 100644 --- a/docs/Guide.md +++ b/docs/Guide.md @@ -517,3 +517,10 @@ const App = () => { ``` Note that these cookies will only be sent on the first request unless you use the technique above for [setting custom headers on each page load](#Setting-Custom-Headers). + +### Hardware Silence Switch +There are some inconsistencies in how the hardware silence switch is handled between embedded `audio` and `video` elements and between iOS and Android platforms. + +Audio on `iOS` will be muted when the hardware silence switch is in the on position, unless the `ignoreSilentHardwareSwitch` parameter is set to true. + +Video on `iOS` will always ignore the hardware silence switch. diff --git a/docs/Reference.md b/docs/Reference.md index 0d1512d..68064e3 100644 --- a/docs/Reference.md +++ b/docs/Reference.md @@ -64,6 +64,7 @@ This document lays out the current public properties and methods for the React N - [`allowsLinkPreview`](Reference.md#allowsLinkPreview) - [`sharedCookiesEnabled`](Reference.md#sharedCookiesEnabled) - [`textZoom`](Reference.md#textZoom) +- [`ignoreSilentHardwareSwitch`](Reference.md#ignoreSilentHardwareSwitch) ## Methods Index @@ -1127,6 +1128,16 @@ Example: `` +### `ignoreSilentHardwareSwitch` + +(ios only) + +When set to true the hardware silent switch is ignored. Default: `false` + +| Type | Required | Platform | +| ------- | -------- | -------- | +| boolean | No | iOS | + ## Methods ### `extraNativeComponentConfig()` diff --git a/ios/RNCWebView.m b/ios/RNCWebView.m index 6cbd0e8..11385cf 100644 --- a/ios/RNCWebView.m +++ b/ios/RNCWebView.m @@ -140,6 +140,15 @@ static NSDictionary* customCertificatesForHost; } #if !TARGET_OS_OSX + [[NSNotificationCenter defaultCenter]addObserver:self + selector:@selector(appDidBecomeActive) + name:UIApplicationDidBecomeActiveNotification + object:nil]; + + [[NSNotificationCenter defaultCenter]addObserver:self + selector:@selector(appWillResignActive) + name:UIApplicationWillResignActiveNotification + object:nil]; if (@available(iOS 12.0, *)) { // Workaround for a keyboard dismissal bug present in iOS 12 // https://openradar.appspot.com/radar?id=5018321736957952 @@ -163,6 +172,7 @@ static NSDictionary* customCertificatesForHost; selector:@selector(hideFullScreenVideoStatusBars) name:UIWindowDidBecomeHiddenNotification object:nil]; + } #endif // !TARGET_OS_OSX return self; @@ -1031,6 +1041,37 @@ static NSDictionary* customCertificatesForHost; }]; } +-(void)forceIgnoreSilentHardwareSwitch:(BOOL)initialSetup +{ + NSString *mp3Str = @"data:audio/mp3;base64,//tAxAAAAAAAAAAAAAAAAAAAAAAASW5mbwAAAA8AAAAFAAAESAAzMzMzMzMzMzMzMzMzMzMzMzMzZmZmZmZmZmZmZmZmZmZmZmZmZmaZmZmZmZmZmZmZmZmZmZmZmZmZmczMzMzMzMzMzMzMzMzMzMzMzMzM//////////////////////////8AAAA5TEFNRTMuMTAwAZYAAAAAAAAAABQ4JAMGQgAAOAAABEhNIZS0AAAAAAD/+0DEAAPH3Yz0AAR8CPqyIEABp6AxjG/4x/XiInE4lfQDFwIIRE+uBgZoW4RL0OLMDFn6E5v+/u5ehf76bu7/6bu5+gAiIQGAABQIUJ0QolFghEn/9PhZQpcUTpXMjo0OGzRCZXyKxoIQzB2KhCtGobpT9TRVj/3Pmfp+f8X7Pu1B04sTnc3s0XhOlXoGVCMNo9X//9/r6a10TZEY5DsxqvO7mO5qFvpFCmKIjhpSItGsUYcRO//7QsQRgEiljQIAgLFJAbIhNBCa+JmorCbOi5q9nVd2dKnusTMQg4MFUlD6DQ4OFijwGAijRMfLbHG4nLVTjydyPlJTj8pfPflf9/5GD950A5e+jsrmNZSjSirjs1R7hnkia8vr//l/7Nb+crvr9Ok5ZJOylUKRxf/P9Zn0j2P4pJYXyKkeuy5wUYtdmOu6uobEtFqhIJViLEKIjGxchGev/L3Y0O3bwrIOszTBAZ7Ih28EUaSOZf/7QsQfg8fpjQIADN0JHbGgQBAZ8T//y//t/7d/2+f5m7MdCeo/9tdkMtGLbt1tqnabRroO1Qfvh20yEbei8nfDXP7btW7f9/uO9tbe5IvHQbLlxpf3DkAk0ojYcv///5/u3/7PTfGjPEPUvt5D6f+/3Lea4lz4tc4TnM/mFPrmalWbboeNiNyeyr+vufttZuvrVrt/WYv3T74JFo8qEDiJqJrmDTs///v99xDku2xG02jjunrICP/7QsQtA8kpkQAAgNMA/7FgQAGnobgfghgqA+uXwWQ3XFmGimSbe2X3ksY//KzK1a2k6cnNWOPJnPWUsYbKqkh8RJzrVf///P///////4vyhLKHLrCb5nIrYIUss4cthigL1lQ1wwNAc6C1pf1TIKRSkt+a//z+yLVcwlXKSqeSuCVQFLng2h4AFAFgTkH+Z/8jTX/zr//zsJV/5f//5UX/0ZNCNCCaf5lTCTRkaEdhNP//n/KUjf/7QsQ5AEhdiwAAjN7I6jGddBCO+WGTQ1mXrYatSAgaykxBTUUzLjEwMKqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqg=="; + NSString *scr; + if (initialSetup) { + scr = [NSString stringWithFormat:@"var s=new Audio('%@');s.id='wkwebviewAudio';s.controls=false;s.loop=true;s.play();document.body.appendChild(s);true", mp3Str]; + } else { + scr = [NSString stringWithFormat:@"var s=document.getElementById('wkwebviewAudio');s.src=null;s.parentNode.removeChild(s);s=null;s=new Audio('%@');s.id='wkwebviewAudio';s.controls=false;s.loop=true;s.play();document.body.appendChild(s);true", mp3Str]; + } + [self evaluateJS: scr thenCall: nil]; +} + +-(void)disableIgnoreSilentSwitch +{ + [self evaluateJS: @"document.getElementById('wkwebviewAudio').src=null;true" thenCall: nil]; +} + +-(void)appDidBecomeActive +{ + if (_ignoreSilentHardwareSwitch) { + [self forceIgnoreSilentHardwareSwitch:false]; + } +} + +-(void)appWillResignActive +{ + if (_ignoreSilentHardwareSwitch) { + [self disableIgnoreSilentSwitch]; + } +} + /** * Called when the navigation is complete. * @see https://fburl.com/rtys6jlb @@ -1038,6 +1079,10 @@ static NSDictionary* customCertificatesForHost; - (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation { + if (_ignoreSilentHardwareSwitch) { + [self forceIgnoreSilentHardwareSwitch:true]; + } + if (_onLoadingFinish) { _onLoadingFinish([self baseEvent]); }