From a661df1ffcfdd4b2eb1b82dd05005541897b784e Mon Sep 17 00:00:00 2001 From: Benjos Antony Date: Fri, 1 Mar 2019 05:02:44 +0800 Subject: [PATCH] fix(android:scalesPageToFit): scalesPageToFit does not work as intended , especially for large jpg and png images. (#275) fixes #113 - One can verify that this for jpg images loaded on the webview (eg: https://www.ecda.gov.sg/growatbeanstalk/PublishingImages/READ%20Publications%20and%20Research/Parent%20Infographic%20Series/Infographic%204.jpg) - This is a replication of the pull request that was originally made in the react-native repo (https://github.com/facebook/react-native/pull/17195), but was not merged in due to no reviews. --- .../com/reactnativecommunity/webview/RNCWebViewManager.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java b/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java index 7f7fd0e..b5e2bcc 100644 --- a/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java +++ b/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java @@ -562,7 +562,8 @@ public class RNCWebViewManager extends SimpleViewManager { @ReactProp(name = "scalesPageToFit") public void setScalesPageToFit(WebView view, boolean enabled) { - view.getSettings().setUseWideViewPort(!enabled); + view.getSettings().setLoadWithOverviewMode(enabled); + view.getSettings().setUseWideViewPort(enabled); } @ReactProp(name = "domStorageEnabled")