From 9aa14f1a960bb12c725daa5504e99bd438f826ae Mon Sep 17 00:00:00 2001 From: Scott Beca Date: Mon, 15 Apr 2019 17:56:45 +1000 Subject: [PATCH] fix(android): updating source.html prop doesn't refresh webview (#485) --- .../reactnativecommunity/webview/RNCWebViewManager.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java b/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java index b0b40c5..290e76d 100644 --- a/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java +++ b/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java @@ -373,12 +373,8 @@ public class RNCWebViewManager extends SimpleViewManager { if (source != null) { if (source.hasKey("html")) { String html = source.getString("html"); - if (source.hasKey("baseUrl")) { - view.loadDataWithBaseURL( - source.getString("baseUrl"), html, HTML_MIME_TYPE, HTML_ENCODING, null); - } else { - view.loadData(html, HTML_MIME_TYPE + "; charset=" + HTML_ENCODING, null); - } + String baseUrl = source.hasKey("baseUrl") ? source.getString("baseUrl") : ""; + view.loadDataWithBaseURL(baseUrl, html, HTML_MIME_TYPE, HTML_ENCODING, null); return; } if (source.hasKey("uri")) {