status-im
/
react-native-webview
mirror of https://github.com/status-im/react-native-webview.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(refactor): Converting dispatchEvent static method to non static method (#1939) 

* converting static method dispatch event to non static

* removing typo

* removing typo

Co-authored-by: Gaurav Gupta <gaurkum@microsoft.com>
This commit is contained in:
Gaurav Gupta 2021-03-25 01:58:20 +05:30 committed by GitHub
parent 9d9fda87fa
commit 344ccce3ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
View File

@ -161,13 +161,6 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
mWebViewConfig = webViewConfig;
}
protected static void dispatchEvent(WebView webView, Event event) {
ReactContext reactContext = (ReactContext) webView.getContext();
EventDispatcher eventDispatcher =
reactContext.getNativeModule(UIManagerModule.class).getEventDispatcher();
eventDispatcher.dispatchEvent(event);
}
@Override
public String getName() {
return REACT_CLASS;
@ -838,7 +831,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
RNCWebView reactWebView = (RNCWebView) webView;
reactWebView.callInjectedJavaScriptBeforeContentLoaded();
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopLoadingStartEvent(
webView.getId(),
@ -885,7 +878,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
} else {
FLog.w(TAG, "Couldn't use blocking synchronous call for onShouldStartLoadWithRequest due to debugging or missing Catalyst instance, falling back to old event-and-load.");
progressChangedFilter.setWaitingForCommandLoadUrl(true);
dispatchEvent(
((RNCWebView) view).dispatchEvent(
view,
new TopShouldStartLoadWithRequestEvent(
view.getId(),
@ -992,7 +985,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
eventData.putDouble("code", errorCode);
eventData.putString("description", description);
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopLoadingErrorEvent(webView.getId(), eventData));
}
@ -1010,7 +1003,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
eventData.putInt("statusCode", errorResponse.getStatusCode());
eventData.putString("description", errorResponse.getReasonPhrase());
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopHttpErrorEvent(webView.getId(), eventData));
}
@ -1042,7 +1035,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
WritableMap event = createWebViewEvent(webView, webView.getUrl());
event.putBoolean("didCrash", detail.didCrash());
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopRenderProcessGoneEvent(webView.getId(), event)
);
@ -1052,7 +1045,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
}
protected void emitFinishEvent(WebView webView, String url) {
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopLoadingFinishEvent(
webView.getId(),
@ -1181,7 +1174,7 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
event.putBoolean("canGoBack", webView.canGoBack());
event.putBoolean("canGoForward", webView.canGoForward());
event.putDouble("progress", (float) newProgress / 100);
dispatchEvent(
((RNCWebView) webView).dispatchEvent(
webView,
new TopLoadingProgressEvent(
webView.getId(),
@ -1492,6 +1485,13 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
}
}
protected void dispatchEvent(WebView webView, Event event) {
ReactContext reactContext = (ReactContext) webView.getContext();
EventDispatcher eventDispatcher =
reactContext.getNativeModule(UIManagerModule.class).getEventDispatcher();
eventDispatcher.dispatchEvent(event);
}
protected void cleanupCallbacksAndDestroy() {
setWebViewClient(null);
destroy();