From 279d6ae98c449b3c2d9ab2cc567f99bcc6e298b6 Mon Sep 17 00:00:00 2001
From: Cristiano Coelho <48869228+cristianoccazinsp@users.noreply.github.com>
Date: Thu, 1 Jul 2021 09:29:44 -0300
Subject: [PATCH] fix(logs): remove warning logs for common/handled error
 events. (#2043)

* remove warning logs for common/handled error events.

* re-add warn logs, but only if not handled

Co-authored-by: Cristiano Coelho <cristianocca@hotmail.com>
---
 src/WebView.android.tsx | 5 ++++-
 src/WebView.ios.tsx     | 5 ++++-
 src/WebView.macos.tsx   | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/WebView.android.tsx b/src/WebView.android.tsx
index 6e25b44..8419ff3 100644
--- a/src/WebView.android.tsx
+++ b/src/WebView.android.tsx
@@ -211,13 +211,16 @@ class WebView extends React.Component<AndroidWebViewProps, State> {
   onLoadingError = (event: WebViewErrorEvent) => {
     event.persist(); // persist this event because we need to store it
     const { onError, onLoadEnd } = this.props;
+
     if (onError) {
       onError(event);
+    } else {
+      console.warn('Encountered an error loading page', event.nativeEvent);
     }
+
     if (onLoadEnd) {
       onLoadEnd(event);
     }
-    console.warn('Encountered an error loading page', event.nativeEvent);
 
     this.setState({
       lastErrorEvent: event.nativeEvent,
diff --git a/src/WebView.ios.tsx b/src/WebView.ios.tsx
index eeb264c..fb8be64 100644
--- a/src/WebView.ios.tsx
+++ b/src/WebView.ios.tsx
@@ -195,13 +195,16 @@ class WebView extends React.Component<IOSWebViewProps, State> {
   onLoadingError = (event: WebViewErrorEvent) => {
     event.persist(); // persist this event because we need to store it
     const { onError, onLoadEnd } = this.props;
+
     if (onLoadEnd) {
       onLoadEnd(event);
     }
+
     if (onError) {
       onError(event);
+    } else {
+      console.warn('Encountered an error loading page', event.nativeEvent);
     }
-    console.warn('Encountered an error loading page', event.nativeEvent);
 
     this.setState({
       lastErrorEvent: event.nativeEvent,
diff --git a/src/WebView.macos.tsx b/src/WebView.macos.tsx
index 436b518..a2ad5b1 100644
--- a/src/WebView.macos.tsx
+++ b/src/WebView.macos.tsx
@@ -183,13 +183,16 @@ class WebView extends React.Component<MacOSWebViewProps, State> {
   onLoadingError = (event: WebViewErrorEvent) => {
     event.persist(); // persist this event because we need to store it
     const { onError, onLoadEnd } = this.props;
+
     if (onLoadEnd) {
       onLoadEnd(event);
     }
+
     if (onError) {
       onError(event);
+    } else {
+      console.warn('Encountered an error loading page', event.nativeEvent);
     }
-    console.warn('Encountered an error loading page', event.nativeEvent);
 
     this.setState({
       lastErrorEvent: event.nativeEvent,