status-im
/
react-native-webview
mirror of https://github.com/status-im/react-native-webview.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(android): Updated permissions for Android Q and above (#1384 by @Karthz)

This commit is contained in:
Karthik Subramaniam 2020-05-28 16:47:26 -07:00 committed by GitHub
parent d9c73e0f6f
commit 03dbcb870e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
android/gradle.properties
View File

@ -1,4 +1,4 @@
ReactNativeWebView_kotlinVersion=1.3.50
ReactNativeWebView_compileSdkVersion=28
ReactNativeWebView_buildToolsVersion=28.0.3
ReactNativeWebView_compileSdkVersion=29
ReactNativeWebView_buildToolsVersion=29.0.3
ReactNativeWebView_targetSdkVersion=28

11
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModule.java
View File

@ -272,16 +272,13 @@ public class RNCWebViewModule extends ReactContextBaseJavaModule implements Acti
}
public boolean grantFileDownloaderPermissions() {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
// Permission not required for Android Q and above
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
return true;
}
boolean result = true;
if (ContextCompat.checkSelfPermission(getCurrentActivity(), Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
result = false;
}
if (!result) {
boolean result = ContextCompat.checkSelfPermission(getCurrentActivity(), Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED;
if (!result && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
PermissionAwareActivity activity = getPermissionAwareActivity();
activity.requestPermissions(new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, FILE_DOWNLOAD_PERMISSION_REQUEST, webviewFileDownloaderPermissionListener);
}

4
docs/Guide.md
View File

@ -257,13 +257,13 @@ To be able to save images to the gallery you need to specify this permission in
##### Android
On Android, integration with the DownloadManager is built-in.
All you have to do to support downloads is add these permissions in AndroidManifest.xml:
Add this permisison in AndroidManifest.xml (only required if your app supports Android versions lower than 10):
```xml
<manifest ...>
......
<!-- this is required to save files on Android -->
<!-- this is required to save files on Android versions lower than 10 -->
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
......

4
example/android/build.gradle
View File

@ -2,9 +2,9 @@
buildscript {
ext {
buildToolsVersion = "28.0.3"
buildToolsVersion = "29.0.3"
minSdkVersion = 16
compileSdkVersion = 28
compileSdkVersion = 29
targetSdkVersion = 28
}
repositories {