status-im/react-native-mapbox-gl
1
0
Fork 0
mirror of https://github.com/status-im/react-native-mapbox-gl.git synced 2026-08-31 13:01:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

change getMetricsEnabled to return a promise

Browse Source 
After upgrading to Android SDK 5.0, we cannot put metricsEnabled to
constants of the module. So we change getMetricsEnabled to return a
promise instead of value directly.
This commit is contained in:
Jack Feng
2017-09-01 10:10:27 +08:00
parent 91074ef739
commit ac31979da4
4 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/src/main/java/com/mapbox/reactnativemapboxgl/ReactNativeMapboxGLModule.java
+10 -2
View File
@@ -5,6 +5,7 @@ import android.os.Handler;
import android.util.Log;
import com.facebook.react.bridge.Arguments;
import com.facebook.react.bridge.JSApplicationCausedNativeException;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.ReactApplicationContext;
@@ -130,8 +131,6 @@ public class ReactNativeMapboxGLModule extends ReactContextBaseJavaModule {
// Other constants
constants.put("unknownResourceCount", Long.MAX_VALUE);
// FIXME you cannot get telemetry enabled status before you set access token
// constants.put("metricsEnabled", MapboxTelemetry.getInstance().isTelemetryEnabled());
constants.put("userTrackingMode", userTrackingMode);
constants.put("mapStyles", mapStyles);
@@ -177,6 +176,15 @@ public class ReactNativeMapboxGLModule extends ReactContextBaseJavaModule {
// Metrics
@ReactMethod
public void getMetricsEnabled(final Promise promise) {
try {
promise.resolve(MapboxTelemetry.getInstance().isTelemetryEnabled());
} catch (NullPointerException e) {
promise.reject(new JSApplicationCausedNativeException("You should call getMetricsEnabled after setAccessToken"));
}
}
@ReactMethod
public void setMetricsEnabled(boolean value) {
MapboxTelemetry.getInstance().setTelemetryEnabled(value);