status-im
/
react-native-image-resizer
mirror of https://github.com/status-im/react-native-image-resizer.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix memory leaks and don't rotate unless necessary on Android (#25) 

* fixed memory leakes

* rotate only if necessary
This commit is contained in:
zhi 2016-08-03 07:02:59 -07:00 committed by Florian Rival
parent 3b8d1c1940
commit f24bd5e425
1 changed files with 42 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
android/src/main/java/fr/bamlab/rnimageresizer/ImageResizer.java
View File

@ -27,6 +27,7 @@ import java.util.Date;
class ImageResizer {
private static Bitmap resizeImage(Bitmap image, int maxWidth, int maxHeight, Context context) {
Bitmap newImage = null;
if (image == null) {
return null; // Can't load the image from the given path.
@ -40,10 +41,10 @@ class ImageResizer {
int finalWidth = (int) (width * ratio);
int finalHeight = (int) (height * ratio);
image = Bitmap.createScaledBitmap(image, finalWidth, finalHeight, true);
newImage = Bitmap.createScaledBitmap(image, finalWidth, finalHeight, true);
}
return image;
return newImage;
}
public static Bitmap rotateImage(Bitmap source, float angle)
@ -53,11 +54,6 @@ class ImageResizer {
Matrix matrix = new Matrix();
matrix.postRotate(angle);
retVal = Bitmap.createBitmap(source, 0, 0, source.getWidth(), source.getHeight(), matrix, true);
//for memory purposes
if (retVal != source){
source.recycle();
}
return retVal;
}
@ -122,45 +118,35 @@ class ImageResizer {
/**
* Rotate the given image by reading the Exif value of the image (uri).<br>
* If no rotation is required the image will not be rotated.<br>
* New bitmap is created and the old one is recycled.
* Get orientation by reading Image metadata
*/
public static int getOrientation(Bitmap bitmap, Context context, Uri uri) {
public static int getOrientation(Context context, Uri uri) {
try {
File file = getFileFromUri(context, uri);
if (file.exists()) {
ExifInterface ei = new ExifInterface(file.getAbsolutePath());
return getOrientation(bitmap, ei);
return getOrientation(ei);
}
} catch (Exception ignored) {
}
} catch (Exception ignored) { }
return 0;
}
/**
* Rotate the given image by given Exif value.<br>
* If no rotation is required the image will not be rotated.<br>
* New bitmap is created and the old one is recycled.
* Convert metadata to degrees
*/
public static int getOrientation(Bitmap bitmap, ExifInterface exif) {
int degrees;
public static int getOrientation(ExifInterface exif) {
int orientation = exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_NORMAL);
switch (orientation) {
case ExifInterface.ORIENTATION_ROTATE_90:
degrees = 90;
break;
return 90;
case ExifInterface.ORIENTATION_ROTATE_180:
degrees = 180;
break;
return 180;
case ExifInterface.ORIENTATION_ROTATE_270:
degrees = 270;
break;
return 270;
default:
degrees = 0;
break;
return 0;
}
return degrees;
}
public static String createResizedImage(Context context, String imagePath, int newWidth,
@ -169,31 +155,48 @@ class ImageResizer {
Bitmap image;
Bitmap sourceImage;
if (!imagePath.startsWith("content://") && !imagePath.startsWith("file://")) {
image = BitmapFactory.decodeFile(imagePath);
sourceImage = BitmapFactory.decodeFile(imagePath);
} else {
ContentResolver cr = context.getContentResolver();
Uri url = Uri.parse(imagePath);
InputStream input = cr.openInputStream(url);
image = BitmapFactory.decodeStream(input);
sourceImage = BitmapFactory.decodeStream(input);
input.close();
}
int orientation = getOrientation(image, context, Uri.parse(imagePath));
rotation = orientation+rotation;
// Start transformations:
//rotate & resize
Bitmap newImage = ImageResizer.resizeImage(ImageResizer.rotateImage(image, rotation), newWidth, newHeight, context);
//recycle old image
image.recycle();
// Scale it first so there are fewer pixels to transform in the rotation
Bitmap scaledImage = ImageResizer.resizeImage(sourceImage, newWidth, newHeight, context);
if (sourceImage != scaledImage) {
sourceImage.recycle();
}
// Rotate if neccesary
Bitmap rotatedImage = scaledImage;
if (rotation > 0) {
int orientation = getOrientation(context, Uri.parse(imagePath));
rotation = orientation + rotation;
rotatedImage = ImageResizer.rotateImage(scaledImage, rotation);
}
if (scaledImage != rotatedImage) {
scaledImage.recycle();
}
File path = context.getCacheDir();
if (outputPath != null ) {
if (outputPath != null) {
path = new File(outputPath);
}
return ImageResizer.saveImage(newImage, path,
String resizedImagePath = ImageResizer.saveImage(rotatedImage, path,
Long.toString(new Date().getTime()), compressFormat, quality);
// Clean up remaining image
rotatedImage.recycle();
return resizedImagePath;
}
}