status-im
/
react-native-fs
mirror of https://github.com/status-im/react-native-fs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

uploadFiles mistakes

This commit is contained in:
Chris Dell 2016-05-30 23:35:34 +01:00
parent feb0df0113
commit 45ed423d99
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
FS.common.js
View File

@ -182,7 +182,7 @@ var RNFS = {
uploadFiles(options) {
var jobId = getJobId();
var subscription;
var subscriptions = [];
if (typeof options !== 'object') throw new Error('uploadFiles: Invalid value for argument `options`');
if (typeof options.toUrl !== 'string') throw new Error('uploadFiles: Invalid value for property `toUrl`');
@ -191,16 +191,12 @@ var RNFS = {
if (options.fields && typeof options.fields !== 'object') throw new Error('uploadFiles: Invalid value for property `fields`');
if (options.method && typeof options.method !== 'string') throw new Error('uploadFiles: Invalid value for property `method`');
if (!options.beginCallback) beginCallback = (info) => {
console.log('Upload begun:', info);
};
if (options.beginCallback) {
subscriptions.push(NativeAppEventEmitter.addListener('UploadBegin-' + jobId, begin));
subscriptions.push(NativeAppEventEmitter.addListener('UploadBegin-' + jobId, options.beginCallback));
}
if (options.progressCallback) {
subscriptions.push(NativeAppEventEmitter.addListener('UploadProgress-' + jobId, progress));
subscriptions.push(NativeAppEventEmitter.addListener('UploadProgress-' + jobId, options.progressCallback));
}
var bridgeOptions = {
@ -214,9 +210,7 @@ var RNFS = {
return _uploadFiles(bridgeOptions)
.then(res => {
if (subscription) {
subscription.remove();
}
subscriptions.forEach(sub => sub.remove());
return res;
});
},