From fc4b4932d947e9781495eba4f58c05e86681f089 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filip=20Kinsk=C3=BD?= Date: Wed, 2 Aug 2017 15:59:04 +0200 Subject: [PATCH 1/2] removed createJSModules method (RN 0.47 breaking change) see https://github.com/facebook/react-native/releases/tag/v0.47.0 for explanation --- android/src/main/java/com/rnfs/RNFSPackage.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/android/src/main/java/com/rnfs/RNFSPackage.java b/android/src/main/java/com/rnfs/RNFSPackage.java index d591eef..62aaf19 100644 --- a/android/src/main/java/com/rnfs/RNFSPackage.java +++ b/android/src/main/java/com/rnfs/RNFSPackage.java @@ -17,11 +17,6 @@ public class RNFSPackage implements ReactPackage { return modules; } - @Override - public List> createJSModules() { - return Collections.emptyList(); - } - @Override public List createViewManagers(ReactApplicationContext reactContext) { return Arrays.asList(); From 970384cb2dd8d4ea7df91a141c9cd24cbc228ac4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hagen=20H=C3=BCbel?= Date: Wed, 2 Aug 2017 22:38:48 +0200 Subject: [PATCH 2/2] Added back for Backward-Compat but without @override --- android/src/main/java/com/rnfs/RNFSPackage.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/rnfs/RNFSPackage.java b/android/src/main/java/com/rnfs/RNFSPackage.java index 62aaf19..f9a27a0 100644 --- a/android/src/main/java/com/rnfs/RNFSPackage.java +++ b/android/src/main/java/com/rnfs/RNFSPackage.java @@ -16,9 +16,15 @@ public class RNFSPackage implements ReactPackage { modules.add(new RNFSManager(reactContext)); return modules; } - + + // deprecated >= RN 0.47.0 + public List> createJSModules() { + return Collections.emptyList(); + } + @Override public List createViewManagers(ReactApplicationContext reactContext) { return Arrays.asList(); } + }