status-im/react-native-fs
2
0
Fork 0
mirror of https://github.com/status-im/react-native-fs.git synced 2025-02-28 23:10:29 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #360 from jamesreggio/add-discretionary-flag

Browse Source 
Expose the iOS `discretionary` flag on `downloadFile`
This commit is contained in:
Hagen Hübel 2017-10-06 17:59:33 +02:00 committed by GitHub
commit 1fcaa87240
4 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Downloader.h
View File

@ -15,6 +15,7 @@ typedef void (^ProgressCallback)(NSNumber*, NSNumber*);
@property (copy) BeginCallback beginCallback; // Download has started (headers received) @property (copy) BeginCallback beginCallback; // Download has started (headers received)
@property (copy) ProgressCallback progressCallback; // Download is progressing @property (copy) ProgressCallback progressCallback; // Download is progressing
@property bool background; // Whether to continue download when app is in background @property bool background; // Whether to continue download when app is in background
@property bool discretionary; // Whether the file may be downloaded at the OS's discretion (iOS only)
@property (copy) NSNumber* progressDivider; @property (copy) NSNumber* progressDivider;

1
Downloader.m
View File

@ -45,6 +45,7 @@
if (_params.background) { if (_params.background) {
NSString *uuid = [[NSUUID UUID] UUIDString]; NSString *uuid = [[NSUUID UUID] UUIDString];
config = [NSURLSessionConfiguration backgroundSessionConfigurationWithIdentifier:uuid]; config = [NSURLSessionConfiguration backgroundSessionConfigurationWithIdentifier:uuid];
config.discretionary = _params.discretionary;
} else { } else {
config = [NSURLSessionConfiguration defaultSessionConfiguration]; config = [NSURLSessionConfiguration defaultSessionConfiguration];
} }

3
README.md
View File

@ -496,7 +496,8 @@ type DownloadFileOptions = {
fromUrl: string; // URL to download file from fromUrl: string; // URL to download file from
toFile: string; // Local filesystem path to save the file to toFile: string; // Local filesystem path to save the file to
headers?: Headers; // An object of headers to be passed to the server headers?: Headers; // An object of headers to be passed to the server
background?: boolean; background?: boolean; // Continue the download in the background after the app terminates (iOS only)
discretionary?: boolean; // Allow the OS to control the timing and speed of the download to improve perceived performance (iOS only)
progressDivider?: number; progressDivider?: number;
begin?: (res: DownloadBeginCallbackResult) => void; begin?: (res: DownloadBeginCallbackResult) => void;
progress?: (res: DownloadProgressCallbackResult) => void; progress?: (res: DownloadProgressCallbackResult) => void;

2
RNFSManager.m
View File

@ -422,6 +422,8 @@ RCT_EXPORT_METHOD(downloadFile:(NSDictionary *)options
params.headers = headers; params.headers = headers;
NSNumber* background = options[@"background"]; NSNumber* background = options[@"background"];
params.background = [background boolValue]; params.background = [background boolValue];
NSNumber* discretionary = options[@"discretionary"];
params.discretionary = [discretionary boolValue];
NSNumber* progressDivider = options[@"progressDivider"]; NSNumber* progressDivider = options[@"progressDivider"];
params.progressDivider = progressDivider; params.progressDivider = progressDivider;