Commit Graph

16 Commits

Author SHA1 Message Date
Michael Diarmid 097ffbf494
Merge pull request #726 from AWDGroup/patch-1
Fixed: attempt to insert nil object from objects[0]
2018-01-17 15:16:45 +00:00
Omer Levy 8d7152fe70 avoid call resolve on createShortDynamicLink error and remove try/catch in the js wrapper module 2018-01-12 16:39:18 +02:00
Ardavan Kalhori 74d614ad43
Fixed: attempt to insert nil object from objects[0]
Fixed the issue that was causing a crash in my application:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000011310e12b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00000001127a6f41 objc_exception_throw + 48
	2   CoreFoundation                      0x000000011314e0cc _CFThrowFormattedException + 194
	3   CoreFoundation                      0x0000000113022951 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 321
	4   CoreFoundation                      0x00000001130227db +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	5   Mesghal                             0x000000010ace08c2 sendDynamicLink + 226
	6   Mesghal                             0x000000010ace0d0f __71+[RNFirebaseLinks application:continueUserActivity:restorationHandler:]_block_invoke + 447
	7   libdispatch.dylib                   0x0000000113fcd2f7 _dispatch_call_block_and_release + 12
	8   libdispatch.dylib                   0x0000000113fce33d _dispatch_client_callout + 8
	9   libdispatch.dylib                   0x0000000113fd95f9 _dispatch_main_queue_callback_4CF + 628
	10  CoreFoundation                      0x00000001130d0e39 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	11  CoreFoundation                      0x0000000113095462 __CFRunLoopRun + 2402
	12  CoreFoundation                      0x0000000113094889 CFRunLoopRunSpecific + 409
	13  GraphicsServices                    0x00000001154d29c6 GSEventRunModal + 62
	14  UIKit                               0x000000010f60b5d6 UIApplicationMain + 159
	15  Mesghal                             0x000000010a6b688f main + 111
	16  libdyld.dylib                       0x000000011404ad81 start + 1
)
2018-01-05 16:43:02 -08:00
Chris Bianca 865944d9a9 [ios][links] Remove warning for dynamic links 2017-12-15 16:09:02 +00:00
Omer Levy e9b139f5dd [ios] fix DynamicLink pod import issue and post installation initialization issue 2017-10-14 18:33:30 -04:00
Omer Levy fbdc733d53 flatten dynamicLinkInfo to the top-level, move the mandatory keys validation to the javascript from the native modules and some minor fixes 2017-10-10 16:22:03 +03:00
Omer Levy f2966d46ed [ios] remove native validation for invalid parameters 2017-10-08 21:40:27 -04:00
Omer Levy 20d414652b [ios] fix link creation API, reject invalid arguments on creation and fix tests 2017-10-07 18:00:36 -04:00
Omer Levy ccc178cf05 [ios] change name of parameter packageName to androidPackageName 2017-10-02 00:55:08 +03:00
Omer Levy af4ce2a2ca align links to v3 2017-10-01 02:50:37 +03:00
Omer Levy 482fdb01ad [ios] some refactoring 2017-09-30 12:56:58 -04:00
Omer Levy ba2a04be98 [ios] wrap FIRDynamicLinks methods in the RNFirebaseLinks class 2017-09-30 08:54:11 -04:00
Omer Levy df6b2ac4cc remove analytics treatment in creation and add some logs 2017-09-28 06:20:29 -04:00
Omer Levy 705c03a4f1 [ios] support dynamic links recieve cont. 2017-09-26 09:54:21 -04:00
Omer Levy 748e3fb53d [ios] support dynamic links recieve 2017-09-25 10:34:26 -04:00
Omer Levy 012f8b79b1 [ios] Add long and short links creation 2017-09-04 09:01:00 -04:00