status-im
/
react-native-firebase
mirror of
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[database][js] ref.isEqual() now correctly compares query modifiers

This commit is contained in:
Salakar 2017-08-14 13:51:52 +01:00
parent 590cb58d49
commit f90db16019
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/modules/database/reference.js
View File

@ -428,7 +428,6 @@ export default class Reference extends ReferenceBase {
return this.path; return this.path;
} }
// TODO should check query modifiers and if same app instance
/** /**
* Returns whether another Reference represent the same location and are from the * Returns whether another Reference represent the same location and are from the
* same instance of firebase.app.App - multiple firebase apps not currently supported. * same instance of firebase.app.App - multiple firebase apps not currently supported.
@ -438,7 +437,10 @@ export default class Reference extends ReferenceBase {
* {@link https://firebase.google.com/docs/reference/js/firebase.database.Reference#isEqual} * {@link https://firebase.google.com/docs/reference/js/firebase.database.Reference#isEqual}
*/ */
isEqual(otherRef: Reference): boolean { isEqual(otherRef: Reference): boolean {
return !!otherRef && otherRef.constructor === Reference && otherRef.key === this.key; return !!otherRef
&& otherRef.constructor === Reference
&& otherRef.key === this.key
&& this._query.queryIdentifier() === otherRef._query.queryIdentifier();
} }
/** /**