From d41c42e2888f8e0d0525d97f1d02a6cb9dffe9b6 Mon Sep 17 00:00:00 2001
From: Chris Bianca <me@chrisbianca.com>
Date: Tue, 28 Nov 2017 14:19:49 +0000
Subject: [PATCH] [analytics] Update to match flow typings and documentation

---
 .flowconfig                    |  3 +++
 lib/modules/analytics/index.js | 18 ++++++++++--------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/.flowconfig b/.flowconfig
index c297a19a..b8353a70 100644
--- a/.flowconfig
+++ b/.flowconfig
@@ -76,6 +76,9 @@
 # Ignore dist folder
 .*/dist/.*
 
+# Ignore tests project
+.*/tests/.*
+
 [include]
 node_modules/fbjs/lib
 
diff --git a/lib/modules/analytics/index.js b/lib/modules/analytics/index.js
index a66927eb..cc842340 100644
--- a/lib/modules/analytics/index.js
+++ b/lib/modules/analytics/index.js
@@ -4,6 +4,8 @@
  */
 import ModuleBase from './../../utils/ModuleBase';
 
+import type FirebaseApp from '../core/firebase-app';
+
 const AlphaNumericUnderscore = /^[a-zA-Z0-9_]+$/;
 
 const ReservedEventNames = [
@@ -26,7 +28,7 @@ export default class Analytics extends ModuleBase {
   static _NAMESPACE = 'analytics';
   static _NATIVE_MODULE = 'RNFirebaseAnalytics';
 
-  constructor(firebaseApp: Object, options: Object = {}) {
+  constructor(firebaseApp: FirebaseApp, options: Object = {}) {
     super(firebaseApp, options);
   }
 
@@ -55,7 +57,7 @@ export default class Analytics extends ModuleBase {
     // types are supported. String parameter values can be up to 36 characters long. The "firebase_"
     // prefix is reserved and should not be used for parameter names.
 
-    return this._native.logEvent(name, params);
+    this._native.logEvent(name, params);
   }
 
   /**
@@ -63,7 +65,7 @@ export default class Analytics extends ModuleBase {
    * @param enabled
    */
   setAnalyticsCollectionEnabled(enabled: boolean): void {
-    return this._native.setAnalyticsCollectionEnabled(enabled);
+    this._native.setAnalyticsCollectionEnabled(enabled);
   }
 
   /**
@@ -72,7 +74,7 @@ export default class Analytics extends ModuleBase {
    * @param screenClassOverride
    */
   setCurrentScreen(screenName: string, screenClassOverride: string): void {
-    return this._native.setCurrentScreen(screenName, screenClassOverride);
+    this._native.setCurrentScreen(screenName, screenClassOverride);
   }
 
   /**
@@ -80,7 +82,7 @@ export default class Analytics extends ModuleBase {
    * @param milliseconds
    */
   setMinimumSessionDuration(milliseconds: number = 10000): void {
-    return this._native.setMinimumSessionDuration(milliseconds);
+    this._native.setMinimumSessionDuration(milliseconds);
   }
 
   /**
@@ -88,7 +90,7 @@ export default class Analytics extends ModuleBase {
    * @param milliseconds
    */
   setSessionTimeoutDuration(milliseconds: number = 1800000): void {
-    return this._native.setSessionTimeoutDuration(milliseconds);
+    this._native.setSessionTimeoutDuration(milliseconds);
   }
 
   /**
@@ -96,7 +98,7 @@ export default class Analytics extends ModuleBase {
    * @param id
    */
   setUserId(id: string): void {
-    return this._native.setUserId(id);
+    this._native.setUserId(id);
   }
 
   /**
@@ -105,7 +107,7 @@ export default class Analytics extends ModuleBase {
    * @param value
    */
   setUserProperty(name: string, value: string): void {
-    return this._native.setUserProperty(name, value);
+    this._native.setUserProperty(name, value);
   }
 
   /**