From 9c4deb541af650c09fcda33a8cad223940cc5c0d Mon Sep 17 00:00:00 2001 From: Taxidermic Date: Wed, 4 Apr 2018 14:05:32 +0300 Subject: [PATCH 1/2] fixes races bug in react-native > 0.52 --- ios/RNFirebase/analytics/RNFirebaseAnalytics.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m index 4c412924..c7751850 100644 --- a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m +++ b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m @@ -5,6 +5,7 @@ #import @implementation RNFirebaseAnalytics +@synthesize methodQueue = _methodQueue; RCT_EXPORT_MODULE(); RCT_EXPORT_METHOD(logEvent:(NSString *)name props:(NSDictionary *)props) { @@ -16,7 +17,7 @@ RCT_EXPORT_METHOD(setAnalyticsCollectionEnabled:(BOOL) enabled) { } RCT_EXPORT_METHOD(setCurrentScreen:(NSString *) screenName screenClass:(NSString *) screenClassOverriew) { - dispatch_async(dispatch_get_main_queue(), ^{ + dispatch_sync(dispatch_get_main_queue(), ^{ [FIRAnalytics setScreenName:screenName screenClass:screenClassOverriew]; }); } From 21dc57c70bf215b85695c15e7dd3e9db2eddbb30 Mon Sep 17 00:00:00 2001 From: Taxidermic Date: Fri, 6 Apr 2018 14:57:05 +0300 Subject: [PATCH 2/2] remove @synthesize --- ios/RNFirebase/analytics/RNFirebaseAnalytics.m | 1 - 1 file changed, 1 deletion(-) diff --git a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m index c7751850..2347bc16 100644 --- a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m +++ b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m @@ -5,7 +5,6 @@ #import @implementation RNFirebaseAnalytics -@synthesize methodQueue = _methodQueue; RCT_EXPORT_MODULE(); RCT_EXPORT_METHOD(logEvent:(NSString *)name props:(NSDictionary *)props) {