From bb26cb4e2cc55096ecbd3aeb218033d9461b3b93 Mon Sep 17 00:00:00 2001 From: Chris Bianca Date: Wed, 26 Apr 2017 17:27:36 +0100 Subject: [PATCH] [android] More tidy up around multiple listeners --- .../database/RNFirebaseDatabaseReference.java | 26 +++++-------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabaseReference.java b/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabaseReference.java index 725ffae4..4eaa48a0 100644 --- a/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabaseReference.java +++ b/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabaseReference.java @@ -153,30 +153,16 @@ public class RNFirebaseDatabaseReference { } private void removeChildEventListener(Integer listenerId) { - if (listenerId != null) { - ChildEventListener listener = mChildEventListeners.remove(listenerId); - if (listener != null) { - mQuery.removeEventListener(listener); - } - } else { - for (ChildEventListener listener : mChildEventListeners.values()) { - mQuery.removeEventListener(listener); - } - mChildEventListeners = new HashMap<>(); + ChildEventListener listener = mChildEventListeners.remove(listenerId); + if (listener != null) { + mQuery.removeEventListener(listener); } } private void removeValueEventListener(Integer listenerId) { - if (listenerId != null) { - ValueEventListener listener = mValueEventListeners.remove(listenerId); - if (listener != null) { - mQuery.removeEventListener(listener); - } - } else { - for (ValueEventListener listener : mValueEventListeners.values()) { - mQuery.removeEventListener(listener); - } - mValueEventListeners = new HashMap<>(); + ValueEventListener listener = mValueEventListeners.remove(listenerId); + if (listener != null) { + mQuery.removeEventListener(listener); } }