From f2f5ea367156c574752f77f1ac3403168b643742 Mon Sep 17 00:00:00 2001 From: Jobeso Date: Fri, 4 Aug 2017 10:48:21 +0200 Subject: [PATCH 1/4] crash fix to get the library working we need to take these versions otherwise the app would crash --- docs/installation-android.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/installation-android.md b/docs/installation-android.md index 7a7cd259..a82593eb 100644 --- a/docs/installation-android.md +++ b/docs/installation-android.md @@ -42,21 +42,21 @@ dependencies { compile(project(':react-native-firebase')) { transitive = false } - compile "com.google.firebase:firebase-core:11.0.0" + compile "com.google.firebase:firebase-core:11.0.4" // If you are receiving Google Play API availability issues, add the following dependency - compile "com.google.android.gms:play-services-base:11.0.0" + compile "com.google.android.gms:play-services-base:11.0.4" // RNFirebase optional dependencies - compile "com.google.firebase:firebase-ads:11.0.0" - compile "com.google.firebase:firebase-analytics:11.0.0" - compile "com.google.firebase:firebase-auth:11.0.0" - compile "com.google.firebase:firebase-config:11.0.0" - compile "com.google.firebase:firebase-crash:11.0.0" - compile "com.google.firebase:firebase-database:11.0.0" - compile "com.google.firebase:firebase-messaging:11.0.0" - compile "com.google.firebase:firebase-perf:11.0.0" - compile "com.google.firebase:firebase-storage:11.0.0" + compile "com.google.firebase:firebase-ads:11.0.4" + compile "com.google.firebase:firebase-analytics:11.0.4" + compile "com.google.firebase:firebase-auth:11.0.4" + compile "com.google.firebase:firebase-config:11.0.4" + compile "com.google.firebase:firebase-crash:11.0.4" + compile "com.google.firebase:firebase-database:11.0.4" + compile "com.google.firebase:firebase-messaging:11.0.4" + compile "com.google.firebase:firebase-perf:11.0.4" + compile "com.google.firebase:firebase-storage:11.0.4" } ``` From cff610aa3b0d5deb17721d2a9689f4312272540d Mon Sep 17 00:00:00 2001 From: Eric Irish Date: Mon, 7 Aug 2017 16:32:03 -0500 Subject: [PATCH 2/4] Fix typo in readme.md add a 't' to analy't'ics --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2cfa1e02..0eaecab6 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ Although the [Firebase Web SDK](https://www.npmjs.com/package/firebase) library RNFirebase provides a JavaScript bridge to the native Firebase SDKs for both iOS and Android therefore Firebase will run on the native thread, allowing the rest of your app to run on the [JS thread](https://facebook.github.io/react-native/docs/performance.html#javascript-frame-rate). The Firebase Web SDK also runs on the JS thread, therefore potentially affecting the frame rate causing jank with animations, touch events etc. -The native SDKs also allow us to hook into device sdk's which are not possible with the web SDK, for example crash reporting, offline realtime database support, analyics and more! +The native SDKs also allow us to hook into device sdk's which are not possible with the web SDK, for example crash reporting, offline realtime database support, analytics and more! All in all, RNFirebase provides much faster performance (~2x) over the web SDK and provides device sdk's not found in the web sdk (see the feature table below). From f36b7e9942c70d1ca9100251128ccaff227d42ca Mon Sep 17 00:00:00 2001 From: connected-space Date: Tue, 8 Aug 2017 12:31:14 +0100 Subject: [PATCH 3/4] Update installation-android.md --- docs/installation-android.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/installation-android.md b/docs/installation-android.md index a82593eb..de2f1e08 100644 --- a/docs/installation-android.md +++ b/docs/installation-android.md @@ -75,7 +75,7 @@ import io.invertase.firebase.config.RNFirebaseRemoteConfigPackage; // Firebase R import io.invertase.firebase.crash.RNFirebaseCrashPackage; // Firebase Crash Reporting import io.invertase.firebase.database.RNFirebaseDatabasePackage; // Firebase Realtime Database import io.invertase.firebase.messaging.RNFirebaseMessagingPackage; // Firebase Cloud Messaging -import io.invertase.firebase.perf.RNFirebasePerformancePackage; // Firebase Messaging +import io.invertase.firebase.perf.RNFirebasePerformancePackage; // Firebase Performance import io.invertase.firebase.storage.RNFirebaseStoragePackage; // Firebase Storage // ... public class MainApplication extends Application implements ReactApplication { From e17b4a99d76d58e93538a0c5b9c4f54f2301bbb5 Mon Sep 17 00:00:00 2001 From: connected-space Date: Tue, 8 Aug 2017 12:36:30 +0100 Subject: [PATCH 4/4] Update installation-android.md --- docs/installation-android.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/installation-android.md b/docs/installation-android.md index a82593eb..57052d37 100644 --- a/docs/installation-android.md +++ b/docs/installation-android.md @@ -156,7 +156,7 @@ If you would like to schedule local notifications then you also need to add the ## 4) Performance Monitoring (optional) -If you'd like to take advantage of Firebases [Performance Monitoring](https://firebase.google.com/docs/perf-mon/), the following additions +If you'd like to take advantage of Firebase's [Performance Monitoring](https://firebase.google.com/docs/perf-mon/), the following additions to your project setup are required: In your projects `android/build.gradle` file, add the plugin to your dependencies: