From 9e549d60b104f30d11a247d2a39b5905c5497bdb Mon Sep 17 00:00:00 2001 From: Chris Bianca Date: Sun, 17 Jun 2018 16:35:02 +0100 Subject: [PATCH] [firestore][typings] Add better type for DocumentChange.type #1180 --- lib/index.d.ts | 4 ++-- lib/modules/firestore/DocumentChange.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/index.d.ts b/lib/index.d.ts index 55723937..6767815d 100644 --- a/lib/index.d.ts +++ b/lib/index.d.ts @@ -807,7 +807,7 @@ declare module 'react-native-firebase' { event: string, observer: (snapshot: PhoneAuthSnapshot) => void, errorCb?: (error: PhoneAuthError) => void, - successCb?: (snapshot: PhoneAuthSnapshot) => void + successCb?: (snapshot: PhoneAuthSnapshot) => void ): PhoneAuthListener; then(fn: (snapshot: PhoneAuthSnapshot) => void): Promise; @@ -1808,7 +1808,7 @@ declare module 'react-native-firebase' { readonly doc: DocumentSnapshot; readonly newIndex: number; readonly oldIndex: number; - readonly type: string; + readonly type: 'added' | 'modified' | 'removed'; } interface DocumentReference { diff --git a/lib/modules/firestore/DocumentChange.js b/lib/modules/firestore/DocumentChange.js index 6adf9577..e0321cb1 100644 --- a/lib/modules/firestore/DocumentChange.js +++ b/lib/modules/firestore/DocumentChange.js @@ -14,7 +14,7 @@ export default class DocumentChange { _document: DocumentSnapshot; _newIndex: number; _oldIndex: number; - _type: string; + _type: 'added' | 'modified' | 'removed'; constructor(firestore: Firestore, nativeData: NativeDocumentChange) { this._document = new DocumentSnapshot(firestore, nativeData.document);