From c0b546be0eecdcb7beda1bacc30e6d0d9fdc9748 Mon Sep 17 00:00:00 2001 From: Charles Crete Date: Wed, 21 Jun 2017 11:21:00 -0400 Subject: [PATCH 1/4] Update Storage doc with basic metadata example --- docs/modules/storage.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/modules/storage.md b/docs/modules/storage.md index 6ea5922c..757008af 100644 --- a/docs/modules/storage.md +++ b/docs/modules/storage.md @@ -19,6 +19,18 @@ firebase.storage() }); ``` + +### With metadata + +```javascript +const metadata = { + contentType: 'image/jpeg' +} +firebase.storage() + .ref('/files/1234') + .putFile('/path/to/file/1234', metadata) +``` + ### Listen to upload state ```javascript From 29e16d40d11059a0149d9dcaf7c8a3f56b802755 Mon Sep 17 00:00:00 2001 From: Elliot Hesp Date: Wed, 21 Jun 2017 18:38:50 +0100 Subject: [PATCH 2/4] Update migration-guide.md --- docs/migration-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migration-guide.md b/docs/migration-guide.md index 9a52da5c..d994e7b8 100644 --- a/docs/migration-guide.md +++ b/docs/migration-guide.md @@ -108,7 +108,7 @@ Add the packages to the `getPackages()` method as required: ##### 6) iOS - Update podfile: - +First, delete your `Podfile.lock` file, and re-run `pod install`. As all firebase modules are now optional you only need to import the Firebase functionality that you require in your application. Simply update your Podfile to only include the Firebase modules for functionality that you require in your app. From e0efc84dab62b06640a78b62344d305f101c909d Mon Sep 17 00:00:00 2001 From: Michael Diarmid Date: Wed, 21 Jun 2017 19:14:05 +0100 Subject: [PATCH 3/4] Update migration-guide.md --- docs/migration-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migration-guide.md b/docs/migration-guide.md index d994e7b8..f641903b 100644 --- a/docs/migration-guide.md +++ b/docs/migration-guide.md @@ -108,7 +108,7 @@ Add the packages to the `getPackages()` method as required: ##### 6) iOS - Update podfile: -First, delete your `Podfile.lock` file, and re-run `pod install`. +First, delete your `Podfile.lock` file, and after making any changes from the below re-run `pod install` in your ios directory. As all firebase modules are now optional you only need to import the Firebase functionality that you require in your application. Simply update your Podfile to only include the Firebase modules for functionality that you require in your app. From a9c7f9c68067b4c53fd0ae034ca3c4360ddbf18f Mon Sep 17 00:00:00 2001 From: Dino Scheidt Date: Wed, 21 Jun 2017 22:39:24 +0200 Subject: [PATCH 4/4] Correct Doc: Comments from # to // for build.gradle --- docs/installation-android.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/installation-android.md b/docs/installation-android.md index afab665b..274f5284 100644 --- a/docs/installation-android.md +++ b/docs/installation-android.md @@ -73,13 +73,13 @@ You'll also need to include RNFirebase and the required Firebase dependencies in ``` dependencies { - # RNFirebase Required dependencies + // RNFirebase Required dependencies compile(project(':react-native-firebase')) { transitive = false } compile "com.google.firebase:firebase-core:11.0.0" - # RNFirebase optional dependencies + // RNFirebase optional dependencies compile "com.google.firebase:firebase-ads:11.0.0" compile "com.google.firebase:firebase-analytics:11.0.0" compile "com.google.firebase:firebase-auth:11.0.0"