From 93805062f727f1ab6211cef7e34e74b74362ed46 Mon Sep 17 00:00:00 2001
From: Chris Bianca <me@chrisbianca.com>
Date: Mon, 5 Feb 2018 17:45:08 +0000
Subject: [PATCH] [fcm] iOS 8/9 grant permission feedback

---
 .../messaging/RNFirebaseMessaging.h           |  5 ++
 .../messaging/RNFirebaseMessaging.m           | 60 +++++++++++++++----
 2 files changed, 53 insertions(+), 12 deletions(-)

diff --git a/ios/RNFirebase/messaging/RNFirebaseMessaging.h b/ios/RNFirebase/messaging/RNFirebaseMessaging.h
index 2bf10470..ea6ed75f 100644
--- a/ios/RNFirebase/messaging/RNFirebaseMessaging.h
+++ b/ios/RNFirebase/messaging/RNFirebaseMessaging.h
@@ -11,9 +11,13 @@
 
 + (_Nonnull instancetype)instance;
 
+@property _Nullable RCTPromiseRejectBlock permissionRejecter;
+@property _Nullable RCTPromiseResolveBlock permissionResolver;
+
 #if !TARGET_OS_TV
 - (void)didReceiveRemoteNotification:(nonnull NSDictionary *)userInfo;
 - (void)didReceiveRemoteNotification:(nonnull NSDictionary *)userInfo fetchCompletionHandler:(void (^_Nonnull)(UIBackgroundFetchResult))completionHandler;
+- (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;
 #endif
 
 @end
@@ -24,3 +28,4 @@
 #endif
 
 #endif
+
diff --git a/ios/RNFirebase/messaging/RNFirebaseMessaging.m b/ios/RNFirebase/messaging/RNFirebaseMessaging.m
index 6b9ebde3..43280ec4 100644
--- a/ios/RNFirebase/messaging/RNFirebaseMessaging.m
+++ b/ios/RNFirebase/messaging/RNFirebaseMessaging.m
@@ -55,7 +55,10 @@ RCT_EXPORT_MODULE()
     theRNFirebaseMessaging = self;
 }
 
-// ** AppDelegate methods **
+// *******************************************************
+// ** Start AppDelegate methods
+// ** iOS 8/9 Only
+// *******************************************************
 
 // Listen for background messages
 - (void)didReceiveRemoteNotification:(nonnull NSDictionary *)userInfo {
@@ -76,7 +79,29 @@ RCT_EXPORT_MODULE()
     // TODO: FetchCompletionHandler?
 }
 
-// ** UNUserNotificationCenterDelegate methods **
+// Listen for permission response
+- (void) didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings {
+    if (notificationSettings.types == UIUserNotificationTypeNone) {
+        if (_permissionRejecter) {
+            _permissionRejecter(@"messaging/permission_error", @"Failed to grant permission", nil);
+        }
+    } else if (_permissionResolver) {
+        _permissionResolver(nil);
+    }
+    _permissionRejecter = nil;
+    _permissionResolver = nil;
+}
+
+// *******************************************************
+// ** Finish AppDelegate methods
+// *******************************************************
+
+
+// *******************************************************
+// ** Start UNUserNotificationCenterDelegate methods
+// ** iOS 10+
+// *******************************************************
+
 #if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0
 // Handle incoming notification messages while app is in the foreground.
 - (void)userNotificationCenter:(UNUserNotificationCenter *)center
@@ -107,8 +132,16 @@ didReceiveNotificationResponse:(UNNotificationResponse *)response
 }
 
 #endif
+    
+// *******************************************************
+// ** Finish UNUserNotificationCenterDelegate methods
+// *******************************************************
 
-// ** FIRMessagingDelegate methods **
+
+// *******************************************************
+// ** Start FIRMessagingDelegate methods
+// ** iOS 8+
+// *******************************************************
 
 // Listen for FCM tokens
 - (void)messaging:(FIRMessaging *)messaging didReceiveRegistrationToken:(NSString *)fcmToken {
@@ -122,6 +155,10 @@ didReceiveNotificationResponse:(UNNotificationResponse *)response
     
     [RNFirebaseUtil sendJSEvent:self name:MESSAGING_MESSAGE_RECEIVED body:message];
 }
+    
+// *******************************************************
+// ** Finish FIRMessagingDelegate methods
+// *******************************************************
 
 // ** Start React Module methods **
 RCT_EXPORT_METHOD(getToken:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
@@ -130,26 +167,26 @@ RCT_EXPORT_METHOD(getToken:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseR
 
 RCT_EXPORT_METHOD(requestPermission:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
     if (RCTRunningInAppExtension()) {
-        reject(@"request_permission_unavailable", @"requestPermission is not supported in App Extensions", nil);
+        reject(@"messaging/request-permission-unavailable", @"requestPermission is not supported in App Extensions", nil);
         return;
     }
     
     if (floor(NSFoundationVersionNumber) <= NSFoundationVersionNumber_iOS_9_x_Max) {
         UIUserNotificationType types = (UIUserNotificationTypeSound | UIUserNotificationTypeAlert | UIUserNotificationTypeBadge);
         [RCTSharedApplication() registerUserNotificationSettings:[UIUserNotificationSettings settingsForTypes:types categories:nil]];
-        // Unfortunately on iOS 9 or below, there's no way to tell whether the user accepted or
-        // rejected the permissions popup
-        // TODO: Is there something we can listen for?
-        resolve(@{@"status":@"unknown"});
+        // We set the promise for usage by the AppDelegate callback which listens
+        // for the result of the permission request
+        _permissionRejecter = reject;
+        _permissionResolver = resolve;
     } else {
         #if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0
             // For iOS 10 display notification (sent via APNS)
             UNAuthorizationOptions authOptions = UNAuthorizationOptionAlert | UNAuthorizationOptionSound | UNAuthorizationOptionBadge;
             [[UNUserNotificationCenter currentNotificationCenter] requestAuthorizationWithOptions:authOptions completionHandler:^(BOOL granted, NSError * _Nullable error) {
                 if (granted) {
-                    resolve(@{@"status": @"granted"});
+                    resolve(nil);
                 } else {
-                    reject(@"permission_error", @"Failed to grant permission", error);
+                    reject(@"messaging/permission_error", @"Failed to grant permission", error);
                 }
             }];
         #endif
@@ -175,7 +212,7 @@ RCT_EXPORT_METHOD(getInitialMessage:(RCTPromiseResolveBlock)resolve rejecter:(RC
         resolve(nil);
     }
 }
-
+    
 RCT_EXPORT_METHOD(sendMessage: (NSDictionary *) message
                       resolve:(RCTPromiseResolveBlock) resolve
                        reject:(RCTPromiseRejectBlock) reject) {
@@ -350,4 +387,3 @@ RCT_EXPORT_METHOD(unsubscribeFromTopic: (NSString*) topic) {
 @implementation RNFirebaseMessaging
 @end
 #endif
-