From 9c4deb541af650c09fcda33a8cad223940cc5c0d Mon Sep 17 00:00:00 2001 From: Taxidermic Date: Wed, 4 Apr 2018 14:05:32 +0300 Subject: [PATCH 1/4] fixes races bug in react-native > 0.52 --- ios/RNFirebase/analytics/RNFirebaseAnalytics.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m index 4c412924..c7751850 100644 --- a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m +++ b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m @@ -5,6 +5,7 @@ #import @implementation RNFirebaseAnalytics +@synthesize methodQueue = _methodQueue; RCT_EXPORT_MODULE(); RCT_EXPORT_METHOD(logEvent:(NSString *)name props:(NSDictionary *)props) { @@ -16,7 +17,7 @@ RCT_EXPORT_METHOD(setAnalyticsCollectionEnabled:(BOOL) enabled) { } RCT_EXPORT_METHOD(setCurrentScreen:(NSString *) screenName screenClass:(NSString *) screenClassOverriew) { - dispatch_async(dispatch_get_main_queue(), ^{ + dispatch_sync(dispatch_get_main_queue(), ^{ [FIRAnalytics setScreenName:screenName screenClass:screenClassOverriew]; }); } From 306e02ace0d392d41bf44f1bb247d9b31ae69cf2 Mon Sep 17 00:00:00 2001 From: Michael Diarmid Date: Thu, 5 Apr 2018 05:20:39 +0100 Subject: [PATCH 2/4] Update README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 7e89d961..ba6f6580 100644 --- a/README.md +++ b/README.md @@ -49,6 +49,7 @@ All in all, RNFirebase provides much faster performance (~2x) over the web SDK a | **Crashlytics**           | ❌ | ✅ | ✅ | ❌ | | **Crash Reporting** | ✅ | ✅ | ✅ | ❌ | | **Dynamic Links** | ❌ | ✅ | ✅ | ❌ | +| **[Functions Callable](https://firebase.googleblog.com/2018/04/launching-cloud-functions-for-firebase-1-0.html?m=1)** | ❌ | ❌ | [v4.1+](https://github.com/invertase/react-native-firebase/milestone/6) | ✅ | | **Invites** | ❌ | ❌ | ✅ | ❌ | | **Instance ID**          | ❌ | ❌ | **?** | ❌ | | **Performance Monitoring** | ✅ | ✅ | ✅ | ❌ | From ee130cb45d08d1fa2a173445b50583d5fed5eb1d Mon Sep 17 00:00:00 2001 From: Chris Bianca Date: Thu, 5 Apr 2018 17:36:01 +0100 Subject: [PATCH 3/4] 4.0.0 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index f0e2b7de..06fa8243 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "react-native-firebase", - "version": "4.0.0-rc.3", + "version": "4.0.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 87187ad3..e6cd06f7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-firebase", - "version": "4.0.0-rc.3", + "version": "4.0.0", "author": "Invertase (http://invertase.io)", "description": "A well tested, feature rich Firebase implementation for React Native, supporting iOS & Android. Individual module support for Admob, Analytics, Auth, Crash Reporting, Cloud Firestore, Database, Dynamic Links, Messaging (FCM), Remote Config, Storage and Performance.", "main": "dist/index.js", From 21dc57c70bf215b85695c15e7dd3e9db2eddbb30 Mon Sep 17 00:00:00 2001 From: Taxidermic Date: Fri, 6 Apr 2018 14:57:05 +0300 Subject: [PATCH 4/4] remove @synthesize --- ios/RNFirebase/analytics/RNFirebaseAnalytics.m | 1 - 1 file changed, 1 deletion(-) diff --git a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m index c7751850..2347bc16 100644 --- a/ios/RNFirebase/analytics/RNFirebaseAnalytics.m +++ b/ios/RNFirebase/analytics/RNFirebaseAnalytics.m @@ -5,7 +5,6 @@ #import @implementation RNFirebaseAnalytics -@synthesize methodQueue = _methodQueue; RCT_EXPORT_MODULE(); RCT_EXPORT_METHOD(logEvent:(NSString *)name props:(NSDictionary *)props) {