From 3ac88d7a6a3fa8ad661c42bca797b04083d9a1c7 Mon Sep 17 00:00:00 2001 From: Salakar Date: Wed, 4 Oct 2017 19:54:50 +0100 Subject: [PATCH] Revert "Revert "[android] Remove backwards compatibility for 0.47.0"" This reverts commit 25314483d740f90742d642b61bd015aa3456604c. --- .../io/invertase/firebase/RNFirebasePackage.java | 12 ------------ .../firebase/admob/RNFirebaseAdMobPackage.java | 12 ------------ .../analytics/RNFirebaseAnalyticsPackage.java | 12 ------------ .../firebase/auth/RNFirebaseAuthPackage.java | 12 ------------ .../config/RNFirebaseRemoteConfigPackage.java | 12 ------------ .../firebase/crash/RNFirebaseCrashPackage.java | 12 ------------ .../firebase/database/RNFirebaseDatabasePackage.java | 12 ------------ .../firestore/RNFirebaseFirestorePackage.java | 12 ------------ .../messaging/RNFirebaseMessagingPackage.java | 12 ------------ .../firebase/perf/RNFirebasePerformancePackage.java | 12 ------------ .../firebase/storage/RNFirebaseStoragePackage.java | 12 ------------ 11 files changed, 132 deletions(-) diff --git a/android/src/main/java/io/invertase/firebase/RNFirebasePackage.java b/android/src/main/java/io/invertase/firebase/RNFirebasePackage.java index b960b9c6..8bf7fcbd 100644 --- a/android/src/main/java/io/invertase/firebase/RNFirebasePackage.java +++ b/android/src/main/java/io/invertase/firebase/RNFirebasePackage.java @@ -31,18 +31,6 @@ public class RNFirebasePackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/admob/RNFirebaseAdMobPackage.java b/android/src/main/java/io/invertase/firebase/admob/RNFirebaseAdMobPackage.java index 6715affc..2bfb6109 100644 --- a/android/src/main/java/io/invertase/firebase/admob/RNFirebaseAdMobPackage.java +++ b/android/src/main/java/io/invertase/firebase/admob/RNFirebaseAdMobPackage.java @@ -29,18 +29,6 @@ public class RNFirebaseAdMobPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/analytics/RNFirebaseAnalyticsPackage.java b/android/src/main/java/io/invertase/firebase/analytics/RNFirebaseAnalyticsPackage.java index 15fe7c9e..b21a3082 100644 --- a/android/src/main/java/io/invertase/firebase/analytics/RNFirebaseAnalyticsPackage.java +++ b/android/src/main/java/io/invertase/firebase/analytics/RNFirebaseAnalyticsPackage.java @@ -33,18 +33,6 @@ public class RNFirebaseAnalyticsPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/auth/RNFirebaseAuthPackage.java b/android/src/main/java/io/invertase/firebase/auth/RNFirebaseAuthPackage.java index 0fa905dc..909b9312 100644 --- a/android/src/main/java/io/invertase/firebase/auth/RNFirebaseAuthPackage.java +++ b/android/src/main/java/io/invertase/firebase/auth/RNFirebaseAuthPackage.java @@ -28,18 +28,6 @@ public class RNFirebaseAuthPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfigPackage.java b/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfigPackage.java index e794313c..dce06b80 100644 --- a/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfigPackage.java +++ b/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfigPackage.java @@ -28,18 +28,6 @@ public class RNFirebaseRemoteConfigPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/crash/RNFirebaseCrashPackage.java b/android/src/main/java/io/invertase/firebase/crash/RNFirebaseCrashPackage.java index 8eeb6174..4ab83e78 100644 --- a/android/src/main/java/io/invertase/firebase/crash/RNFirebaseCrashPackage.java +++ b/android/src/main/java/io/invertase/firebase/crash/RNFirebaseCrashPackage.java @@ -28,18 +28,6 @@ public class RNFirebaseCrashPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabasePackage.java b/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabasePackage.java index 7045aa53..c4e9808d 100644 --- a/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabasePackage.java +++ b/android/src/main/java/io/invertase/firebase/database/RNFirebaseDatabasePackage.java @@ -28,18 +28,6 @@ public class RNFirebaseDatabasePackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/firestore/RNFirebaseFirestorePackage.java b/android/src/main/java/io/invertase/firebase/firestore/RNFirebaseFirestorePackage.java index 528922ac..f971daea 100644 --- a/android/src/main/java/io/invertase/firebase/firestore/RNFirebaseFirestorePackage.java +++ b/android/src/main/java/io/invertase/firebase/firestore/RNFirebaseFirestorePackage.java @@ -28,18 +28,6 @@ public class RNFirebaseFirestorePackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessagingPackage.java b/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessagingPackage.java index 70ac5c94..1a88b657 100644 --- a/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessagingPackage.java +++ b/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessagingPackage.java @@ -28,18 +28,6 @@ public class RNFirebaseMessagingPackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/perf/RNFirebasePerformancePackage.java b/android/src/main/java/io/invertase/firebase/perf/RNFirebasePerformancePackage.java index 04e52835..2ef2314b 100644 --- a/android/src/main/java/io/invertase/firebase/perf/RNFirebasePerformancePackage.java +++ b/android/src/main/java/io/invertase/firebase/perf/RNFirebasePerformancePackage.java @@ -28,18 +28,6 @@ public class RNFirebasePerformancePackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatability - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule} diff --git a/android/src/main/java/io/invertase/firebase/storage/RNFirebaseStoragePackage.java b/android/src/main/java/io/invertase/firebase/storage/RNFirebaseStoragePackage.java index 114a1218..a14cc738 100644 --- a/android/src/main/java/io/invertase/firebase/storage/RNFirebaseStoragePackage.java +++ b/android/src/main/java/io/invertase/firebase/storage/RNFirebaseStoragePackage.java @@ -33,18 +33,6 @@ public class RNFirebaseStoragePackage implements ReactPackage { return modules; } - /** - * @return list of JS modules to register with the newly created catalyst instance. - *

- * IMPORTANT: Note that only modules that needs to be accessible from the native code should be - * listed here. Also listing a native module here doesn't imply that the JS implementation of it - * will be automatically included in the JS bundle. - */ - // TODO: Removed in 0.47.0. Here for backwards compatibility - public List> createJSModules() { - return Collections.emptyList(); - } - /** * @param reactContext * @return a list of view managers that should be registered with {@link UIManagerModule}