Merge branch 'v2' of github.com:invertase/react-native-firebase into v2
This commit is contained in:
Elliot Hesp
commit
0e27d7345e
23
README.md
23
README.md
|
|
@ -35,7 +35,28 @@ RNFirebase provides a JavaScript bridge to the native Firebase SDKs for both iOS
|
|||
|
||||
The native SDKs also allow us to hook into device sdk's which are not possible with the web SDK, for example crash reporting, offline realtime database support, analyics and more!
|
||||
|
||||
<hr>
|
||||
---
|
||||
### Supported Firebase Features
|
||||
|
||||
> The Web SDK column indicates what modules from the Firebase Web SDK are usable with React Native.
|
||||
|
||||
| Firebase Features | v1 | [v2](https://github.com/invertase/react-native-firebase/pull/130) | Web SDK |
|
||||
| ---------------------- | :---: | :---: | :---: |
|
||||
| Analytics | ✅ | ✅ | ❌ |
|
||||
| Cloud Messaging | ✅ | ✅ | ❌ |
|
||||
| Authentication | ✅ | ✅ | ✅ |
|
||||
| Realtime Database | ✅ | ✅ | ✅ |
|
||||
| - Offline Persistance | ✅ | ✅ | ❌ |
|
||||
| Storage | ✅ | ✅ | ❌ |
|
||||
| Performance Monitoring | ✅ | ✅ | ❌ |
|
||||
| Crash Reporting | ✅ | ✅ | ❌ |
|
||||
| Remote Config | ✅ | ✅ | ❌ |
|
||||
| App Indexing | ❌ | ❌ | ❌ |
|
||||
| Dynamic Links | ❌ | ❌ | ❌ |
|
||||
| Invites | ❌ | ❌ | ❌ |
|
||||
| AdMob | ❌ | ✅ | ❌ |
|
||||
|
||||
---
|
||||
|
||||
### License
|
||||
|
||||
|
|
|
|||
|
|
@ -213,16 +213,22 @@ public class Utils {
|
|||
}
|
||||
|
||||
/**
|
||||
* Data should be treated as an array if:
|
||||
* 1) All the keys are integers
|
||||
* 2) More than half the keys between 0 and the maximum key in the object have non-empty values
|
||||
*
|
||||
* Definition from: https://firebase.googleblog.com/2014/04/best-practices-arrays-in-firebase.html
|
||||
*
|
||||
* @param snapshot
|
||||
* @return
|
||||
*/
|
||||
private static boolean isArray(DataSnapshot snapshot) {
|
||||
long expectedKey = -1;
|
||||
long maxAllowedKey = (snapshot.getChildrenCount() * 2) - 1;
|
||||
for (DataSnapshot child : snapshot.getChildren()) {
|
||||
try {
|
||||
long key = Long.parseLong(child.getKey());
|
||||
if (key > expectedKey) {
|
||||
if (key > expectedKey && key <= maxAllowedKey) {
|
||||
expectedKey = key;
|
||||
} else {
|
||||
return false;
|
||||
|
|
@ -235,16 +241,22 @@ public class Utils {
|
|||
}
|
||||
|
||||
/**
|
||||
* Data should be treated as an array if:
|
||||
* 1) All the keys are integers
|
||||
* 2) More than half the keys between 0 and the maximum key in the object have non-empty values
|
||||
*
|
||||
* Definition from: https://firebase.googleblog.com/2014/04/best-practices-arrays-in-firebase.html
|
||||
*
|
||||
* @param mutableData
|
||||
* @return
|
||||
*/
|
||||
private static boolean isArray(MutableData mutableData) {
|
||||
long expectedKey = -1;
|
||||
long maxAllowedKey = (mutableData.getChildrenCount() * 2) - 1;
|
||||
for (MutableData child : mutableData.getChildren()) {
|
||||
try {
|
||||
long key = Long.parseLong(child.getKey());
|
||||
if (key > expectedKey) {
|
||||
if (key > expectedKey && key <= maxAllowedKey) {
|
||||
expectedKey++;
|
||||
} else {
|
||||
return false;
|
||||
|
|
|
|||
|
|
@ -1,63 +0,0 @@
|
|||
#!/bin/sh
|
||||
|
||||
ios_dir=`pwd`/ios
|
||||
if [ -d ios_dir ]
|
||||
then
|
||||
exit 0
|
||||
fi
|
||||
|
||||
podfile="$ios_dir/Podfile"
|
||||
template=`pwd`/node_modules/react-native-firebase/ios/Podfile.template
|
||||
|
||||
project_name=$(node -pe "require('./package.json').name")
|
||||
|
||||
echo "Checking Podfile in iOS project $project_name ($podfile)"
|
||||
|
||||
if [ -f $podfile ]
|
||||
then
|
||||
echo ""
|
||||
echo "Found an existing Podfile, Do you want to override it? [N/y]"
|
||||
read generate_env_file
|
||||
|
||||
if [ "$generate_env_file" != "y" ]
|
||||
then
|
||||
echo "Add the following pods":
|
||||
echo ""
|
||||
echo ""
|
||||
cat $template
|
||||
echo ""
|
||||
echo ""
|
||||
echo "and run 'pod install' to install RNFirebase for iOS"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
rm -f $podfile
|
||||
rm -f "$podfile.lock"
|
||||
fi
|
||||
|
||||
echo "Adding Podfile to iOS project"
|
||||
|
||||
touch ios/Podfile
|
||||
cat >ios/Podfile <<EOL
|
||||
target '${project_name}' do
|
||||
# Uncomment the next line if you're using Swift or would like to use dynamic frameworks
|
||||
# use_frameworks!
|
||||
# Pods for '${project_name}'
|
||||
end
|
||||
|
||||
# RNFirebase
|
||||
pod 'Firebase/Auth'
|
||||
pod 'Firebase/Analytics'
|
||||
pod 'Firebase/AppIndexing'
|
||||
pod 'Firebase/Core'
|
||||
pod 'Firebase/Crash'
|
||||
pod 'Firebase/Database'
|
||||
pod 'Firebase/DynamicLinks'
|
||||
pod 'Firebase/Messaging'
|
||||
pod 'Firebase/RemoteConfig'
|
||||
pod 'Firebase/Storage'
|
||||
EOL
|
||||
|
||||
echo "Installing Pods"
|
||||
|
||||
pod install --project-directory=ios
|
||||
|
|
@ -1,15 +0,0 @@
|
|||
#!/bin/sh
|
||||
|
||||
## https://github.com/auth0/react-native-lock/blob/master/bin/prepare.sh
|
||||
|
||||
echo "Preparing to link react-native-firebase for iOS"
|
||||
|
||||
echo "Checking CocoaPods..."
|
||||
has_cocoapods=`which pod >/dev/null 2>&1`
|
||||
if [ -z "$has_cocoapods" ]
|
||||
then
|
||||
echo "CocoaPods already installed"
|
||||
else
|
||||
echo "Installing CocoaPods..."
|
||||
gem install cocoapods
|
||||
fi
|
||||
|
|
@ -24,3 +24,25 @@ Although the [Firebase Web SDK](https://www.npmjs.com/package/firebase) library
|
|||
RNFirebase provides a JavaScript bridge to the native Firebase SDKs for both iOS and Android. Firebase will run on the native thread, allowing the rest of your app to run on the [JS thread](https://facebook.github.io/react-native/docs/performance.html#javascript-frame-rate). The Firebase Web SDK also runs on the JS thread, therefore potentially affecting the frame rate causing jank with animations, touch events etc. All in all, RNFirebase provides much faster performance (~2x) over the web SDK.
|
||||
|
||||
The native SDKs also allow us to hook into device sdk's which are not possible with the web SDK, for example crash reporting, offline realtime database support, analyics and more!
|
||||
|
||||
---
|
||||
|
||||
## Supported Firebase Features
|
||||
> The Web SDK column indicates what modules from the Firebase Web SDK are usable within React Native.
|
||||
|
||||
| Firebase Features | v1 | [v2](https://github.com/invertase/react-native-firebase/pull/130) | Web SDK |
|
||||
| ---------------------- | :---: | :---: | :---: |
|
||||
| Analytics | ✅ | ✅ | ❌ |
|
||||
| Cloud Messaging | ✅ | ✅ | ❌ |
|
||||
| Authentication | ✅ | ✅ | ✅ |
|
||||
| Realtime Database | ✅ | ✅ | ✅ |
|
||||
| - Offline Persistance | ✅ | ✅ | ❌ |
|
||||
| Storage | ✅ | ✅ | ❌ |
|
||||
| Performance Monitoring | ✅ | ✅ | ❌ |
|
||||
| Crash Reporting | ✅ | ✅ | ❌ |
|
||||
| Remote Config | ✅ | ✅ | ❌ |
|
||||
| App Indexing | ❌ | ❌ | ❌ |
|
||||
| Dynamic Links | ❌ | ❌ | ❌ |
|
||||
| Invites | ❌ | ❌ | ❌ |
|
||||
| AdMob | ❌ | ✅ | ❌ |
|
||||
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
- Getting started
|
||||
- [Initial setup](/initial-setup)
|
||||
- [Installation - iOS](/installation-ios)
|
||||
- [Installation - Android](/installation-android)
|
||||
- [Firebase Setup](/firebase-setup.md)
|
||||
- [Usage](/usage)
|
||||
|
||||
- Contributing
|
||||
|
|
|
|||
|
|
@ -1,20 +0,0 @@
|
|||
# Firebase Setup
|
||||
|
||||
The RNFirebase library is intended on making it easy to work with [Firebase](https://firebase.google.com/) and provides a small native shim to the Firebase native code.
|
||||
|
||||
To add Firebase to your project, make sure to create a project in the [Firebase console](https://firebase.google.com/console)
|
||||
|
||||
|
||||
|
||||
Each platform uses a different setup method after creating the project.
|
||||
|
||||
## iOS
|
||||
|
||||
For iOS, ensure you've followed the instructions provided by Firebase; adding your [GoogleService-Info.plist](https://github.com/invertase/react-native-firebase/blob/master/tests/ios/GoogleService-Info.plist)
|
||||
file to the project, and [configuring your AppDelegate](https://github.com/invertase/react-native-firebase/blob/master/tests/ios/ReactNativeFirebaseDemo/AppDelegate.m#L20).
|
||||
|
||||
## Android
|
||||
|
||||
For Android, ensure you've followed the instructions provided by Firebase; adding your [google-services.json](https://github.com/invertase/react-native-firebase/blob/master/tests/android/app/google-services.json)
|
||||
file to the project, installing the [google-services](https://github.com/invertase/react-native-firebase/blob/master/tests/android/build.gradle#L9)
|
||||
plugin and applying **at the end** of your [`build.gradle`](https://github.com/invertase/react-native-firebase/blob/master/tests/android/app/build.gradle#L144).
|
||||
|
|
@ -0,0 +1,21 @@
|
|||
# Install the library
|
||||
|
||||
`npm install --save react-native-firebase`
|
||||
|
||||
# Initial Setup
|
||||
|
||||
The RNFirebase library is intended on making it easy to work with [Firebase](https://firebase.google.com/) and provides a small native shim to the Firebase native code.
|
||||
|
||||
To add Firebase to your project, make sure to create a project in the [Firebase console](https://firebase.google.com/console)
|
||||
|
||||
|
||||
|
||||
Each platform uses a different setup method after creating the project.
|
||||
|
||||
## iOS
|
||||
|
||||
For iOS, follow the instructions [here](/installation-ios).
|
||||
|
||||
## Android
|
||||
|
||||
For Android, follow the instructions [here](/installation-android).
|
||||
|
|
@ -1,90 +1,65 @@
|
|||
# iOS Installation
|
||||
|
||||
## 1) Setup google-services.plist and dependencies
|
||||
Setup the `google-services.plist` file and Firebase ios frameworks first; check out the relevant Firebase docs [here](https://firebase.google.com/docs/ios/setup#frameworks).
|
||||
## 1) Setup GoogleService-Info.plist
|
||||
Setup the `GoogleService-Info.plist` file by following the instructions and adding it to the root of your project at `ios/[YOUR APP NAME]/GoogleService-Info.plist` [here](https://firebase.google.com/docs/ios/setup#add_firebase_to_your_app).
|
||||
|
||||
### 1.1) Initialisation
|
||||
Make sure you've added the following to the top of your `ios/[YOUR APP NAME]]/AppDelegate.m` file:
|
||||
|
||||
`#import <Firebase.h>`
|
||||
|
||||
and this to the `didFinishLaunchingWithOptions:(NSDictionary *)launchOptions` method:
|
||||
and this to the `didFinishLaunchingWithOptions:(NSDictionary *)launchOptions` method before the `return` statement:
|
||||
|
||||
`[FIRApp configure];`
|
||||
|
||||
## 2) Link RNFirebase
|
||||
|
||||
There are multiple ways to install RNFirebase depending on how your project is currently setup:
|
||||
Unfortunately, due to the fact that Firebase is much easier to setup using Cocoapods, `react-native link` is not recommended as it is not customisable enough for our needs and we have had numerous problems reported.
|
||||
|
||||
### 2.1) You already use Cocoapods and have React Native installed as a pod
|
||||
Simply add the following to your `Podfile`:
|
||||
### 2.0) If you don't already have Cocoapods set up
|
||||
Follow the instructions to install Cocoapods and create your Podfile [here](https://firebase.google.com/docs/ios/setup#add_the_sdk).
|
||||
|
||||
```ruby
|
||||
# Required by RNFirebase - you should already have some of these from step 1.
|
||||
pod 'Firebase/Auth'
|
||||
pod 'Firebase/Analytics'
|
||||
pod 'Firebase/AppIndexing'
|
||||
pod 'Firebase/Core'
|
||||
pod 'Firebase/Crash'
|
||||
pod 'Firebase/Database'
|
||||
pod 'Firebase/DynamicLinks'
|
||||
pod 'Firebase/Messaging'
|
||||
pod 'Firebase/RemoteConfig'
|
||||
pod 'Firebase/Storage'
|
||||
pod 'RNFirebase', :path => '../node_modules/react-native-firebase'
|
||||
```
|
||||
**NOTE: The Podfile needs to be initialised in the `ios` directory of your project.**
|
||||
|
||||
### 2.2) You're not using Cocoapods or don't have React Native installed as a pod (Automatic install)
|
||||
#### Troubleshooting
|
||||
1) When running `pod install` you may encounter an error saying that a `tvOSTests` target is declared twice. This appears to be a bug with `pod init` and the way that react native is set up.
|
||||
|
||||
React native ships with a `link` command that can be used to link the projects together, which can help automate the process of linking our package environments.
|
||||
**Resolution:**
|
||||
- Open your Podfile
|
||||
- Remove the duplicate `tvOSTests` target nested within the main project target
|
||||
- Re-run `pod install`.
|
||||
|
||||
```bash
|
||||
react-native link react-native-firebase
|
||||
```
|
||||
2) When running `pod install` you may encounter a number of warnings relating to `target overrides 'OTHER_LDFLAGS'`.
|
||||
|
||||
#### cocoapods
|
||||
**Resolution:**
|
||||
- Open Xcode
|
||||
- Select your project
|
||||
- For each target:
|
||||
-- Select the target
|
||||
-- Click Build settings
|
||||
-- Search for `other linker flags`
|
||||
-- Add `$(inherited)` as the top line if it doesn't already exist
|
||||
- Re-run `pod install`
|
||||
|
||||
We've automated the process of setting up with cocoapods. This will happen automatically upon linking the package with `react-native-cli`.
|
||||
3) When running `pod install` you may encounter a warning that a default iOS platform has been assigned. If you wish to specify a different minimum version:
|
||||
|
||||
Update the newly installed pods once the linking is done:
|
||||
**Resolution**
|
||||
- Open your Podfile
|
||||
- Uncomment the `# platform :ios, '9.0'` line by removing the `#` character
|
||||
- Change the version as required
|
||||
|
||||
```bash
|
||||
cd ios && pod update --verbose
|
||||
```
|
||||
|
||||
**NOTE: You need to use the `ios/[YOUR APP NAME].xcworkspace` instead of the `ios/[YOUR APP NAME].xcproj` file from now on.**
|
||||
|
||||
### 2.3) You're not using Cocoapods or don't have React Native installed as a pod (Manual install)
|
||||
|
||||
If you prefer not to use `react-native link`, we can manually link the package together with the following steps, after `npm install`:
|
||||
|
||||
**A.** In XCode, right click on `Libraries` and find the `Add Files to [project name]`.
|
||||
|
||||
|
||||
**B.** Add the `node_modules/react-native-firebase/ios/Firebase.xcodeproj`
|
||||
|
||||
|
||||
|
||||
**C.** Ensure that the `Build Settings` of the `RNFirebase.xcodeproj` project is ticked to _All_ and it's `Header Search Paths` include both of the following paths _and_ are set to _recursive_:
|
||||
|
||||
1. `$(SRCROOT)/../../react-native/React`
|
||||
2. `$(SRCROOT)/../node_modules/react-native/React`
|
||||
3. `${PROJECT_DIR}/../../../ios/Pods`
|
||||
|
||||
|
||||
|
||||
**D.** Setting up cocoapods
|
||||
|
||||
Since we're dependent upon cocoapods (or at least the Firebase libraries being available at the root project -- i.e. your application), we have to make them available for RNFirebase to find them.
|
||||
|
||||
Using cocoapods is the easiest way to get started with this linking. Add or update a `Podfile` at `ios/Podfile` in your app with the following:
|
||||
### 2.1) Add the required pods
|
||||
Simply add the following to your `Podfile` either at the top level, or within the main project target:
|
||||
|
||||
```ruby
|
||||
# Required by RNFirebase
|
||||
pod 'Firebase/Auth'
|
||||
pod 'Firebase/Analytics'
|
||||
pod 'Firebase/AppIndexing'
|
||||
pod 'Firebase/Core'
|
||||
pod 'RNFirebase', :path => '../node_modules/react-native-firebase'
|
||||
|
||||
# [OPTIONAL PODS] - comment out pods for firebase products you won't be using.
|
||||
pod 'Firebase/AdMob'
|
||||
pod 'Firebase/Analytics'
|
||||
pod 'Firebase/Auth'
|
||||
pod 'Firebase/Crash'
|
||||
pod 'Firebase/Database'
|
||||
pod 'Firebase/DynamicLinks'
|
||||
|
|
@ -93,10 +68,27 @@ pod 'Firebase/RemoteConfig'
|
|||
pod 'Firebase/Storage'
|
||||
```
|
||||
|
||||
Then you can run `(cd ios && pod install)` to get the pods opened.
|
||||
If you are new to Cocoapods or do not already have React installed as a pod, then add Yoga and React to your `Podfile` as follows:
|
||||
|
||||
```ruby
|
||||
pod "Yoga", :path => "../node_modules/react-native/ReactCommon/yoga"
|
||||
pod 'React', :path => '../node_modules/react-native', :subspecs => [
|
||||
'BatchedBridge', # Required For React Native 0.45.0+
|
||||
'Core',
|
||||
# Add any other subspecs you want to use in your project
|
||||
]
|
||||
```
|
||||
|
||||
Run `pod install`.
|
||||
|
||||
**NOTE: You need to use the `ios/[YOUR APP NAME].xcworkspace` instead of the `ios/[YOUR APP NAME].xcproj` file from now on.**
|
||||
|
||||
#### Troubleshooting
|
||||
1) You receive an error `No podspec found for 'RNFirebase'`
|
||||
|
||||
**Resolution**
|
||||
- Run `npm install --save react-native-firebase` from the root of your project
|
||||
|
||||
## 3) Cloud Messaging (optional)
|
||||
|
||||
If you plan on using [Firebase Cloud Messaging](https://firebase.google.com/docs/cloud-messaging/) then, you need to:
|
||||
|
|
@ -146,13 +138,13 @@ Add the following methods:
|
|||
}
|
||||
|
||||
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(nonnull NSDictionary *)userInfo
|
||||
fetchCompletionHandler:(nonnull void (^)(UIBackgroundFetchResult))completionHandler{
|
||||
fetchCompletionHandler:(nonnull void (^)(UIBackgroundFetchResult))completionHandler{
|
||||
[RNFirebaseMessaging didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];
|
||||
}
|
||||
```
|
||||
|
||||
### 3.5) Debugging
|
||||
|
||||
If you're having problems with messages not being received, check out the following blog post for help:
|
||||
|
||||
https://firebase.googleblog.com/2017/01/debugging-firebase-cloud-messaging-on.html
|
||||
```
|
||||
|
|
|
|||
|
|
@ -73,7 +73,7 @@ firebase.analytics().setSessionTimeoutDuration(900000);
|
|||
|
||||
#### `setUserId(id: string): void`
|
||||
|
||||
Gives a user a uniqiue identificaition.
|
||||
Gives a user a unique identification.
|
||||
|
||||
```javascript
|
||||
const id = firebase.auth().currentUser.uid;
|
||||
|
|
|
|||
|
|
@ -279,7 +279,7 @@ Updates a user's profile data. Profile data should be an object of fields to upd
|
|||
```javascript
|
||||
firebase.auth().currentUser
|
||||
.updateProfile({
|
||||
displayName: 'Ari Lerner'
|
||||
displayName: 'Display Name'
|
||||
})
|
||||
.then()
|
||||
.catch();
|
||||
|
|
|
|||
|
|
@ -1,14 +0,0 @@
|
|||
pod 'Firebase/Core'
|
||||
|
||||
# [OPTIONAL PODS] - comment out pods for firebase products you won't be using.
|
||||
pod 'Firebase/Auth'
|
||||
pod 'Firebase/Crash'
|
||||
pod 'Firebase/Storage'
|
||||
pod 'Firebase/Database'
|
||||
pod 'Firebase/Messaging'
|
||||
pod 'Firebase/Analytics'
|
||||
pod 'Firebase/Performance'
|
||||
pod 'Firebase/RemoteConfig'
|
||||
# END [OPTIONAL PODS]
|
||||
|
||||
pod 'RNFirebase', :path => '../node_modules/react-native-firebase'
|
||||
12
package.json
12
package.json
|
|
@ -56,18 +56,6 @@
|
|||
"react": "*",
|
||||
"react-native": ">= 0.40.0"
|
||||
},
|
||||
"rnpm": {
|
||||
"commands": {
|
||||
"prelink": "node_modules/react-native-firebase/bin/prepare.sh",
|
||||
"postlink": "node_modules/react-native-firebase/bin/cocoapods.sh"
|
||||
},
|
||||
"ios": {
|
||||
"project": "ios/RNFirebase.xcodeproj"
|
||||
},
|
||||
"android": {
|
||||
"packageInstance": "new RNFirebasePackage()"
|
||||
}
|
||||
},
|
||||
"devDependencies": {
|
||||
"babel-eslint": "^7.0.0",
|
||||
"babel-jest": "^14.1.0",
|
||||
|
|
|
|||
|
|
@ -26,6 +26,8 @@ instances.web.database().ref('tests/priority').setWithPriority({
|
|||
foo: 'bar',
|
||||
}, 666);
|
||||
|
||||
instances.web.database().ref('tests/query').set(DatabaseContents.QUERY);
|
||||
|
||||
|
||||
// instances.native.messaging().subscribeToTopic('fcm_test');
|
||||
|
||||
|
|
|
|||
|
|
@ -1,10 +1,10 @@
|
|||
import should from 'should';
|
||||
import DatabaseContents from '../../support/DatabaseContents';
|
||||
|
||||
function issueTests({ fdescribe, describe, it, context, firebase }) {
|
||||
function issueTests({ describe, it, context, firebase }) {
|
||||
describe('issue_100', () => {
|
||||
context('array-like values should', () => {
|
||||
it('return null in returned array at positions where a key is missing', async() => {
|
||||
it('return null in returned array at positions where a key is missing', async () => {
|
||||
// Setup
|
||||
|
||||
const ref = firebase.native.database().ref('tests/issues/100');
|
||||
|
|
@ -12,9 +12,6 @@ function issueTests({ fdescribe, describe, it, context, firebase }) {
|
|||
// Test
|
||||
|
||||
return ref.once('value').then((snapshot) => {
|
||||
// Assertion
|
||||
// console.warn(JSON.stringify(snapshot.val()));
|
||||
|
||||
snapshot.val().should.eql([null, DatabaseContents.ISSUES[100][1], DatabaseContents.ISSUES[100][2], DatabaseContents.ISSUES[100][3]]);
|
||||
});
|
||||
});
|
||||
|
|
@ -23,7 +20,7 @@ function issueTests({ fdescribe, describe, it, context, firebase }) {
|
|||
|
||||
describe('issue_108', () => {
|
||||
context('filters using floats', () => {
|
||||
it('return correct results', async() => {
|
||||
it('return correct results', async () => {
|
||||
// Setup
|
||||
|
||||
const ref = firebase.native.database().ref('tests/issues/108');
|
||||
|
|
@ -45,7 +42,7 @@ function issueTests({ fdescribe, describe, it, context, firebase }) {
|
|||
});
|
||||
});
|
||||
|
||||
it('return correct results when not using float values', async() => {
|
||||
it('return correct results when not using float values', async () => {
|
||||
// Setup
|
||||
|
||||
const ref = firebase.native.database().ref('tests/issues/108');
|
||||
|
|
@ -69,6 +66,22 @@ function issueTests({ fdescribe, describe, it, context, firebase }) {
|
|||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('issue_171', () => {
|
||||
context('non array-like values should', () => {
|
||||
it('return as objects', async () => {
|
||||
// Setup
|
||||
|
||||
const ref = firebase.native.database().ref('tests/issues/171');
|
||||
|
||||
// Test
|
||||
|
||||
return ref.once('value').then((snapshot) => {
|
||||
snapshot.val().should.eql(DatabaseContents.ISSUES[171]);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
export default issueTests;
|
||||
|
|
|
|||
|
|
@ -1,4 +1,3 @@
|
|||
import { Platform } from 'react-native';
|
||||
import should from 'should';
|
||||
import sinon from 'sinon';
|
||||
|
||||
|
|
@ -90,10 +89,7 @@ function offTests({ describe, it, xcontext, context, firebase }) {
|
|||
|
||||
// Check childAddedCallback is really attached
|
||||
await ref.push(DatabaseContents.DEFAULT.number);
|
||||
// TODO: Android: There is definitely a single listener, but value is called three times
|
||||
// rather than the two you'd perhaps expect
|
||||
const expectedCount = Platform.OS === 'ios' ? 2 : 3;
|
||||
valueCallback.should.be.callCount(expectedCount);
|
||||
valueCallback.should.be.callCount(2);
|
||||
childAddedCallback.should.be.callCount(arrayLength + 1);
|
||||
|
||||
// Returns nothing
|
||||
|
|
@ -106,7 +102,7 @@ function offTests({ describe, it, xcontext, context, firebase }) {
|
|||
await ref.push(DatabaseContents.DEFAULT.number);
|
||||
|
||||
// Callbacks should have been unbound and not called again
|
||||
valueCallback.should.be.callCount(expectedCount);
|
||||
valueCallback.should.be.callCount(2);
|
||||
childAddedCallback.should.be.callCount(arrayLength + 1);
|
||||
});
|
||||
});
|
||||
|
|
@ -267,10 +263,7 @@ function offTests({ describe, it, xcontext, context, firebase }) {
|
|||
|
||||
// Callback should have been called only once because one of the attachments
|
||||
// has been removed
|
||||
// TODO: Android: There is definitely a single listener, but value is called twice
|
||||
// rather than the once you'd perhaps expect
|
||||
const expectedCount = Platform.OS === 'ios' ? 3 : 4;
|
||||
spyA.should.be.callCount(expectedCount);
|
||||
spyA.should.be.callCount(3);
|
||||
|
||||
// Undo the second attachment
|
||||
const resp2 = await ref.off('value', callbackA);
|
||||
|
|
@ -280,7 +273,7 @@ function offTests({ describe, it, xcontext, context, firebase }) {
|
|||
await ref.set(DatabaseContents.DEFAULT.number);
|
||||
|
||||
// Callback should not have been called any more times
|
||||
spyA.should.be.callCount(expectedCount);
|
||||
spyA.should.be.callCount(3);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -1,23 +1,9 @@
|
|||
import { Platform } from 'react-native';
|
||||
|
||||
import sinon from 'sinon';
|
||||
import 'should-sinon';
|
||||
import Promise from 'bluebird';
|
||||
|
||||
import DatabaseContents from '../../../support/DatabaseContents';
|
||||
|
||||
/**
|
||||
* On Android, some data types result in callbacks that get called twice every time
|
||||
* they are updated. This appears to be behaviour coming from the Android Firebase
|
||||
* library itself.
|
||||
*
|
||||
* See https://github.com/invertase/react-native-firebase/issues/92 for details
|
||||
*/
|
||||
const DATATYPES_WITH_DUPLICATE_CALLBACK_CALLS = [
|
||||
'array',
|
||||
'number',
|
||||
];
|
||||
|
||||
function onTests({ describe, context, it, firebase, tryCatch }) {
|
||||
describe('ref().on(\'value\')', () => {
|
||||
// Documented Web API Behaviour
|
||||
|
|
@ -92,12 +78,7 @@ function onTests({ describe, context, it, firebase, tryCatch }) {
|
|||
// Assertions
|
||||
|
||||
callback.should.be.calledWith(newDataValue);
|
||||
|
||||
if (Platform.OS === 'android' && DATATYPES_WITH_DUPLICATE_CALLBACK_CALLS.includes(dataRef)) {
|
||||
callback.should.be.calledThrice();
|
||||
} else {
|
||||
callback.should.be.calledTwice();
|
||||
}
|
||||
callback.should.be.calledTwice();
|
||||
|
||||
// Tear down
|
||||
|
||||
|
|
@ -171,12 +152,7 @@ function onTests({ describe, context, it, firebase, tryCatch }) {
|
|||
...arrayAsObject,
|
||||
[newElementRef.key]: 37,
|
||||
});
|
||||
|
||||
if (Platform.OS === 'android') {
|
||||
callback.should.be.calledThrice();
|
||||
} else {
|
||||
callback.should.be.calledTwice();
|
||||
}
|
||||
callback.should.be.calledTwice();
|
||||
|
||||
// Tear down
|
||||
|
||||
|
|
@ -251,13 +227,8 @@ function onTests({ describe, context, it, firebase, tryCatch }) {
|
|||
callbackA.should.be.calledWith(newDataValue);
|
||||
callbackB.should.be.calledWith(newDataValue);
|
||||
|
||||
if (Platform.OS === 'android' && DATATYPES_WITH_DUPLICATE_CALLBACK_CALLS.includes(dataRef)) {
|
||||
callbackA.should.be.calledThrice();
|
||||
callbackB.should.be.calledThrice();
|
||||
} else {
|
||||
callbackA.should.be.calledTwice();
|
||||
callbackB.should.be.calledTwice();
|
||||
}
|
||||
callbackA.should.be.calledTwice();
|
||||
callbackB.should.be.calledTwice();
|
||||
|
||||
// Tear down
|
||||
|
||||
|
|
@ -317,12 +288,7 @@ function onTests({ describe, context, it, firebase, tryCatch }) {
|
|||
// Assertions
|
||||
|
||||
context.value.should.eql(newDataValue);
|
||||
|
||||
if (Platform.OS === 'android' && DATATYPES_WITH_DUPLICATE_CALLBACK_CALLS.includes(dataRef)) {
|
||||
context.callCount.should.eql(3);
|
||||
} else {
|
||||
context.callCount.should.eql(2);
|
||||
}
|
||||
context.callCount.should.eql(2);
|
||||
|
||||
// Tear down
|
||||
|
||||
|
|
@ -389,12 +355,7 @@ function onTests({ describe, context, it, firebase, tryCatch }) {
|
|||
// Assertions
|
||||
|
||||
context.value.should.eql(newDataValue);
|
||||
|
||||
if (Platform.OS === 'android' && DATATYPES_WITH_DUPLICATE_CALLBACK_CALLS.includes(dataRef)) {
|
||||
context.callCount.should.eql(3);
|
||||
} else {
|
||||
context.callCount.should.eql(2);
|
||||
}
|
||||
context.callCount.should.eql(2);
|
||||
|
||||
// Tear down
|
||||
|
||||
|
|
|
|||
|
|
@ -23,6 +23,14 @@ export default {
|
|||
},
|
||||
},
|
||||
|
||||
QUERY: [{
|
||||
search: 'foo',
|
||||
}, {
|
||||
search: 'bar',
|
||||
}, {
|
||||
search: 'blah',
|
||||
}],
|
||||
|
||||
ISSUES: {
|
||||
// https://github.com/invertase/react-native-firebase/issues/100
|
||||
100: {
|
||||
|
|
@ -55,5 +63,33 @@ export default {
|
|||
latitude: 37,
|
||||
},
|
||||
},
|
||||
|
||||
// https://github.com/invertase/react-native-firebase/issues/171
|
||||
171: {
|
||||
10053768200609241: {
|
||||
email: 'emaila@hotmail.com',
|
||||
name: 'Sek Ranger',
|
||||
profile_picture: 'https://url.to/picture',
|
||||
uid: 'n6V8vACidyW4OKxnELkBbW83JaS2',
|
||||
},
|
||||
10053925505239749: {
|
||||
email: 'emailb@hotmail.com',
|
||||
name: 'Gu Hungry',
|
||||
profile_picture: 'https://url.to/picture',
|
||||
uid: 'Qq4Pwm7H2kO6sJIMLAJxuhAGGh22',
|
||||
},
|
||||
10106631429240929: {
|
||||
email: 'emailc@gmail.com',
|
||||
name: 'Chwang',
|
||||
profile_picture: 'https://url.to/picture',
|
||||
uid: 'T7VVrveS0dPs3idmgetLUfQsLZs1',
|
||||
},
|
||||
10106631429240930: {
|
||||
email: 'emaild@gmail.com',
|
||||
name: 'Introv Bigs',
|
||||
profile_picture: 'https://url.to/picture',
|
||||
uid: 'aNYxLexOb2WsXGOPiEAu47q5bxH3',
|
||||
},
|
||||
},
|
||||
},
|
||||
};
|
||||
|
|
|
|||
Loading…
Reference in New Issue