diff --git a/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfig.java b/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfig.java index 465f3508..4e1c5c09 100644 --- a/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfig.java +++ b/android/src/main/java/io/invertase/firebase/config/RNFirebaseRemoteConfig.java @@ -120,7 +120,7 @@ class RNFirebaseRemoteConfig extends ReactContextBaseJavaModule { @Override public void onComplete(@NonNull Task task) { if (task.isSuccessful()) { - promise.resolve("config/success"); + promise.resolve(null); } else { if (task.getException() instanceof FirebaseRemoteConfigFetchThrottledException) { promise.reject("config/throttled", "fetch() operation cannot be completed successfully, due to throttling.", task.getException()); @@ -159,7 +159,6 @@ class RNFirebaseRemoteConfig extends ReactContextBaseJavaModule { map.putNull(NUMBER_VALUE); } - // TODO check with ios switch (value.getSource()) { case FirebaseRemoteConfig.VALUE_SOURCE_DEFAULT: map.putString(SOURCE, "default"); diff --git a/ios/RNFirebase/config/RNFirebaseRemoteConfig.m b/ios/RNFirebase/config/RNFirebaseRemoteConfig.m index 03fd73c7..ecb7a849 100644 --- a/ios/RNFirebase/config/RNFirebaseRemoteConfig.m +++ b/ios/RNFirebase/config/RNFirebaseRemoteConfig.m @@ -61,7 +61,7 @@ RCT_EXPORT_METHOD(fetch: if (error) { reject(convertFIRRemoteConfigFetchStatusToNSString(status), convertFIRRemoteConfigFetchStatusToNSStringDescription(status), error); } else { - resolve(convertFIRRemoteConfigFetchStatusToNSString(status)); + resolve(nil); } }]; } @@ -75,7 +75,7 @@ RCT_EXPORT_METHOD(fetchWithExpirationDuration: if (error) { reject(convertFIRRemoteConfigFetchStatusToNSString(status), convertFIRRemoteConfigFetchStatusToNSStringDescription(status), error); } else { - resolve(convertFIRRemoteConfigFetchStatusToNSString(status)); + resolve(nil); } }]; }