From 8859f630411d855a154b5ffce7f837e99fc4f75a Mon Sep 17 00:00:00 2001 From: Wes Zheng Date: Fri, 20 Oct 2017 10:40:06 -0700 Subject: [PATCH 1/3] use application context to avoid deallocated view error when split screen on android --- .../main/java/com/dylanvann/fastimage/FastImageViewManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java b/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java index 99e08e0..1c3ea78 100644 --- a/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java +++ b/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java @@ -140,7 +140,7 @@ class FastImageViewManager extends SimpleViewManager implement eventEmitter.receiveEvent(viewId, REACT_ON_LOAD_START_EVENT, new WritableNativeMap()); Glide - .with(view.getContext()) + .with(view.getContext().getApplicationContext()) .load(glideUrl) .priority(priority) .placeholder(TRANSPARENT_DRAWABLE) From 4e2dba49245d80a672b3e13d3b4633f19dca239d Mon Sep 17 00:00:00 2001 From: Wes Zheng Date: Mon, 30 Oct 2017 14:28:34 -0700 Subject: [PATCH 2/3] Minor import style fix --- ios/FastImage/FFFastImageView.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ios/FastImage/FFFastImageView.h b/ios/FastImage/FFFastImageView.h index e98ed43..7d249c8 100644 --- a/ios/FastImage/FFFastImageView.h +++ b/ios/FastImage/FFFastImageView.h @@ -2,7 +2,7 @@ #import #import -#import "FLAnimatedImageView.h" +#import #import #import From 1d16c7c21832ab6bc5501072e8f9f16d663f4e39 Mon Sep 17 00:00:00 2001 From: Wes Zheng Date: Mon, 30 Oct 2017 17:38:11 -0700 Subject: [PATCH 3/3] Fix for yarn not fetching git submodules --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 9f9ed69..1c4e603 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,8 @@ "format": "prettier --write --no-semi --single-quote --trailing-comma all ./FastImage.js ./example/*.js ./server/*.js", "test": "yarn run test:pretty && yarn run test:jest", "test:jest": "jest *.js", - "test:pretty": "prettier-check --write --no-semi --single-quote --trailing-comma all ./FastImage.js ./example/*.js ./server/*.js" + "test:pretty": "prettier-check --write --no-semi --single-quote --trailing-comma all ./FastImage.js ./example/*.js ./server/*.js", + "postinstall": "git clone https://github.com/rs/SDWebImage.git ios/Vendor/SDWebImage && cd ios/Vendor/SDWebImage && git submodule update --init --recursive && cd ../../.." }, "devDependencies": { "babel-jest": "^20.0.3",