status-im
/
react-native-fast-image
mirror of https://github.com/status-im/react-native-fast-image.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update obsolete compile to implementation and Exclude app dependencies from test configurations (#250) 

FIRST OF ALL, I am using this package from npm so I saw that the git repo one commit ahead that is this one f31a44fc07 (diff-7ae5a9093507568eabbf35c3b0665732) where you upgrade to glide 4 with progress listeners. I couldn't submit PR for the version I am using from NPM. so as of now explain of this PR is as follow:


As React native 0.56.0 is released with MAJOR android changes such as:

-Gradle 3.5.1
-Compile using Android SDK 26
-Google Maven repo
-etc

more about Change log, specially of Android Here, https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-projects-are-now-compiled-using-the-android-26-sdk
and https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-specific-changes

Aslo as Per Google new "Google Play's target API level requirement", mentioned here  https://developer.android.com/distribute/best-practices/develop/target-sdk

"Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018."

It's clear that Android would be moving to new Gradle and new SDK changes, Thus creating a new type of error that is:

"Configuration 'compile' is obsolete and has been replaced with 'implementation' or 'Api'" 

more about the Old and new configuration please see this https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations 
at the heading of "Use the new dependency configurations"

Therefore, all old "compile" should be now "implementation" or "provided" should be "compileOnly"

I have tested the with "compile" and "implementation" in my current release ready product and also by "renaming" "compile" to "implementation".
Also tested with higher andorid SDK configs such as of below:

```
ext {
    buildToolsVersion = "27.0.3"
    minSdkVersion = 19
    compileSdkVersion = 27
    targetSdkVersion = 27
    supportLibVersion = "27.1.1"
}
```

so SDK 27 was also compiled successully. test on Android phone with ADK 23 all looks good. Thus, `react-native-fast-image` was working just fine as intended. thank you so much for this package btw.

Therefore, Please would it be possible to merge as i am sure many new projects and old one are going to update specially Gradle and SDK as of Google new requirements. 

related mention of Upgrading issue mention here https://github.com/facebook/react-native/issues/20273#issuecomment-405959030


Moreover, if someone still have any issue after upgrading everything successfully, then he should use following in build.gradle under `andorid/build.gradle`

```

subprojects {
    afterEvaluate {project ->
        if (project.hasProperty("android")) {
            android {
                compileSdkVersion 27
                buildToolsVersion '27.0.3'
                supportLibVersion = "27.1.1"
            }
        }
    }
}
```


PS: as of exclude part in your build.grade, I am not 100% it will work for example mine app has something like this

compile project((':react-native-maps')) {
        exclude group: 'com.google.android.gms', module: 'play-services-base'
        exclude group: 'com.google.android.gms', module: 'play-services-maps'
}
compile 'com.google.android.gms:play-services-base:10.0.1'
compile 'com.google.android.gms:play-services-maps:10.0.1'


after converting this to


implementation project(':react-native-maps')
 android.testVariants.all { variant ->
        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'
        variant.getRuntimeConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'

        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'
        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'
}
implementation 'com.google.android.gms:play-services-base:10.0.1'
implementation 'com.google.android.gms:play-services-maps:10.0.1'


everything is working fine for me. so please have a look for your just in case.
This commit is contained in:
Danish 2018-09-23 23:33:31 +03:00 committed by Dylan Vann
parent 5d973a8cec
commit 649e9a8edf
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
android/build.gradle
View File

@ -53,13 +53,19 @@ repositories {
dependencies {
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:${_reactNativeVersion}"
implementation "com.android.support:support-v4:${safeExtGet("supportLibVersion", "27.1.1")}"
implementation("com.github.bumptech.glide:glide:${_glideVersion}") {
exclude group: "com.android.support", module: "glide"
implementation "com.android.support:support-v4:${_compileSdkVersion}"
implementation("com.github.bumptech.glide:glide:${_glideVersion}")
android.testVariants.all { variant ->
variant.getCompileConfiguration().exclude group: 'com.android.support', module: 'glide'
variant.getRuntimeConfiguration().exclude group: 'com.android.support', module: 'glide'
}
implementation("com.github.bumptech.glide:annotations:${_glideVersion}") {
exclude group: "com.android.support", module: "annotations"
implementation("com.github.bumptech.glide:annotations:${_glideVersion}")
android.testVariants.all { variant ->
variant.getCompileConfiguration().exclude group: 'com.android.support', module: 'annotations'
variant.getRuntimeConfiguration().exclude group: 'com.android.support', module: 'annotations'
}
annotationProcessor "com.github.bumptech.glide:compiler:${_glideVersion}"
implementation("com.github.bumptech.glide:okhttp3-integration:${_glideVersion}") {
exclude group: "com.android.support", module: "okhttp3-integration"