Commit Graph

36 Commits

Author SHA1 Message Date
Harry Yu ec33d328af
feat: Added imageSize and playableDuration to `include` param, deletes isStored (#187)
BREAKING CHANGE: imageSize and playableDuration are no longer included by default to improve performance
2020-06-23 08:45:20 +03:00
Bartol Karuza 4da8310892
feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178) (#200)
BREAKING CHANGE: meta data is no longer added as default. This applies to `fileName`, `fileSize` and `location`. If you need this metadata use the new `include` parameter. Adding this metadata will slow down the `getPhotos` function, so consider only retrieving this meta data for smaller sets of images as needed, instead of for all images.

* Created getPhotosFast function, fixed inconsistent getPhotos toDate logic

* Fixed wrong param name, added better typechecking

* Added example, renamed allowEmptyFilenames to skipGettingFilenames

* Removed `after` from getPhotosFast docs

* Redid implementation based on a new `include` param

* Updated API to use include parameter

* Fixed flow checking by converting index.ts to Typescript

* Unformatted README.md

* Unformatted README.md

* Unformatted README.md

* Added .prettierignore and ignored README.md for now

* Made example/index.js not checked by Flow

* Updated README.md to include notes in the outputs too

* Made inclusion of fields consistent, addressed other feedback

* Renamed GetPhotosFastParams back to GetPhotosParams

* Updated documentation to reflect nullable types

* Updated typings and documentation for fromTime, toTime

* Updated to fix `hasNextPage` being incorrectly false in some cases

Co-authored-by: Harry Yu <hy.harry.yu@gmail.com>
2020-06-16 13:20:51 +03:00
Bartol Karuza e65e1f208b
fix: Revert "feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178)" (#199) 2020-06-16 13:05:12 +03:00
Harry Yu e54a6afa8b
feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178)
* Created getPhotosFast function, fixed inconsistent getPhotos toDate logic

* Fixed wrong param name, added better typechecking

* Added example, renamed allowEmptyFilenames to skipGettingFilenames

* Removed `after` from getPhotosFast docs

* Redid implementation based on a new `include` param

* Updated API to use include parameter

* Fixed flow checking by converting index.ts to Typescript

* Unformatted README.md

* Unformatted README.md

* Unformatted README.md

* Added .prettierignore and ignored README.md for now

* Made example/index.js not checked by Flow

* Updated README.md to include notes in the outputs too

* Made inclusion of fields consistent, addressed other feedback

* Renamed GetPhotosFastParams back to GetPhotosParams

* Updated documentation to reflect nullable types

* Updated typings and documentation for fromTime, toTime

* Updated to fix `hasNextPage` being incorrectly false in some cases
2020-06-16 12:07:25 +03:00
Harry Yu 057acd815b
chore: Updated example to build and run on latest React Native (#177)
* Updated example to build and run on latest React Native

* Fixed `yarn test:detox` release builds

* Added missing downloadDependencies CircleCI task
2020-05-20 20:57:46 +03:00
Thomas Schaaf 3df3c5777f chore(example): Show correct date in example code (#129) 2020-01-20 16:55:23 +08:00
Bartol Karuza 452fd7bf04 fix(example): remove flow parsing from example 2019-11-07 14:24:54 +01:00
Bartol Karuza 8c3a108dab chore(example): fix example for usage by rn tester 2019-09-22 14:34:14 +02:00
Bartol Karuza e4b651c810 chore(example): remove dev dependencies from example 2019-09-22 13:38:56 +02:00
Bartol Karuza eb538ab3ba
Merge pull request #40 from react-native-community/feature/turn-off-ci-e2e-and-example-fix
Feature/turn off ci e2e and example fix
2019-04-22 20:39:39 +02:00
Bartol Karuza 6b1a0d3dc2 chore(ci) turn off the e2e steps to allow a semantic release 2019-04-14 12:54:41 +02:00
Bartol Karuza e19ff9d680 chore(lib) make the example less glitchy by fixing the width 2019-04-14 12:52:43 +02:00
Bartol Karuza ae52098925
Merge pull request #24 from scarlac/bugfix-18-default-to-all
Default groupTypes to "All"
2019-04-14 10:52:57 +02:00
Bartol Karuza d20a7e9985 fix(test) detox test import path fix 2019-04-11 20:15:32 +02:00
Seph Soliman cebf6f39f0 Default groupTypes to "All". Fixes #18 2019-04-06 11:04:16 -07:00
Matt Oakes 5129c67e30 Put the bundling script back to the origional to allow release testing to work again 2019-04-06 09:31:14 -07:00
Bartol Karuza 04be343929
Merge branch 'master' into standard-eslint 2019-04-06 11:10:44 +02:00
Matt Oakes ffbbfee27c Standard ESLint 2019-04-05 17:14:27 -07:00
Matt Oakes f0529516af Add the required manifest flag to connect to the detox server 2019-03-29 12:23:13 -07:00
Matt Oakes f538156b9d WIP: Add the required settings to avoid Javscript errors for Android Detox tests 2019-03-16 19:35:47 +00:00
Matt Oakes 9767e37e00
test(android): Ensure the "release" app has the Javascript bundled 2019-03-14 15:40:26 +00:00
Bartol Karuza ad3a2216ba fix(js) import paths 2019-03-03 18:54:13 +08:00
Bartol Karuza 7077b84036 chore(android) add missing example release keystore 2019-03-03 16:07:34 +08:00
Bartol Karuza 5a60b909e4 chore(android) fix missing folder issue on release build bundle copy 2019-03-03 16:01:47 +08:00
Bartol Karuza e062a47853 chore(ios) fix release step bundle location 2019-03-03 15:55:21 +08:00
Bartol Karuza d4a7ab7194 chore(android) fix native build 2019-03-03 15:43:30 +08:00
Bartol Karuza 5e7fa0edc8 fix missing android dependency download task 2019-03-03 14:47:09 +08:00
Bartol Karuza 0c453b6118 general cleanup
Added typescript binding
Fixed flow type issues
renamed NativeModule to RNCCameraRoll
Added basic jest tests
prettier/lint issues fixed
2019-03-03 14:39:57 +08:00
Bartol Karuza 9f176640d8 e2e configuration and example transferred 2019-03-02 17:01:34 +08:00
Bartol Karuza 4777d05546 Make lib JS+native code reachable from iOS example app 2019-02-24 20:47:44 +08:00
Bartol Karuza b00c05bb81 fix iOS library file reference 2019-02-24 13:48:37 +08:00
Bartol Karuza eba943154e Android example point to example/index.js 2019-02-24 13:33:42 +08:00
Bartol Karuza 605302a517 fix up Android example project to compilation 2019-02-24 13:30:55 +08:00
Bartol Karuza c8e2a7bd77 cleanup iOS example project 2019-02-24 13:13:43 +08:00
Bartol Karuza c3cdd18810 setup of library config files for flow, eslint, babel, jest, etc.. 2019-02-24 12:57:12 +08:00
Bartol Karuza 1f3f111bca create-react-native-library and react-native init of example app
# Conflicts:
#	README.md
2019-02-24 12:13:49 +08:00