Commit Graph

24 Commits

Author SHA1 Message Date
Harry Yu ec33d328af
feat: Added imageSize and playableDuration to `include` param, deletes isStored (#187)
BREAKING CHANGE: imageSize and playableDuration are no longer included by default to improve performance
2020-06-23 08:45:20 +03:00
Bartol Karuza 4da8310892
feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178) (#200)
BREAKING CHANGE: meta data is no longer added as default. This applies to `fileName`, `fileSize` and `location`. If you need this metadata use the new `include` parameter. Adding this metadata will slow down the `getPhotos` function, so consider only retrieving this meta data for smaller sets of images as needed, instead of for all images.

* Created getPhotosFast function, fixed inconsistent getPhotos toDate logic

* Fixed wrong param name, added better typechecking

* Added example, renamed allowEmptyFilenames to skipGettingFilenames

* Removed `after` from getPhotosFast docs

* Redid implementation based on a new `include` param

* Updated API to use include parameter

* Fixed flow checking by converting index.ts to Typescript

* Unformatted README.md

* Unformatted README.md

* Unformatted README.md

* Added .prettierignore and ignored README.md for now

* Made example/index.js not checked by Flow

* Updated README.md to include notes in the outputs too

* Made inclusion of fields consistent, addressed other feedback

* Renamed GetPhotosFastParams back to GetPhotosParams

* Updated documentation to reflect nullable types

* Updated typings and documentation for fromTime, toTime

* Updated to fix `hasNextPage` being incorrectly false in some cases

Co-authored-by: Harry Yu <hy.harry.yu@gmail.com>
2020-06-16 13:20:51 +03:00
Bartol Karuza e65e1f208b
fix: Revert "feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178)" (#199) 2020-06-16 13:05:12 +03:00
Harry Yu e54a6afa8b
feat: Added `include` parameter to getPhotos to let users tradeoff performance by omitting metadata (#178)
* Created getPhotosFast function, fixed inconsistent getPhotos toDate logic

* Fixed wrong param name, added better typechecking

* Added example, renamed allowEmptyFilenames to skipGettingFilenames

* Removed `after` from getPhotosFast docs

* Redid implementation based on a new `include` param

* Updated API to use include parameter

* Fixed flow checking by converting index.ts to Typescript

* Unformatted README.md

* Unformatted README.md

* Unformatted README.md

* Added .prettierignore and ignored README.md for now

* Made example/index.js not checked by Flow

* Updated README.md to include notes in the outputs too

* Made inclusion of fields consistent, addressed other feedback

* Renamed GetPhotosFastParams back to GetPhotosParams

* Updated documentation to reflect nullable types

* Updated typings and documentation for fromTime, toTime

* Updated to fix `hasNextPage` being incorrectly false in some cases
2020-06-16 12:07:25 +03:00
Bartol Karuza aa47532fdb
fix: deprecate saveToCameraRoll (#183)
fixes #182
2020-05-21 10:52:27 +03:00
Antonio Gallo e7cf8665d4
feat: Added fileSize for getPhotos API (#180)
Co-authored-by: Antonio Gallo <antgallo@amazon.com>
2020-05-20 20:35:59 +03:00
Jesse Katsumata 4190ac9c1e
chore: update and fix lint error (#153)
* chore: update eslint config

* chore: apply prettier

* Run CI
2020-03-26 10:19:13 +02:00
Tuan Luong fc1855e001
feat: get album list (#139) 2020-02-08 11:17:56 +08:00
Kevin Brown 7850dd538f feat(lib): Moved deletePhotos to use new PHAsset API and added an implementation for Android (#69)
* deletePhotos works in iOS

* Deletion works on Android.

* Removing unnecessary commented out code.

* Updated typescript typings.

* Made readme more accurate based on being able to retrieve failure from the iOS API.

* Let formatter run, also now rejecting the promise when there's any error on deletion on Android.
2019-11-07 14:13:24 +01:00
Bartol Karuza 7519cb5fa8 fix(lib): fix issue with CameraRoll.saveImageWithTag and new save function with options 2019-08-14 21:31:43 +02:00
SimonErm dc00a4f115 feat(lib): save photos or videos to an album
* add option to specify album in saveToCameraRoll and move the optional type param to options

* check platform before setting default value for group types to prevent exception

* adjust typings

* update invariant message

* format code

* extract new implementation to function to avoid breaking change

* format code

* add missing spaces

* fix(lib): add accidentally removed savedphotos back to the enum to prevent crash

* chore(lib): formatting

* chore(lib): add doc for the new save method
2019-08-14 21:00:20 +02:00
Bartol Karuza 5678c76c0e fix(lib): dummy commit back to the center fix semantic-release 2019-05-13 21:20:53 +02:00
Bartol Karuza 33af0183f1 fix(lib): dummy commit fix semantic-release 2019-05-13 21:15:09 +02:00
Bartol Karuza 66cb1752ff fix(lib): dummy commit fix semantic-release 2019-05-13 21:09:30 +02:00
Bartol Karuza d4319003a0 fix(lib): dummy commit to bump to 1.0.2 2019-05-13 21:03:06 +02:00
Bartol Karuza ae52098925
Merge pull request #24 from scarlac/bugfix-18-default-to-all
Default groupTypes to "All"
2019-04-14 10:52:57 +02:00
Seph Soliman cebf6f39f0 Default groupTypes to "All". Fixes #18 2019-04-06 11:04:16 -07:00
Matt Oakes ffbbfee27c Standard ESLint 2019-04-05 17:14:27 -07:00
Bartol Karuza 0d1059ef75 fix(js) provide default value for optional ‘assetType’ 2019-03-03 20:46:47 +08:00
Bartol Karuza 7df7d44a6b fix(js) native modules path relative to the consumer project 2019-03-03 20:20:17 +08:00
Bartol Karuza 595e65fd18 fix(js) remove legacy proptypes and fix paths 2019-03-03 20:12:30 +08:00
Bartol Karuza ad3a2216ba fix(js) import paths 2019-03-03 18:54:13 +08:00
Bartol Karuza 0c453b6118 general cleanup
Added typescript binding
Fixed flow type issues
renamed NativeModule to RNCCameraRoll
Added basic jest tests
prettier/lint issues fixed
2019-03-03 14:39:57 +08:00
Bartol Karuza c3cdd18810 setup of library config files for flow, eslint, babel, jest, etc.. 2019-02-24 12:57:12 +08:00