From 3443f75f9cbe6fe28af3026b3dbf979c28cfb41e Mon Sep 17 00:00:00 2001 From: Ram N Date: Fri, 9 Nov 2018 10:48:49 -0800 Subject: [PATCH] Use static constants instead of strings when referring to View Managers and Native Modules Summary: Using strings to refer to Native Modules and View Managers in ReactPackages are prone to error. The compiler replaces the constants with the actual strings anyway, so using constants gives us better type safety Reviewed By: achen1 Differential Revision: D12843649 fbshipit-source-id: 7a7c6c854c8689193f40df92dc8426a3b37f82c8 --- CameraRollManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CameraRollManager.java b/CameraRollManager.java index 8a6ab9052..21b8059a9 100644 --- a/CameraRollManager.java +++ b/CameraRollManager.java @@ -56,7 +56,7 @@ import javax.annotation.Nullable; @ReactModule(name = CameraRollManager.NAME) public class CameraRollManager extends ReactContextBaseJavaModule { - protected static final String NAME = "CameraRollManager"; + public static final String NAME = "CameraRollManager"; private static final String ERROR_UNABLE_TO_LOAD = "E_UNABLE_TO_LOAD"; private static final String ERROR_UNABLE_TO_LOAD_PERMISSION = "E_UNABLE_TO_LOAD_PERMISSION";