From a2d39f0971a344f53991681d9fa0a3fa01727d5b Mon Sep 17 00:00:00 2001 From: Bartol Karuza Date: Tue, 18 Jun 2019 17:32:38 +0200 Subject: [PATCH] fix(lib): move to local variable instead of relying on the string constant from RN core (#63) --- ios/RNCAssetsLibraryRequestHandler.m | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ios/RNCAssetsLibraryRequestHandler.m b/ios/RNCAssetsLibraryRequestHandler.m index e205ed1..9b2ff87 100644 --- a/ios/RNCAssetsLibraryRequestHandler.m +++ b/ios/RNCAssetsLibraryRequestHandler.m @@ -20,6 +20,8 @@ @implementation RNCAssetsLibraryRequestHandler +NSString *const PHUploadScheme = @"ph-upload"; + RCT_EXPORT_MODULE() #pragma mark - RNCURLRequestHandler @@ -32,7 +34,7 @@ RCT_EXPORT_MODULE() return [request.URL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame || [request.URL.scheme caseInsensitiveCompare:@"ph"] == NSOrderedSame - || [request.URL.scheme caseInsensitiveCompare:RCTNetworkingPHUploadHackScheme] == NSOrderedSame; + || [request.URL.scheme caseInsensitiveCompare:PHUploadScheme] == NSOrderedSame; } - (id)sendRequest:(NSURLRequest *)request @@ -44,9 +46,9 @@ RCT_EXPORT_MODULE() }; NSURL *requestURL = request.URL; - BOOL isPHUpload = [requestURL.scheme caseInsensitiveCompare:RCTNetworkingPHUploadHackScheme] == NSOrderedSame; + BOOL isPHUpload = [requestURL.scheme caseInsensitiveCompare:PHUploadScheme] == NSOrderedSame; if (isPHUpload) { - requestURL = [NSURL URLWithString:[@"ph" stringByAppendingString:[requestURL.absoluteString substringFromIndex:RCTNetworkingPHUploadHackScheme.length]]]; + requestURL = [NSURL URLWithString:[@"ph" stringByAppendingString:[requestURL.absoluteString substringFromIndex:PHUploadScheme.length]]]; } if (!requestURL) {