Commit Graph

102 Commits

Author SHA1 Message Date
alon bar david af801c2b28 images in gallery should be at the correct orientation on android 2017-09-06 23:30:23 +03:00
Guy Carmeli fa50070318 Fix isGoogleDevice method
Originally, we thought the upside down selfie photos issue was
exclusive to Nexus 6 and Pixel devices. Apparently it's reproducible on
Nexus 5 as well.
2017-08-22 17:19:40 +03:00
Johan Haneveld a7cb5637af Handle Android RN 0.47 breaking change
Fix for a breaking change in React Native 47. createJSModules function is now deprecated and the @override breaks it. Probably remove the whole function
2017-08-17 12:26:07 +02:00
Guy Carmeli 08181f64d1 Refactor out orientation calculations to seperate class 2017-08-09 19:42:17 +03:00
Guy Carmeli e569b85325 Use default device orientation for preview mode
Still uses device orientation sensor to detect landscape/portrait photos
2017-08-09 19:14:42 +03:00
Guy Carmeli 8d692b2545 Check if camera is open before interacting with it 2017-08-08 15:42:37 +03:00
Guy Carmeli 8dbadcf41c Support landscape orientation
Track device orientation and update camera rotation accordingly
2017-08-08 14:14:03 +03:00
Guy Carmeli 77ebaf4fe5 Remove log import 2017-08-02 11:22:15 +03:00
Guy Carmeli 7564b07659 Set 16:9 as max screen resolution
Since Camera API 1 doesn't support the new 18:9 and 18.5:9 screen
aspect ratio, convert aspect ratio, if needed, to the max supported
ratio - 16:9.
2017-08-02 11:15:37 +03:00
Guy Carmeli a88cb4638f Fix warnings
removed unused method and weaken access modifiers
2017-08-02 10:54:37 +03:00
Daniel Vicory 52f16b79ef Fix memory leak caused by using the view to post to the UI thread (#52)
Use ReactContext to run on the UI thread and pass it down to SelectableImage, which also
cleans up some of the casting.

Using LeakCanary:
* com.wix.RNCameraKit.gallery.GalleryView has leaked:
* GC ROOT android.os.HandlerThread.localValues
* references java.lang.ThreadLocal$Values.table
* references array java.lang.Object[].[3]
* references android.view.ViewRootImpl$RunQueue.mActions
* references java.util.ArrayList.array
* references array java.lang.Object[].[0]
* references android.view.ViewRootImpl$RunQueue$HandlerAction.action
* references com.wix.RNCameraKit.gallery.GalleryAdapter$1.this$0 (anonymous implementation of java.lang.Runnable)
* references com.wix.RNCameraKit.gallery.GalleryAdapter.mObservable
* references android.support.v7.widget.RecyclerView$AdapterDataObservable.mObservers
* references java.util.ArrayList.array
* references array java.lang.Object[].[0]
* references android.support.v7.widget.RecyclerView$RecyclerViewDataObserver.this$0
* leaks com.wix.RNCameraKit.gallery.GalleryView instance
2017-07-30 09:33:36 +03:00
Ran 1faf1afee3 Merge pull request #46 from misogl/patch-1
Fix crash when changing flash mode on front camera
2017-07-22 09:05:22 +03:00
Artal Druk b271403d4b StoragePermission: in case permissions are already granted - return after the promise is resolved, there’s no need to request the permission. This case might lead to a crash since when onRequestPermissionsResult is called, the promise will be resolved again (the same promise cannot be resolved more than 1 time).
Also, clear the stored requestAccessPromise after it’s resolved - for the same reasons.
2017-07-09 16:26:00 +03:00
gevorg94 fd306016eb pass overlayColor to selected image [android] 2017-06-30 11:40:14 +04:00
Lev Vidrak 3cf4831c40 Fixed resize image method - include source image’s keys that was not changed 2017-06-29 19:27:46 +03:00
Michal Glaus 429ccf22e7 Fix crash when changing flash mode on front camera
`getSupportedFlashModes` returns null for front camera on most devices.
2017-06-29 18:22:39 +02:00
Lev Vidrak 6295dd6c0f WOA-3924 - (Performance) Image uploading in feed post and chat is slo… (#45)
* WOA-3924 - (Performance) Image uploading in feed post and chat is slow - Added resizeImage functionality in Android

* Change resolution to be exactly like on iOS
2017-06-26 10:09:32 +03:00
Guy Carmeli 771b7cb030 Add missing recyclerview dependency 2017-05-30 13:21:32 +03:00
Artal Druk 604bc5bd2e provide image width and height on tap events 2017-05-28 14:42:34 +03:00
Sergey Ilyevsky bcd59eda46 Fixed size, width and height params on iOS for resized images. Added width and height on Android 2017-05-16 12:59:36 +03:00
Artal Druk 4fe138fe2a - support capture/retake mode on the full screen camera on Android
- delete the temp file (created in capture/retake) when canceled
2017-03-22 18:40:35 +02:00
Amit Davidi 28f28525c0 Android: Add gallery refresh hack to empty galleries to work around end use-cases 2017-03-19 12:11:16 +02:00
Amit Davidi a6ed80e65a Android: Fix nonrefreshing gallery after taking pictures 2017-03-15 09:48:16 +02:00
Amit Davidi 5a7139fc7f Android: restore scrollby(0) hack cause removing it didnt fix the bug 2017-03-08 16:57:26 +02:00
Amit Davidi 2e04bc4dc5 Android: Remove scrollBy(0) hack to try to fix scroll-to-top bug 2017-03-08 15:42:09 +02:00
Amit Davidi c2817a80f9 Android: Better sync data refreshing in hopes to fix scroll-to-top bug 2017-03-08 15:12:10 +02:00
Guy Carmeli efbdf6ddbc Rename method 2017-03-05 14:32:06 +02:00
Amit Davidi 9f3bf01e7c Android: Add comment to explain refreshing hack 2017-03-02 14:53:26 +02:00
Amit Davidi 997c7a8218 Android: Add a fix for a potential instability due to a layout-manager swap 2017-03-02 09:34:29 +02:00
Amit Davidi 9280b205f3 Android: Found potential hack-fix for empty recyclerview after album-switch 2017-03-01 22:52:41 +02:00
Amit Davidi b4cbdd4b1a Android: Reinstate code with previous album-switch bug 2017-03-01 22:25:56 +02:00
Amit Davidi de5be5e3ad Android: Fix numerous issues found in integ with media-manager 2017-03-01 22:15:06 +02:00
Amit Davidi 371e2b3ae6 Android: Change setter to expect an int as the custom-button bkg color instead of string 2017-03-01 12:37:02 +02:00
Amit Davidi ea139bfeff Android: rename selection props 2017-03-01 12:29:24 +02:00
Amit Davidi 2317e9191f Android: Allow for selection disabling state 2017-03-01 12:24:15 +02:00
Amit Davidi 1754c12cdd Android: Add support in selection image positioning and size-type 2017-03-01 09:19:58 +02:00
Amit Davidi 6cb87193de Android: Fix config/refreshData race causing config to be left out 2017-02-28 16:29:55 +02:00
Amit Davidi fd901d3bbe Android: Add support for custom-button on-press JS callback + refactoring and cleanup 2017-02-28 15:00:26 +02:00
Amit Davidi b9ab865cee Android: Fixed potential bug in gallery refreshing 2017-02-27 19:25:48 +02:00
Amit Davidi d0c4a3e267 Android: Generalize embedded camera feature to a custom button 2017-02-27 18:34:58 +02:00
Amit Davidi 7d1c490607 Cancel embedded camera button by-default usage 2017-02-27 16:12:18 +02:00
Amit Davidi bb251d6445 Android: Add support in optional embedding of camera button in gallery + empty-state preload fix 2017-02-27 13:45:23 +02:00
Guy Carmeli 3be6180817 Resolve requestAccess immediately if permissions are granted 2017-02-26 09:49:52 +02:00
Guy Carmeli 1a484680d9 Resolve requestAccess immediately if permissions are granted 2017-02-26 09:47:15 +02:00
Guy Carmeli eabfc122f9 Correct shared preferences name 2017-02-21 10:12:25 +02:00
Guy Carmeli 91f38fbd6a Support Android runtime permissions 2017-02-20 18:48:03 +02:00
Yedidya Kennard e85be818b3 Added width and height to getImagesForIds in Android 2017-01-22 11:46:27 +02:00
Daniel Zlotin aecdb8690b fixed build.gradle 2016-11-25 13:34:50 +02:00
Daniel Zlotin 42e0929e05 fixed for rn 38 2016-11-25 13:20:00 +02:00
Guy Carmeli 1e7e298ca5 Add dirtyImages property to GalleryView
This change is needed since when editing an image and the corresponding
uri doesn’t change, the images thumbnail wouldn't redraw.
2016-11-23 17:27:18 +02:00